[vscode-go] extension/src/language: extend range support to type def
5 views
Skip to first unread message
Hongxiang Jiang (Gerrit)
Dec 5, 2025, 9:46:43 PM (11 days ago) Dec 5
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Hongxiang Jiang has uploaded the change for review![]( "Open in Gerrit")
Commit message
extension/src/language: extend range support to type def
gopls.lsp is triggered programmerly by the language client,
if error encountered, the vscode will pop up notifications
as if the ongoing LSP method is blocking. This CL also
suppress the error encountered gopls.lsp command.
Change-Id: Ia064a7bb149bee632198c7affb0e975de2fe7e0c
Change diff
diff --git a/extension/src/language/goLanguageServer.ts b/extension/src/language/goLanguageServer.ts
index 735f751..6d08f83 100644
--- a/extension/src/language/goLanguageServer.ts
+++ b/extension/src/language/goLanguageServer.ts
@@ -477,6 +477,31 @@
}
},
middleware: {
+ provideTypeDefinition: async (doc, pos, token, next) => {
+ if (!goCtx.languageClient) {
+ return await next(doc, pos, token);
+ }
+
+ const editor = vscode.window.activeTextEditor;
+ if (!editor || doc !== editor.document) {
+ return await next(doc, pos, token);
+ }
+
+ const selection = editor?.selection;
+ if (selection.isEmpty || !selection.contains(pos)) {
+ return await next(doc, pos, token);
+ }
+
+ // Attaching selected range to gopls type def request.
+ const param = goCtx.languageClient.code2ProtocolConverter.asTextDocumentPositionParams(doc, pos);
+ (param as any).range = goCtx.languageClient.code2ProtocolConverter.asRange(selection);
+
+ const result: any = await vscode.commands.executeCommand('gopls.lsp', {
+ method: 'textDocument/typeDefinition',
+ param: param
+ });
+ return goCtx.languageClient.protocol2CodeConverter.asDefinitionResult(result);
+ },
provideHover: async (doc, pos, token, next) => {
// gopls.lsp is a command that acts as a dispatcher, allowing
// the client to trigger any LSP RPC via "workspace/executeCommand"
@@ -492,7 +517,7 @@
}
const selection = editor?.selection;
- if (!selection || !selection.contains(pos)) {
+ if (selection.isEmpty || !selection.contains(pos)) {
return await next(doc, pos, token);
}
@@ -597,8 +622,9 @@
return res;
} catch (e) {
- // Suppress error messages for frequently triggered commands.
- if (command === 'gopls.package_symbols') {
+ // Suppress error messages for frequently triggered
+ // or programmerly triggered commads.
+ if (command === 'gopls.package_symbols' || command === 'gopls.lsp') {
return null;
}
// TODO: how to print ${e} reliably???
Change information
Files:
- M extension/src/language/goLanguageServer.ts
Change size: S
Delta: 1 file changed, 29 insertions(+), 3 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Madeline Kalil (Gerrit)
Dec 8, 2025, 10:16:14 AM (9 days ago) Dec 8
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang
Madeline Kalil voted and added 1 comment![]( "Open in Gerrit")
Votes added by Madeline Kalil
| Code-Review | +2 |
1 comment
File extension/src/language/goLanguageServer.ts
Line 626, Patchset 1 (Latest):
// or programmerly triggered commads.Madeline Kalil . unresolved
"programmatically" ? As in it's not triggered directly by the user, it's triggered internally by the extension, if that's what you mean?
Related details
Attention is currently required from:
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Dec 8, 2025, 9:30:10 PM (8 days ago) Dec 8
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang
Hongxiang Jiang uploaded new patchset![]( "Open in Gerrit")
Hongxiang Jiang uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Dec 8, 2025, 9:30:35 PM (8 days ago) Dec 8
to goph...@pubsubhelper.golang.org, Alan Donovan, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Hongxiang Jiang added 1 comment![]( "Open in Gerrit")
File extension/src/language/goLanguageServer.ts
"programmatically" ? As in it's not triggered directly by the user, it's triggered internally by the extension, if that's what you mean?
Hongxiang Jiang
Done
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Dec 8, 2025, 9:31:11 PM (8 days ago) Dec 8
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Hongxiang Jiang uploaded new patchset![]( "Open in Gerrit")
Hongxiang Jiang uploaded patch set #3 to this change.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Dec 8, 2025, 9:32:03 PM (8 days ago) Dec 8
to goph...@pubsubhelper.golang.org, Alan Donovan, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Hongxiang Jiang voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Dec 8, 2025, 9:32:19 PM (8 days ago) Dec 8
to goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Hongxiang Jiang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hongxiang Jiang
| Hold | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Hongxiang Jiang . resolved
Waiting for gopls CL to merge first.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Dec 8, 2025, 10:05:42 PM (8 days ago) Dec 8
to goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Hongxiang Jiang voted![]( "Open in Gerrit")
| Commit-Queue | +1 |
| Hold | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Dec 16, 2025, 3:13:01 PM (11 hours ago) Dec 16
to goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Hongxiang Jiang voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
| Hold | +0 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Dec 16, 2025, 3:29:49 PM (11 hours ago) Dec 16
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Alan Donovan, Madeline Kalil, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: extension/src/language/goLanguageServer.ts
Insertions: 1, Deletions: 1.
@@ -623,7 +623,7 @@
return res;
} catch (e) {
// Suppress error messages for frequently triggered
- // or programmerly triggered commads.
+ // or programmatically triggered commads.
if (command === 'gopls.package_symbols' || command === 'gopls.lsp') {
return null;
}
```
Change information
Commit message:
extension/src/language: extend range support to type def
gopls.lsp is triggered programmatically by the language client,
if error encountered, the vscode will pop up notifications
as if the ongoing LSP method is blocking. This CL also
suppress the error encountered gopls.lsp command.
Gopls CL 728600
For golang/go#76723
Change-Id: Ia064a7bb149bee632198c7affb0e975de2fe7e0c
Reviewed-by: Madeline Kalil <mka...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
Files:
- M extension/src/language/goLanguageServer.ts
Change size: S
Delta: 1 file changed, 29 insertions(+), 3 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Madeline Kalil
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages