[go] cmd/compile: skip race detector test failure for unsupported VMA
1 view
Skip to first unread message
abner chenc (Gerrit)
Mar 19, 2026, 2:45:23 AM (yesterday) Mar 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
abner chenc has uploaded the change for review![]( "Open in Gerrit")
Commit message
cmd/compile: skip race detector test failure for unsupported VMA
Fixes #78219
Updates #77597
Change-Id: I021df668bfc18081e71faaab2e4bad607873bf4d
Change diff
diff --git a/src/cmd/compile/internal/test/fixedbugs_test.go b/src/cmd/compile/internal/test/fixedbugs_test.go
index 4730a21..49d4fbb 100644
--- a/src/cmd/compile/internal/test/fixedbugs_test.go
+++ b/src/cmd/compile/internal/test/fixedbugs_test.go
@@ -5,6 +5,7 @@
package test
import (
+ "bytes"
"internal/platform"
"internal/testenv"
"os"
@@ -110,7 +111,13 @@
cmd := testenv.Command(t, testenv.GoToolPath(t), "run", "-race", "-gcflags=all=-N -l", src)
out, err := cmd.CombinedOutput()
if err != nil {
- t.Fatalf("program failed: %v\n%s", err, out)
+ // For details, please refer to CL 160919.
+ unsupportedVMA := []byte("unsupported VMA range")
+ if bytes.Contains(out, unsupportedVMA) {
+ t.Skipf("skipped due to unsupported VMA on %s/%s", runtime.GOOS, runtime.GOARCH)
+ } else {
+ t.Fatalf("program failed: %v\n%s", err, out)
+ }
}
}
Change information
Files:
- M src/cmd/compile/internal/test/fixedbugs_test.go
Change size: XS
Delta: 1 file changed, 8 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
abner chenc (Gerrit)
Mar 19, 2026, 3:10:24 AM (24 hours ago) Mar 19
to goph...@pubsubhelper.golang.org, Robert Griesemer, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Martin Möhrmann, Matthew Dempsky and Robert Griesemer
abner chenc voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Martin Möhrmann
- Matthew Dempsky
- Robert Griesemer
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Meidan Li (Gerrit)
Mar 19, 2026, 3:40:16 AM (23 hours ago) Mar 19
to abner chenc, goph...@pubsubhelper.golang.org, Go LUCI, sophie zhao, Robert Griesemer, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Martin Möhrmann, Matthew Dempsky, Robert Griesemer, abner chenc and sophie zhao
Meidan Li voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Martin Möhrmann
- Matthew Dempsky
- Robert Griesemer
- abner chenc
- sophie zhao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Mar 19, 2026, 6:52:23 PM (8 hours ago) Mar 19
to abner chenc, goph...@pubsubhelper.golang.org, Derek Parker, Dmitri Shuralyov, Meidan Li, Go LUCI, sophie zhao, Robert Griesemer, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Martin Möhrmann, Matthew Dempsky, Robert Griesemer, abner chenc and sophie zhao
Dmitri Shuralyov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Martin Möhrmann
- Matthew Dempsky
- Robert Griesemer
- abner chenc
- sophie zhao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 19, 2026, 7:21:00 PM (8 hours ago) Mar 19
to abner chenc, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Derek Parker, Dmitri Shuralyov, Meidan Li, Go LUCI, sophie zhao, Robert Griesemer, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Martin Möhrmann, Matthew Dempsky, Robert Griesemer, abner chenc and sophie zhao
Robert Griesemer voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Martin Möhrmann
- Matthew Dempsky
- Robert Griesemer
- abner chenc
- sophie zhao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 19, 2026, 7:21:09 PM (8 hours ago) Mar 19
to abner chenc, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Derek Parker, Dmitri Shuralyov, Meidan Li, Go LUCI, sophie zhao, Robert Griesemer, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Robert Griesemer submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/compile: skip race detector test failure for unsupported VMA
Fixes #78219
Updates #77597
Change-Id: I021df668bfc18081e71faaab2e4bad607873bf4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/756780
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Meidan Li <lime...@loongson.cn>
Reviewed-by: Robert Griesemer <g...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
- M src/cmd/compile/internal/test/fixedbugs_test.go
Change size: XS
Delta: 1 file changed, 8 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Meidan Li, +2 by Robert Griesemer, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages