Dmitri Shuralyov (Gerrit)

unread,

Dec 16, 2025, 4:52:18 PM (9 hours ago) Dec 16

to Michael Knyszek, goph...@pubsubhelper.golang.org, Alan Donovan, Dmitri Shuralyov, golang-co...@googlegroups.com

Attention needed from Michael Knyszek

Dmitri Shuralyov has uploaded the change for review

Dmitri Shuralyov would like Michael Knyszek to review this change.

Commit message

internal/relui: fix Go version in "Mail x/tools stdlib CL" during RCs

In CL 694976 I overlooked that the Go version needed to perform stdlib
generation in the "Mail x/tools stdlib CL" task and the Go version that
GenerateAutoSubmitChange selects when running its git-generate script
aligned during major releases, but the same doesn't work out for RCs.

So, get the script to use the exact version being released during RCs.
Use the golang.org/dl commands for this because regenerating the stdlib
packages uses the GOROOT/api files that are present there.

Change-Id: I290a23bef6f0da9e298a2e10b61981de8b5b621d

Change diff

diff --git a/internal/task/version.go b/internal/task/version.go
index 4e0009c..353cf98 100644
--- a/internal/task/version.go
+++ b/internal/task/version.go
@@ -217,6 +217,15 @@
 }
 
 func (t *VersionTasks) CreateUpdateStdlibIndexCL(ctx *workflow.TaskContext, reviewers []string, version string) (string, error) {
+	script := "go generate ./internal/stdlib"
+	if strings.Contains(version, "rc") {
+		// For release candidate versions, we can't leave go version
+		// selection to GenerateAutoSubmitChange. It uses the latest
+		// stable Go release, which is ok when this task runs during
+		// major releases, but not when it runs during RCs.
+		script = fmt.Sprintf(`go run golang.org/dl/%s@latest download
+go run golang.org/dl/%[1]s@latest generate ./internal/stdlib`, version)
+	}
 	return t.CloudBuild.GenerateAutoSubmitChange(ctx, gerrit.ChangeInput{
 		Project: "tools",
 		Subject: fmt.Sprintf(`internal/stdlib: update stdlib index for %s
@@ -224,8 +233,8 @@
 For golang/go#38706.
 
 [git-generate]
-go generate ./internal/stdlib
-`, strings.NewReplacer("go", "Go ", "rc", " Release Candidate ").Replace(version)),
+%s
+`, strings.NewReplacer("go", "Go ", "rc", " Release Candidate ").Replace(version), script),
 		Branch: "master",
 	}, reviewers)
 }

Change information

Files:

M internal/task/version.go

Change size: S

Delta: 1 file changed, 11 insertions(+), 2 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Michael Knyszek

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Dmitri Shuralyov (Gerrit)

unread,

Dec 16, 2025, 4:54:09 PM (9 hours ago) Dec 16

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Go LUCI, Michael Knyszek, Alan Donovan, golang-co...@googlegroups.com

Attention needed from Michael Knyszek

Dmitri Shuralyov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Michael Knyszek

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Dmitri Shuralyov (Gerrit)

unread,

Dec 16, 2025, 5:06:42 PM (9 hours ago) Dec 16

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov and Michael Knyszek

Dmitri Shuralyov uploaded new patchset

Dmitri Shuralyov uploaded patch set #2 to this change.

Following approvals got outdated and were removed:

Code-Review: +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov
Michael Knyszek

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Michael Knyszek (Gerrit)

unread,

Dec 16, 2025, 5:07:04 PM (9 hours ago) Dec 16

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, Alan Donovan, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov and Dmitri Shuralyov

Michael Knyszek voted and added 1 comment

Votes added by Michael Knyszek

Code-Review

+2

1 comment

File internal/task/version.go

Line 227, Patchset 1:go run golang.org/dl/%[1]s@latest generate ./internal/stdlib`, version)

Michael Knyszek . resolved

clever!

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov
Dmitri Shuralyov

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Michael Knyszek (Gerrit)

unread,

Dec 16, 2025, 5:07:48 PM (9 hours ago) Dec 16

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, Alan Donovan, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov and Dmitri Shuralyov

Michael Knyszek voted and added 1 comment

Votes added by Michael Knyszek

Code-Review

+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Michael Knyszek . resolved

still LGTM

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov
Dmitri Shuralyov

Submit Requirements:

Code-Review

No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dmitri Shuralyov (Gerrit)

unread,

Dec 16, 2025, 5:08:04 PM (9 hours ago) Dec 16

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov

Dmitri Shuralyov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov

Submit Requirements:

Code-Review
No-Unresolved-Comments

Review-Enforcement

TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dmitri Shuralyov (Gerrit)

unread,

Dec 16, 2025, 5:22:11 PM (9 hours ago) Dec 16

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, Alan Donovan, golang-co...@googlegroups.com

Dmitri Shuralyov voted and added 1 comment

Votes added by Dmitri Shuralyov

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dmitri Shuralyov . resolved

Thanks.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement

TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Gopher Robot (Gerrit)

unread,

Dec 16, 2025, 5:23:33 PM (9 hours ago) Dec 16

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Dmitri Shuralyov, Michael Knyszek, Alan Donovan, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

internal/relui: fix Go version in "Mail x/tools stdlib CL" during RCs

In CL 694976 I overlooked that the Go version needed to perform stdlib
generation in the "Mail x/tools stdlib CL" task and the Go version that
GenerateAutoSubmitChange selects when running its git-generate script
aligned during major releases, but the same doesn't work out for RCs.

So, get the script to use the exact version being released during RCs.
Use the golang.org/dl commands for this because regenerating the stdlib
packages uses the GOROOT/api files that are present there.

Change-Id: I290a23bef6f0da9e298a2e10b61981de8b5b621d

Reviewed-on: https://go-review.googlesource.com/c/build/+/730560

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Michael Knyszek <mkny...@google.com>

Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>

Files:

M internal/task/cloudbuild.go
M internal/task/version.go

Change size: S

Delta: 2 files changed, 13 insertions(+), 3 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Dmitri Shuralyov, +2 by Michael Knyszek
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[build] internal/relui: fix Go version in "Mail x/tools stdlib CL" during RCs

Dmitri Shuralyov (Gerrit)

Dmitri Shuralyov has uploaded the change for review

Commit message

Change diff

Change information

Related details

Dmitri Shuralyov (Gerrit)

Dmitri Shuralyov voted Code-Review+1

Related details

Dmitri Shuralyov (Gerrit)

Dmitri Shuralyov uploaded new patchset

Related details

Michael Knyszek (Gerrit)

Michael Knyszek voted and added 1 comment

Votes added by Michael Knyszek

1 comment

Related details

Michael Knyszek (Gerrit)

Michael Knyszek voted and added 1 comment

Votes added by Michael Knyszek

1 comment

Related details

Dmitri Shuralyov (Gerrit)

Dmitri Shuralyov voted Code-Review+1

Related details

Dmitri Shuralyov (Gerrit)

Dmitri Shuralyov voted and added 1 comment

Votes added by Dmitri Shuralyov

1 comment

Related details

Gopher Robot (Gerrit)

Gopher Robot submitted the change

Change information