[go] internal/runtime/sys,math/bits: eliminate bounds checks on len8tab

6 views
Skip to first unread message

Joel Sing (Gerrit)

unread,
Nov 5, 2025, 10:19:06 AM (6 days ago) Nov 5
to goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Joel Sing

Joel Sing removed a vote from this change

Removed LUCI-TryBot-Result-1 by Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteVote
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
Gerrit-Change-Number: 718040
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Attention: Joel Sing <jo...@sing.id.au>
unsatisfied_requirement
satisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Nov 6, 2025, 9:07:32 AM (5 days ago) Nov 6
to goph...@pubsubhelper.golang.org, Keith Randall, Meng Zhuo, Go LUCI, golang-co...@googlegroups.com
Attention needed from Keith Randall and Meng Zhuo

Joel Sing voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
  • Meng Zhuo
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
    Gerrit-Change-Number: 718040
    Gerrit-PatchSet: 1
    Gerrit-Owner: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Comment-Date: Thu, 06 Nov 2025 14:07:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Joel Sing (Gerrit)

    unread,
    Nov 6, 2025, 9:08:07 AM (5 days ago) Nov 6
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Joel Sing, Keith Randall and Meng Zhuo

    Joel Sing uploaded new patchset

    Joel Sing uploaded patch set #2 to this change.
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joel Sing
    • Keith Randall
    • Meng Zhuo
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
    Gerrit-Change-Number: 718040
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: Joel Sing <jo...@sing.id.au>
    Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Joel Sing (Gerrit)

    unread,
    Nov 6, 2025, 9:10:02 AM (5 days ago) Nov 6
    to goph...@pubsubhelper.golang.org, Keith Randall, Meng Zhuo, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Keith Randall and Meng Zhuo

    Joel Sing voted

    Auto-Submit+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keith Randall
    • Meng Zhuo
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
      Gerrit-Change-Number: 718040
      Gerrit-PatchSet: 2
      Gerrit-Owner: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Attention: Keith Randall <k...@golang.org>
      Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Comment-Date: Thu, 06 Nov 2025 14:09:55 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Keith Randall (Gerrit)

      unread,
      Nov 6, 2025, 12:45:47 PM (5 days ago) Nov 6
      to Joel Sing, goph...@pubsubhelper.golang.org, Keith Randall, Meng Zhuo, Go LUCI, golang-co...@googlegroups.com
      Attention needed from Joel Sing and Meng Zhuo

      Keith Randall voted

      Auto-Submit+1
      Code-Review+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      • Meng Zhuo
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
      Gerrit-Change-Number: 718040
      Gerrit-PatchSet: 2
      Gerrit-Owner: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Attention: Joel Sing <jo...@sing.id.au>
      Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Comment-Date: Thu, 06 Nov 2025 17:45:42 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Keith Randall (Gerrit)

      unread,
      Nov 6, 2025, 12:45:52 PM (5 days ago) Nov 6
      to Joel Sing, goph...@pubsubhelper.golang.org, Keith Randall, Meng Zhuo, Go LUCI, golang-co...@googlegroups.com
      Attention needed from Joel Sing and Meng Zhuo

      Keith Randall voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      • Meng Zhuo
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
      Gerrit-Change-Number: 718040
      Gerrit-PatchSet: 2
      Gerrit-Owner: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Keith Randall <k...@google.com>
      Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Attention: Joel Sing <jo...@sing.id.au>
      Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Comment-Date: Thu, 06 Nov 2025 17:45:48 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Meng Zhuo (Gerrit)

      unread,
      Nov 6, 2025, 9:42:49 PM (4 days ago) Nov 6
      to Joel Sing, goph...@pubsubhelper.golang.org, Meng Zhuo, Keith Randall, Keith Randall, Go LUCI, golang-co...@googlegroups.com
      Attention needed from Joel Sing

      Meng Zhuo voted Code-Review+2

      Code-Review+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
      Gerrit-Change-Number: 718040
      Gerrit-PatchSet: 2
      Gerrit-Owner: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Keith Randall <k...@google.com>
      Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Attention: Joel Sing <jo...@sing.id.au>
      Gerrit-Comment-Date: Fri, 07 Nov 2025 02:42:39 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Junyang Shao (Gerrit)

      unread,
      Nov 10, 2025, 12:47:17 PM (20 hours ago) Nov 10
      to Joel Sing, goph...@pubsubhelper.golang.org, Meng Zhuo, Keith Randall, Keith Randall, Go LUCI, golang-co...@googlegroups.com
      Attention needed from Joel Sing

      Junyang Shao voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
        Gerrit-Change-Number: 718040
        Gerrit-PatchSet: 2
        Gerrit-Owner: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>
        Gerrit-Reviewer: Keith Randall <k...@golang.org>
        Gerrit-Reviewer: Keith Randall <k...@google.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Comment-Date: Mon, 10 Nov 2025 17:47:13 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Gopher Robot (Gerrit)

        unread,
        Nov 10, 2025, 12:48:25 PM (20 hours ago) Nov 10
        to Joel Sing, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, Meng Zhuo, Keith Randall, Keith Randall, Go LUCI, golang-co...@googlegroups.com

        Gopher Robot submitted the change

        Change information

        Commit message:
        internal/runtime/sys,math/bits: eliminate bounds checks on len8tab

        The compiler cannot currently determine that the accesses to len8tab
        are within bounds. Cast to uint8 to avoid unnecessary bounds checks.

        Fixes #76166
        Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
        Reviewed-by: Meng Zhuo <mengzh...@gmail.com>
        Reviewed-by: Keith Randall <k...@google.com>
        Reviewed-by: Keith Randall <k...@golang.org>
        Auto-Submit: Keith Randall <k...@golang.org>
        Reviewed-by: Junyang Shao <shaoj...@google.com>
        Auto-Submit: Joel Sing <jo...@sing.id.au>
        Files:
        • M src/internal/runtime/sys/intrinsics.go
        • M src/math/bits/bits.go
        Change size: XS
        Delta: 2 files changed, 4 insertions(+), 4 deletions(-)
        Branch: refs/heads/master
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Junyang Shao, +2 by Meng Zhuo, +2 by Keith Randall, +1 by Keith Randall
        • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I1fd930bba2b20d3998252c476308642e08ce00b4
        Gerrit-Change-Number: 718040
        Gerrit-PatchSet: 3
        Gerrit-Owner: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Gopher Robot <go...@golang.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages