[go] mime: Add mime type for avif image file format
Amit Mittal (Gerrit)
Amit Mittal has uploaded this change for review.
mime: Add mime type for avif image file format
Change-Id: I28b6df5e2523fc2ece6fd8251fcabc83c7c38d89
---
M src/mime/type.go
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/src/mime/type.go b/src/mime/type.go
index 6d2b89e..a13aa04 100644
--- a/src/mime/type.go
+++ b/src/mime/type.go
@@ -72,6 +72,7 @@
".svg": "image/svg+xml",
".wasm": "application/wasm",
".webp": "image/webp",
+ ".avif": "image/avif",
".xml": "text/xml; charset=utf-8",
}
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
1 comment:
Patchset:
This isn't on the list of IANA MIME types (https://www.iana.org/assignments/media-types/media-types.xhtml#image). Why should we add it to the small list built in to this package? In Go for things like this we prefer to follow other standards bodies rather than leading them.
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.
Amit Mittal (Gerrit)
2 comments:
Patchset:
This isn't on the list of IANA MIME types (https://www.iana.org/assignments/media-types/media-types. […]
AVIF is latest image format supported built on av1 video foemat, which recently landed in chrome. Support for other browsers is coming soon.
https://aomediacodec.github.io/av1-avif/
Without this http.FileServer serve avif files as octet-stream.
In the link provided I don't see webp also but it is supported in Go code. So I think exception can be made if there is good enough reason. avif is supposed to be successor webp.AVIF is latest image format supported built on av1 video format, which recently landed in chrome. Support for other browsers is coming soon.
https://aomediacodec.github.io/av1-avif/
Without this http.FileServer serve avif files as octet-stream.
In the link provided I don't see webp also but it is supported in Go code. So I think exception can be made if there is good enough reason. avif is supposed to be successor to webp.
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.
Amit Mittal (Gerrit)
Attention is currently required from: Ian Lance Taylor.
2 comments:
Patchset:
AVIF is latest image format supported built on av1 video foemat, which recently landed in chrome. […]
https://www.iana.org/assignments/media-types/media-types.xhtml#image
Now avif format is added in IANA list. Can this change be planned now?Thanks,
IANA list is updated and avif is included in list. Can we plan this change now?
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Amit Mittal.
Patch set 2:Run-TryBot +1Trust +1
Tobias Klauser (Gerrit)
Attention is currently required from: Amit Mittal, Ian Lance Taylor.
1 comment:
Commit Message:
Patch Set #4, Line 7:
mime: Add mime type for avif image file format.Per https://golang.org/wiki/CommitMessage, please change this to:
mime: add mime type for avif image file format
(lower case after colon and no trailing full stop)
Please also add a newline between the commit subject and the body.
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.
Amit Mittal (Gerrit)
Attention is currently required from: Amit Mittal, Ian Lance Taylor.
Amit Mittal uploaded patch set #5 to this change.
mime: add mime type for avif image file format
Fixes #44602
Change-Id: I28b6df5e2523fc2ece6fd8251fcabc83c7c38d89
---
M src/mime/type.go
1 file changed, 1 insertion(+), 0 deletions(-)
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.
Amit Mittal (Gerrit)
Attention is currently required from: Tobias Klauser, Ian Lance Taylor.
1 comment:
Commit Message:
Patch Set #4, Line 7:
mime: Add mime type for avif image file format.
Per https://golang.org/wiki/CommitMessage, please change this to: […]
Commit message updated
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Tobias Klauser, Amit Mittal.
Patch set 5:Run-TryBot +1Trust +1
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Tobias Klauser, Amit Mittal.
Patch set 5:Code-Review +2
Michael Knyszek (Gerrit)
Attention is currently required from: Tobias Klauser, Amit Mittal.
Patch set 5:Trust +1
Ian Lance Taylor (Gerrit)
Ian Lance Taylor submitted this change.
mime: add mime type for avif image file format
Fixes #44602
Change-Id: I28b6df5e2523fc2ece6fd8251fcabc83c7c38d89
Reviewed-on: https://go-review.googlesource.com/c/go/+/256478
Trust: Ian Lance Taylor <ia...@golang.org>
Trust: Michael Knyszek <mkny...@google.com>
Run-TryBot: Ian Lance Taylor <ia...@golang.org>
TryBot-Result: Go Bot <go...@golang.org>
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
---
M src/mime/type.go
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/src/mime/type.go b/src/mime/type.go
index 6d2b89e..a13aa04 100644
--- a/src/mime/type.go
+++ b/src/mime/type.go
@@ -72,6 +72,7 @@
".svg": "image/svg+xml",
".wasm": "application/wasm",
".webp": "image/webp",
+ ".avif": "image/avif",
".xml": "text/xml; charset=utf-8",
}
To view, visit change 256478. To unsubscribe, or for help writing mail filters, visit settings.