[go] net/http: avoid connCount underflow race
5 views
Skip to first unread message
Damien Neil (Gerrit)
Sep 15, 2025, 6:55:58 PMSep 15
to goph...@pubsubhelper.golang.org, Nicholas Husin, Brad Fitzpatrick, Go LUCI, golang-co...@googlegroups.com
Attention needed from Brad Fitzpatrick and Nicholas Husin
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Brad Fitzpatrick
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Sep 16, 2025, 2:34:01 PMSep 16
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, Brad Fitzpatrick, golang-co...@googlegroups.com
Attention needed from Brad Fitzpatrick and Damien Neil
Nicholas Husin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Brad Fitzpatrick
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Sep 16, 2025, 4:32:17 PMSep 16
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, Brad Fitzpatrick, golang-co...@googlegroups.com
Attention needed from Brad Fitzpatrick and Damien Neil
Nicholas Husin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Code-Review | +2 |
1 comment
Patchset-level comments
Nicholas Husin . resolved
Retrying the test...
Nicholas Husin
The test is failing at HEAD with a clean tree, nothing to do here I guess.
Related details
Attention is currently required from:
- Brad Fitzpatrick
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Sep 16, 2025, 4:32:26 PMSep 16
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Go LUCI, Brad Fitzpatrick, golang-co...@googlegroups.com
Attention needed from Brad Fitzpatrick and Damien Neil
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brad Fitzpatrick
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jes Cok (Gerrit)
Sep 17, 2025, 1:21:23 PMSep 17
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, Go LUCI, Brad Fitzpatrick, golang-co...@googlegroups.com
Attention needed from Brad Fitzpatrick and Damien Neil
Jes Cok voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jes Cok
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Jes Cok . resolved
It would be nice to rebase on the tip and rerun the tests.
Related details
Attention is currently required from:
- Brad Fitzpatrick
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Sep 18, 2025, 4:46:03 PM (13 days ago) Sep 18
to goph...@pubsubhelper.golang.org, Jes Cok, Nicholas Husin, Nicholas Husin, Go LUCI, Brad Fitzpatrick, golang-co...@googlegroups.com
Attention needed from Brad Fitzpatrick and Jes Cok
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Brad Fitzpatrick
- Jes Cok
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Sep 18, 2025, 5:35:33 PM (13 days ago) Sep 18
to goph...@pubsubhelper.golang.org, Go LUCI, Jes Cok, Nicholas Husin, Nicholas Husin, Brad Fitzpatrick, golang-co...@googlegroups.com
Attention needed from Brad Fitzpatrick and Jes Cok
Damien Neil voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Brad Fitzpatrick
- Jes Cok
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Sep 18, 2025, 5:37:00 PM (13 days ago) Sep 18
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Jes Cok, Nicholas Husin, Nicholas Husin, Brad Fitzpatrick, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
net/http: avoid connCount underflow race
Remove a race condition in counting the number of connections per host,
which can cause a connCount underflow and a panic.
The race occurs when:
- A RoundTrip call attempts to use a HTTP/2 roundtripper (pconn.alt != nil)
and receives an isNoCachedConn error. The call removes the pconn from
the idle conn pool and decrements the connCount for its host.
- A second RoundTrip call on the same pconn succeeds,
and delivers the pconn to a third RoundTrip waiting for a conn.
- The third RoundTrip receives the pconn at the same moment its request
context is canceled. It places the pconn back into the idle conn pool.
At this time, the connCount is incorrect, because the conn returned to
the idle pool is not matched by an increment in the connCount.
Fix this by not adding HTTP/2 pconns back to the idle pool in
wantConn.cancel.
Fixes #61474
Change-Id: I104d6cf85a54d0382eebf3fcf5dda99c69a7c3f6
Reviewed-on: https://go-review.googlesource.com/c/go/+/703936
Auto-Submit: Damien Neil <dn...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M src/net/http/transport.go
- M src/net/http/transport_test.go
Change size: S
Delta: 2 files changed, 36 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Sep 18, 2025, 5:40:47 PM (13 days ago) Sep 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Damien Neil has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.25] net/http: avoid connCount underflow race
Remove a race condition in counting the number of connections per host,
which can cause a connCount underflow and a panic.
The race occurs when:
- A RoundTrip call attempts to use a HTTP/2 roundtripper (pconn.alt != nil)
and receives an isNoCachedConn error. The call removes the pconn from
the idle conn pool and decrements the connCount for its host.
- A second RoundTrip call on the same pconn succeeds,
and delivers the pconn to a third RoundTrip waiting for a conn.
- The third RoundTrip receives the pconn at the same moment its request
context is canceled. It places the pconn back into the idle conn pool.
At this time, the connCount is incorrect, because the conn returned to
the idle pool is not matched by an increment in the connCount.
Fix this by not adding HTTP/2 pconns back to the idle pool in
wantConn.cancel.
For #61474
Fixes #75539
Change-Id: I104d6cf85a54d0382eebf3fcf5dda99c69a7c3f6
Reviewed-on: https://go-review.googlesource.com/c/go/+/703936
Auto-Submit: Damien Neil <dn...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 3203a5da290753e5c7aceb12f41f06b272356bd0)
Change diff
diff --git a/src/net/http/transport.go b/src/net/http/transport.go
index 07b3a9e..2778db3 100644
--- a/src/net/http/transport.go
+++ b/src/net/http/transport.go
@@ -1372,7 +1372,10 @@
w.done = true
w.mu.Unlock()
- if pc != nil {
+ // HTTP/2 connections (pc.alt != nil) aren't removed from the idle pool on use,
+ // and should not be added back here. If the pconn isn't in the idle pool,
+ // it's because we removed it due to an error.
+ if pc != nil && pc.alt == nil {
t.putOrCloseIdleConn(pc)
}
}
diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go
index 9762f05..28ad3eb 100644
--- a/src/net/http/transport_test.go
+++ b/src/net/http/transport_test.go
@@ -7559,3 +7559,35 @@
})
}
}
+
+func TestIssue61474(t *testing.T) {
+ run(t, testIssue61474, []testMode{http2Mode})
+}
+func testIssue61474(t *testing.T, mode testMode) {
+ if testing.Short() {
+ return
+ }
+
+ // This test reliably exercises the condition causing #61474,
+ // but requires many iterations to do so.
+ // Keep the test around for now, but don't run it by default.
+ t.Skip("test is too large")
+
+ cst := newClientServerTest(t, mode, HandlerFunc(func(rw ResponseWriter, req *Request) {
+ }), func(tr *Transport) {
+ tr.MaxConnsPerHost = 1
+ })
+ var wg sync.WaitGroup
+ defer wg.Wait()
+ for range 100000 {
+ wg.Go(func() {
+ ctx, cancel := context.WithTimeout(t.Context(), 1*time.Millisecond)
+ defer cancel()
+ req, _ := NewRequestWithContext(ctx, "GET", cst.ts.URL, nil)
+ resp, err := cst.c.Do(req)
+ if err == nil {
+ resp.Body.Close()
+ }
+ })
+ }
+}
Change information
Files:
- M src/net/http/transport.go
- M src/net/http/transport_test.go
Change size: S
Delta: 2 files changed, 36 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Sep 18, 2025, 5:41:30 PM (13 days ago) Sep 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Damien Neil has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.24] net/http: avoid connCount underflow race
Remove a race condition in counting the number of connections per host,
which can cause a connCount underflow and a panic.
The race occurs when:
- A RoundTrip call attempts to use a HTTP/2 roundtripper (pconn.alt != nil)
and receives an isNoCachedConn error. The call removes the pconn from
the idle conn pool and decrements the connCount for its host.
- A second RoundTrip call on the same pconn succeeds,
and delivers the pconn to a third RoundTrip waiting for a conn.
- The third RoundTrip receives the pconn at the same moment its request
context is canceled. It places the pconn back into the idle conn pool.
At this time, the connCount is incorrect, because the conn returned to
the idle pool is not matched by an increment in the connCount.
Fix this by not adding HTTP/2 pconns back to the idle pool in
wantConn.cancel.
For #61474
Fixes #75538
Change-Id: I104d6cf85a54d0382eebf3fcf5dda99c69a7c3f6
Reviewed-on: https://go-review.googlesource.com/c/go/+/703936
Auto-Submit: Damien Neil <dn...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 3203a5da290753e5c7aceb12f41f06b272356bd0)
Change diff
diff --git a/src/net/http/transport.go b/src/net/http/transport.go
index 41e6741..200fe7b 100644
--- a/src/net/http/transport.go
+++ b/src/net/http/transport.go
@@ -1372,7 +1372,10 @@
w.done = true
w.mu.Unlock()
- if pc != nil {
+ // HTTP/2 connections (pc.alt != nil) aren't removed from the idle pool on use,
+ // and should not be added back here. If the pconn isn't in the idle pool,
+ // it's because we removed it due to an error.
+ if pc != nil && pc.alt == nil {
t.putOrCloseIdleConn(pc)
}
}
diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go
index a454db5..4ac0e51 100644Carlos Amedee (Gerrit)
Oct 1, 2025, 11:15:48 AM (15 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil, Nicholas Husin and Nicholas Husin
Carlos Amedee voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Damien Neil
- Nicholas Husin
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Oct 1, 2025, 11:15:52 AM (15 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil, Nicholas Husin and Nicholas Husin
Carlos Amedee voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Damien Neil
- Nicholas Husin
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Oct 1, 2025, 11:16:18 AM (15 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, Carlos Amedee, Nicholas Husin, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil and Nicholas Husin
Nicholas Husin voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Damien Neil
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Oct 1, 2025, 11:16:23 AM (15 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, Carlos Amedee, Nicholas Husin, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil and Nicholas Husin
Nicholas Husin voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Damien Neil
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Oct 1, 2025, 11:17:16 AM (15 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Go LUCI, Carlos Amedee, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Oct 1, 2025, 11:17:20 AM (15 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Go LUCI, Carlos Amedee, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Oct 1, 2025, 11:29:38 AM (15 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, Nicholas Husin, Nicholas Husin, Carlos Amedee, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Carlos Amedee and Damien Neil
Cherry Mui added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Cherry Mui . unresolved
The trybot result shows that 1.24 backport needs more work, as it doesn't have WaitGroup.Go.
Related details
Attention is currently required from:
- Carlos Amedee
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Oct 1, 2025, 11:30:34 AM (15 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, Go LUCI, Carlos Amedee, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil
Cherry Mui voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Oct 1, 2025, 2:26:25 PM (12 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Carlos Amedee and Damien Neil
Carlos Amedee uploaded new patchset![]( "Open in Gerrit")
Carlos Amedee uploaded patch set #2 to the change originally created by Damien Neil.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention is currently required from:
- Carlos Amedee
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Oct 1, 2025, 2:27:08 PM (12 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, Nicholas Husin, Nicholas Husin, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil
Carlos Amedee voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Oct 1, 2025, 3:06:01 PM (11 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, Nicholas Husin, Nicholas Husin, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Damien Neil
Carlos Amedee added 2 comments![]( "Open in Gerrit")
Patchset-level comments
The trybot result shows that 1.24 backport needs more work, as it doesn't have WaitGroup.Go.
Carlos Amedee
Initially missed that. Done.
Related details
Attention is currently required from:
- Cherry Mui
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Oct 1, 2025, 3:06:12 PM (11 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, Nicholas Husin, Nicholas Husin, Cherry Mui, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Damien Neil
Carlos Amedee voted TryBot-Bypass+1![]( "Open in Gerrit")
| TryBot-Bypass | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Oct 1, 2025, 3:06:54 PM (11 hours ago) Oct 1
to Damien Neil, Carlos Amedee, goph...@pubsubhelper.golang.org, Go LUCI, Nicholas Husin, Nicholas Husin, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Carlos Amedee and Damien Neil
Cherry Mui voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Carlos Amedee
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Oct 1, 2025, 3:10:04 PM (11 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Go LUCI, Nicholas Husin, Nicholas Husin, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Carlos Amedee submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reviewed-on: https://go-review.googlesource.com/c/go/+/705377
TryBot-Bypass: Carlos Amedee <car...@golang.org>
Reviewed-by: Cherry Mui <cher...@google.com>
Files:
- M src/net/http/transport.go
- M src/net/http/transport_test.go
Change size: S
Delta: 2 files changed, 38 insertions(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.24
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Nicholas Husin, +2 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI, TryBot-Bypass+1 by Carlos Amedee
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Oct 1, 2025, 3:10:09 PM (11 hours ago) Oct 1
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, Nicholas Husin, Nicholas Husin, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Carlos Amedee submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.25] net/http: avoid connCount underflow race
Remove a race condition in counting the number of connections per host,
which can cause a connCount underflow and a panic.
The race occurs when:
- A RoundTrip call attempts to use a HTTP/2 roundtripper (pconn.alt != nil)
and receives an isNoCachedConn error. The call removes the pconn from
the idle conn pool and decrements the connCount for its host.
- A second RoundTrip call on the same pconn succeeds,
and delivers the pconn to a third RoundTrip waiting for a conn.
- The third RoundTrip receives the pconn at the same moment its request
context is canceled. It places the pconn back into the idle conn pool.
At this time, the connCount is incorrect, because the conn returned to
the idle pool is not matched by an increment in the connCount.
Fix this by not adding HTTP/2 pconns back to the idle pool in
wantConn.cancel.
For #61474
Fixes #75539
Change-Id: I104d6cf85a54d0382eebf3fcf5dda99c69a7c3f6
Reviewed-on: https://go-review.googlesource.com/c/go/+/703936
Auto-Submit: Damien Neil <dn...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 3203a5da290753e5c7aceb12f41f06b272356bd0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/705376
Reviewed-by: Cherry Mui <cher...@google.com>
Files:
- M src/net/http/transport.go
- M src/net/http/transport_test.go
Change size: S
Delta: 2 files changed, 36 insertions(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Cherry Mui, +2 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages