[oscar] internal/gerrit: go fix -omitzero ./...

1 view
Skip to first unread message

Hyang-Ah Hana Kim (Gerrit)

unread,
Feb 26, 2026, 10:07:56 PM (20 hours ago) Feb 26
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Hyang-Ah Hana Kim has uploaded the change for review

Commit message

internal/gerrit: go fix -omitzero ./...

The omitempty annotations removed with this `go fix` were noop.
The intention must be `omitzero`.
Change-Id: Id5abd8a8f6e72f4094f91cf45b308d1826d8d450

Change diff

diff --git a/internal/gerrit/change.go b/internal/gerrit/change.go
index acbc235..6cc3b6c 100644
--- a/internal/gerrit/change.go
+++ b/internal/gerrit/change.go
@@ -283,8 +283,8 @@
 	// lengthy AccountInfo data each time.
 	type approvalInfo struct {
 		Value                int             `json:"value,omitempty"`
-		PermittedVotingRange VotingRangeInfo `json:"permitted_voting_range,omitempty"`
-		Date                 TimeStamp       `json:"date,omitempty"`
+		PermittedVotingRange VotingRangeInfo `json:"permitted_voting_range"`
+		Date                 TimeStamp       `json:"date"`
 		Tag                  string          `json:"tag,omitempty"`
 		PostSubmit           bool            `json:"post_submit,omitempty"`
 	}
diff --git a/internal/gerrit/types.go b/internal/gerrit/types.go
index e7daa5a..8f3952b 100644
--- a/internal/gerrit/types.go
+++ b/internal/gerrit/types.go
@@ -55,7 +55,7 @@
 	Updated TimeStamp `json:"updated"`
 
 	// The timestamp of when the change was submitted.
-	Submitted TimeStamp `json:"submitted,omitempty"`
+	Submitted TimeStamp `json:"submitted"`
 
 	// The user who submitted the change.
 	Submitter *AccountInfo `json:"submitter,omitempty"`
@@ -354,9 +354,9 @@
 	// label. If present, the user is permitted to vote on the
 	// label regarding the range values. If absent, the user is
 	// not permitted to vote on that label.
-	PermittedVotingRange VotingRangeInfo `json:"permitted_voting_range,omitempty"`
+	PermittedVotingRange VotingRangeInfo `json:"permitted_voting_range"`
 	// The time and date describing when the approval was made.
-	Date TimeStamp `json:"date,omitempty"`
+	Date TimeStamp `json:"date"`
 	// Value of the tag field from ReviewInput set while posting
 	// the review. Votes/comments that contain tag with
 	// 'autogenerated:' prefix can be filtered out in the web UI.

Change information

Files:
  • M internal/gerrit/change.go
  • M internal/gerrit/types.go
Change size: S
Delta: 2 files changed, 5 insertions(+), 5 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: oscar
Gerrit-Branch: master
Gerrit-Change-Id: Id5abd8a8f6e72f4094f91cf45b308d1826d8d450
Gerrit-Change-Number: 749652
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Ian Lance Taylor (Gerrit)

unread,
4:23 PM (2 hours ago) 4:23 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim

Ian Lance Taylor voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Hyang-Ah Hana Kim
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: oscar
Gerrit-Branch: master
Gerrit-Change-Id: Id5abd8a8f6e72f4094f91cf45b308d1826d8d450
Gerrit-Change-Number: 749652
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Comment-Date: Fri, 27 Feb 2026 21:23:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hyang-Ah Hana Kim (Gerrit)

unread,
4:34 PM (2 hours ago) 4:34 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com

Hyang-Ah Hana Kim added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Hyang-Ah Hana Kim . resolved

Thanks!!!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: oscar
Gerrit-Branch: master
Gerrit-Change-Id: Id5abd8a8f6e72f4094f91cf45b308d1826d8d450
Gerrit-Change-Number: 749652
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Comment-Date: Fri, 27 Feb 2026 21:34:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
4:40 PM (2 hours ago) 4:40 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim

Nicholas Husin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hyang-Ah Hana Kim
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: oscar
    Gerrit-Branch: master
    Gerrit-Change-Id: Id5abd8a8f6e72f4094f91cf45b308d1826d8d450
    Gerrit-Change-Number: 749652
    Gerrit-PatchSet: 1
    Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Nicholas Husin <hu...@google.com>
    Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 21:40:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hyang-Ah Hana Kim (Gerrit)

    unread,
    4:44 PM (2 hours ago) 4:44 PM
    to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com

    Hyang-Ah Hana Kim submitted the change

    Change information

    Commit message:
    internal/gerrit: go fix -omitzero ./...

    The omitempty annotations removed with this `go fix` were noop.
    The intention must be `omitzero`.
    Change-Id: Id5abd8a8f6e72f4094f91cf45b308d1826d8d450
    Reviewed-by: Nicholas Husin <hu...@google.com>
    Reviewed-by: Ian Lance Taylor <ia...@golang.org>
    Files:
    • M internal/gerrit/change.go
    • M internal/gerrit/types.go
    Change size: S
    Delta: 2 files changed, 5 insertions(+), 5 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Ian Lance Taylor, +1 by Nicholas Husin
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: oscar
    Gerrit-Branch: master
    Gerrit-Change-Id: Id5abd8a8f6e72f4094f91cf45b308d1826d8d450
    Gerrit-Change-Number: 749652
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages