[pkgsite] static/frontend/vuln: display vuln summaries
Tatiana Bradley (Gerrit)
Tatiana Bradley has uploaded this change for review.
static/frontend/vuln: display vuln summaries
Display summary instead of Go ID as the title of a vulnerability on the
list pages and entry pages.
Change-Id: I5d271acb74ce97721c5fa4ec8c71fb0b715e386b
---
M static/frontend/vuln/entry/entry.tmpl
M static/frontend/vuln/list/list.tmpl
M static/frontend/vuln/main/main.tmpl
M static/frontend/vuln/vuln.tmpl
M tests/screentest/testdata/ci/vuln-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry.a.png
M tests/screentest/testdata/ci/vuln-list-540x1080.a.png
M tests/screentest/testdata/ci/vuln-list.a.png
M tests/screentest/testdata/ci/vuln-search-540x1080.a.png
M tests/screentest/testdata/ci/vuln-search.a.png
M tests/screentest/testdata/ci/vuln.a.png
12 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/static/frontend/vuln/entry/entry.tmpl b/static/frontend/vuln/entry/entry.tmpl
index 44b935d..0f0e91f 100644
--- a/static/frontend/vuln/entry/entry.tmpl
+++ b/static/frontend/vuln/entry/entry.tmpl
@@ -23,8 +23,11 @@
</li>
</ol>
</nav>
- <h1 class="Vuln-title">Vulnerability Report: {{.Entry.ID}}</h1>
+ <h1 class="Vuln-title">{{.Entry.Summary}}</h1>
{{template "vuln-details" .Entry}}
+ {{with $details := .Entry.Details}}
+ <p>{{$details}}</p>
+ {{end}}
{{$numAdvs := subtract (len .AdvisoryLinks) 1}}
{{with .AdvisoryLinks}}
<p>
diff --git a/static/frontend/vuln/list/list.tmpl b/static/frontend/vuln/list/list.tmpl
index 4f90665..89e22b3 100644
--- a/static/frontend/vuln/list/list.tmpl
+++ b/static/frontend/vuln/list/list.tmpl
@@ -41,7 +41,7 @@
{{else}}
{{range .Entries}}
<h2 class="VulnList-title">
- <a href="/vuln/{{.ID}}">{{.ID}}</a>
+ <a href="/vuln/{{.ID}}">{{.Summary}}</a>
</h2>
<div class="VulnList-details">
{{template "vuln-details" .}}
diff --git a/static/frontend/vuln/main/main.tmpl b/static/frontend/vuln/main/main.tmpl
index a4a9f70..2a99857 100644
--- a/static/frontend/vuln/main/main.tmpl
+++ b/static/frontend/vuln/main/main.tmpl
@@ -33,7 +33,7 @@
<div class="VulnMain-recent">
{{range .Entries}}
<h3 class="VulnMain-title">
- <a href="/vuln/{{.ID}}">{{.ID}}</a>
+ <a href="/vuln/{{.ID}}">{{.Summary}}</a>
</h3>
<div class="VulnMain-details">
{{template "vuln-details" .}}
diff --git a/static/frontend/vuln/vuln.tmpl b/static/frontend/vuln/vuln.tmpl
index 7fd3a3a..1d55004 100644
--- a/static/frontend/vuln/vuln.tmpl
+++ b/static/frontend/vuln/vuln.tmpl
@@ -21,6 +21,7 @@
{{/* . is Entry */}}
<div class="Vuln-details">
<ul class="Vuln-detailsMetadata">
+ <li class="go-textSubtle">{{.ID}}</li>
{{with $aliases := .Aliases}}
<li class="go-textSubtle Vuln-alias">
{{range $i, $v := $aliases}}
@@ -42,7 +43,6 @@
<li class="go-textSubtle">Modified: {{.Modified.Format "Jan 02, 2006"}}</li>
{{end}}
</ul>
- <p>{{.Details}}</p>
</div>
{{end}}
diff --git a/tests/screentest/testdata/ci/vuln-540x1080.a.png b/tests/screentest/testdata/ci/vuln-540x1080.a.png
index 56a4ac7..faef708 100644
--- a/tests/screentest/testdata/ci/vuln-540x1080.a.png
+++ b/tests/screentest/testdata/ci/vuln-540x1080.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-entry-540x1080.a.png b/tests/screentest/testdata/ci/vuln-entry-540x1080.a.png
index d161ba8..db3910c 100644
--- a/tests/screentest/testdata/ci/vuln-entry-540x1080.a.png
+++ b/tests/screentest/testdata/ci/vuln-entry-540x1080.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-entry.a.png b/tests/screentest/testdata/ci/vuln-entry.a.png
index f967095..09263e7 100644
--- a/tests/screentest/testdata/ci/vuln-entry.a.png
+++ b/tests/screentest/testdata/ci/vuln-entry.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-list-540x1080.a.png b/tests/screentest/testdata/ci/vuln-list-540x1080.a.png
index e62ae05..84724ad 100644
--- a/tests/screentest/testdata/ci/vuln-list-540x1080.a.png
+++ b/tests/screentest/testdata/ci/vuln-list-540x1080.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-list.a.png b/tests/screentest/testdata/ci/vuln-list.a.png
index bc0cb3e..ddfe85b 100644
--- a/tests/screentest/testdata/ci/vuln-list.a.png
+++ b/tests/screentest/testdata/ci/vuln-list.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-search-540x1080.a.png b/tests/screentest/testdata/ci/vuln-search-540x1080.a.png
index 4639b3d..5f934e0 100644
--- a/tests/screentest/testdata/ci/vuln-search-540x1080.a.png
+++ b/tests/screentest/testdata/ci/vuln-search-540x1080.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln-search.a.png b/tests/screentest/testdata/ci/vuln-search.a.png
index 315ce5e..9c8a333 100644
--- a/tests/screentest/testdata/ci/vuln-search.a.png
+++ b/tests/screentest/testdata/ci/vuln-search.a.png
Binary files differ
diff --git a/tests/screentest/testdata/ci/vuln.a.png b/tests/screentest/testdata/ci/vuln.a.png
index f70c30a..93aa5d6 100644
--- a/tests/screentest/testdata/ci/vuln.a.png
+++ b/tests/screentest/testdata/ci/vuln.a.png
Binary files differ
To view, visit change 506957. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/cc36ba20-a096-40c6-9659-eb2e473d7435
Patch set 2:TryBot-Result -1
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/321e359e-6645-4cbc-a28d-b01cdc0a2394
Patch set 3:TryBot-Result -1
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/e33b3ca6-b046-4ba5-8055-427646679faa
Patch set 4:TryBot-Result -1
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/39f4ac1f-36c7-4bf5-855d-bbd77c9ae455
Patch set 5:TryBot-Result +1
Tatiana Bradley (Gerrit)
Attention is currently required from: Tatiana Bradley.
Tatiana Bradley uploaded patch set #6 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Tatiana Bradley, TryBot-Result+1 by kokoro, TryBot-Result-1 by Gopher Robot
static/frontend/vuln: display vuln summaries
Display summary instead of Go ID as the title of a vulnerability on the
list pages and entry pages.
Change-Id: I5d271acb74ce97721c5fa4ec8c71fb0b715e386b
---
M static/frontend/vuln/entry/entry.tmpl
M static/frontend/vuln/list/list.tmpl
M static/frontend/vuln/main/main.tmpl
M static/frontend/vuln/vuln.tmpl
M tests/screentest/testdata/ci/vuln-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry.a.png
M tests/screentest/testdata/ci/vuln-list-540x1080.a.png
M tests/screentest/testdata/ci/vuln-list.a.png
M tests/screentest/testdata/ci/vuln-search-540x1080.a.png
M tests/screentest/testdata/ci/vuln-search.a.png
M tests/screentest/testdata/ci/vuln.a.png
12 files changed, 8 insertions(+), 5 deletions(-)
To view, visit change 506957. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/c7d70909-dce5-4a5d-81e1-6524f211cd2c
Patch set 6:kokoro-CI -1
Tatiana Bradley (Gerrit)
Attention is currently required from: Tatiana Bradley.
Tatiana Bradley uploaded patch set #7 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Tatiana Bradley, TryBot-Result+1 by Gopher Robot, kokoro-CI-1 by kokoro
static/frontend/vuln: display vuln summaries
Display summary instead of Go ID as the title of a vulnerability on the
list pages and entry pages.
Change-Id: I5d271acb74ce97721c5fa4ec8c71fb0b715e386b
---
M static/frontend/vuln/entry/entry.tmpl
M static/frontend/vuln/list/list.tmpl
M static/frontend/vuln/main/main.tmpl
M static/frontend/vuln/vuln.tmpl
M tests/screentest/testdata/ci/vuln-search-540x1080.a.png
M tests/screentest/testdata/ci/vuln-search.a.png
6 files changed, 7 insertions(+), 5 deletions(-)
To view, visit change 506957. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/6e52226a-91ca-4853-b495-5d32681f4dde
Patch set 7:kokoro-CI -1
Tatiana Bradley (Gerrit)
Attention is currently required from: Tatiana Bradley.
Tatiana Bradley uploaded patch set #8 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Tatiana Bradley, TryBot-Result+1 by Gopher Robot, kokoro-CI-1 by kokoro
static/frontend/vuln: display vuln summaries
Display summary instead of Go ID as the title of a vulnerability on the
list pages and entry pages.
Change-Id: I5d271acb74ce97721c5fa4ec8c71fb0b715e386b
---
M static/frontend/vuln/entry/entry.tmpl
M static/frontend/vuln/list/list.tmpl
M static/frontend/vuln/main/main.tmpl
M static/frontend/vuln/vuln.tmpl
M tests/screentest/testdata/ci/vuln-540x1080.a.png
M tests/screentest/testdata/ci/vuln-list-540x1080.a.png
M tests/screentest/testdata/ci/vuln-list.a.png
M tests/screentest/testdata/ci/vuln-search-540x1080.a.png
M tests/screentest/testdata/ci/vuln-search.a.png
M tests/screentest/testdata/ci/vuln.a.png
10 files changed, 4 insertions(+), 4 deletions(-)
To view, visit change 506957. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/9b06a917-b3b5-4009-9c76-1ef0afba1375
Patch set 8:kokoro-CI -1
Tatiana Bradley (Gerrit)
Attention is currently required from: Tatiana Bradley.
Tatiana Bradley uploaded patch set #9 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Tatiana Bradley, TryBot-Result+1 by Gopher Robot, kokoro-CI-1 by kokoro
static/frontend/vuln: display vuln summaries
Display summary instead of Go ID as the title of a vulnerability on the
list pages and entry pages.
Change-Id: I5d271acb74ce97721c5fa4ec8c71fb0b715e386b
---
M internal/frontend/vulns.go
M static/frontend/vuln/entry/entry.tmpl
M static/frontend/vuln/list/list.tmpl
M static/frontend/vuln/main/main.tmpl
M static/frontend/vuln/vuln.css
M static/frontend/vuln/vuln.min.css
M static/frontend/vuln/vuln.min.css.map
M static/frontend/vuln/vuln.tmpl
M tests/screentest/testdata/ci/vuln-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-with-advisory-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-with-advisory.a.png
M tests/screentest/testdata/ci/vuln-entry.a.png
M tests/screentest/testdata/ci/vuln-list-540x1080.a.png
M tests/screentest/testdata/ci/vuln-list.a.png
M tests/screentest/testdata/ci/vuln-search-540x1080.a.png
M tests/screentest/testdata/ci/vuln-search.a.png
M tests/screentest/testdata/ci/vuln.a.png
18 files changed, 16 insertions(+), 6 deletions(-)
To view, visit change 506957. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/990f5b77-aa3f-4dfd-8209-66d4bb53fbaf
Patch set 9:kokoro-CI -1
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/97c16f1e-f9a0-4e1f-a923-9ef68810eb67
Patch set 10:kokoro-CI -1
Tatiana Bradley (Gerrit)
Attention is currently required from: Tatiana Bradley.
Tatiana Bradley uploaded patch set #11 to this change.
To view, visit change 506957. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/07632705-2802-490b-a59b-c54bc5f1d1ee
Patch set 11:kokoro-CI +1
Tatiana Bradley (Gerrit)
Attention is currently required from: Tatiana Bradley.
Tatiana Bradley uploaded patch set #12 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Tatiana Bradley, TryBot-Result+1 by Gopher Robot, kokoro-CI+1 by kokoro
static/frontend/vuln: display vuln summaries
Display summary instead of Go ID as the title of a vulnerability on the
list pages and entry pages.
Change-Id: I5d271acb74ce97721c5fa4ec8c71fb0b715e386b
---
M internal/frontend/vulns.go
M static/frontend/vuln/entry/entry.tmpl
M static/frontend/vuln/list/list.tmpl
M static/frontend/vuln/main/main.tmpl
M static/frontend/vuln/vuln.css
M static/frontend/vuln/vuln.min.css
M static/frontend/vuln/vuln.min.css.map
M static/frontend/vuln/vuln.tmpl
M tests/screentest/testdata/ci/vuln-entry-with-advisory-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-with-advisory.a.png
10 files changed, 16 insertions(+), 6 deletions(-)
To view, visit change 506957. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/2a49796e-3db2-47e8-86c3-f72ef42e64d6
Patch set 12:kokoro-CI +1
Tatiana Bradley (Gerrit)
Attention is currently required from: Tatiana Bradley.
Tatiana Bradley uploaded patch set #13 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Tatiana Bradley, TryBot-Result+1 by Gopher Robot, kokoro-CI+1 by kokoro
static/frontend/vuln: display vuln summaries
Display summary instead of Go ID as the title of a vulnerability on the
list pages and entry pages.
Change-Id: I5d271acb74ce97721c5fa4ec8c71fb0b715e386b
---
M internal/frontend/vulns.go
M static/frontend/vuln/entry/entry.tmpl
M static/frontend/vuln/list/list.tmpl
M static/frontend/vuln/main/main.tmpl
M static/frontend/vuln/vuln.css
M static/frontend/vuln/vuln.min.css
M static/frontend/vuln/vuln.min.css.map
M static/frontend/vuln/vuln.tmpl
M tests/screentest/testdata/ci/vuln-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-with-advisory-540x1080.a.png
M tests/screentest/testdata/ci/vuln-entry-with-advisory.a.png
M tests/screentest/testdata/ci/vuln-entry.a.png
M tests/screentest/testdata/ci/vuln-list-540x1080.a.png
M tests/screentest/testdata/ci/vuln-list.a.png
M tests/screentest/testdata/ci/vuln-search-540x1080.a.png
M tests/screentest/testdata/ci/vuln-search.a.png
M tests/screentest/testdata/ci/vuln.a.png
18 files changed, 16 insertions(+), 6 deletions(-)
To view, visit change 506957. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Tatiana Bradley.
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/75f0fb77-acfd-4b56-bc93-f94a6efd7c10
Patch set 13:kokoro-CI +1