[text] encoding/japanese: document that decoding follows RFC 2237, not WHATWG

0 views
Skip to first unread message

Damien Neil (Gerrit)

unread,
Aug 11, 2026, 4:54:50 PM (11 hours ago) Aug 11
to goph...@pubsubhelper.golang.org, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Nicholas Husin

Damien Neil voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nicholas Husin
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: text
Gerrit-Branch: master
Gerrit-Change-Id: I5028445a75bc87dd01b4130d0541bac06a6a6964
Gerrit-Change-Number: 813480
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Nicholas Husin <n...@golang.org>
Gerrit-Comment-Date: Tue, 11 Aug 2026 20:54:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
Aug 11, 2026, 5:13:41 PM (10 hours ago) Aug 11
to Damien Neil, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil

Nicholas Husin voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: text
Gerrit-Branch: master
Gerrit-Change-Id: I5028445a75bc87dd01b4130d0541bac06a6a6964
Gerrit-Change-Number: 813480
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Tue, 11 Aug 2026 21:13:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
Aug 11, 2026, 5:14:22 PM (10 hours ago) Aug 11
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil

Nicholas Husin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: text
    Gerrit-Branch: master
    Gerrit-Change-Id: I5028445a75bc87dd01b4130d0541bac06a6a6964
    Gerrit-Change-Number: 813480
    Gerrit-PatchSet: 1
    Gerrit-Owner: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Nicholas Husin <hu...@google.com>
    Gerrit-Comment-Date: Tue, 11 Aug 2026 21:14:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Damien Neil (Gerrit)

    unread,
    Aug 11, 2026, 7:52:30 PM (8 hours ago) Aug 11
    to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

    Damien Neil submitted the change

    Change information

    Commit message:
    encoding/japanese: document that decoding follows RFC 2237, not WHATWG
    Change-Id: I5028445a75bc87dd01b4130d0541bac06a6a6964
    Reviewed-by: Nicholas Husin <hu...@google.com>
    Reviewed-by: Nicholas Husin <n...@golang.org>
    Files:
    • M encoding/japanese/iso2022jp.go
    Change size: S
    Delta: 1 file changed, 10 insertions(+), 0 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: text
    Gerrit-Branch: master
    Gerrit-Change-Id: I5028445a75bc87dd01b4130d0541bac06a6a6964
    Gerrit-Change-Number: 813480
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages