[tools] internal/gcimporter: rename ureader_yes.go to ureader.go

1 view
Skip to first unread message

Mark Freeman (Gerrit)

unread,
Apr 8, 2026, 3:42:14 PM (10 hours ago) Apr 8
to goph...@pubsubhelper.golang.org, Robert Griesemer, golang-co...@googlegroups.com
Attention needed from Robert Griesemer

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Robert Griesemer
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I6b11c87bc63e9eca925f2b8f21ca1a572a8e51fb
Gerrit-Change-Number: 764280
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Attention: Robert Griesemer <g...@google.com>
Gerrit-Comment-Date: Wed, 08 Apr 2026 19:42:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Robert Griesemer (Gerrit)

unread,
Apr 8, 2026, 6:02:51 PM (8 hours ago) Apr 8
to Mark Freeman, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Mark Freeman

Robert Griesemer voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Freeman
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I6b11c87bc63e9eca925f2b8f21ca1a572a8e51fb
Gerrit-Change-Number: 764280
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Attention: Mark Freeman <markf...@google.com>
Gerrit-Comment-Date: Wed, 08 Apr 2026 22:02:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Freeman (Gerrit)

unread,
Apr 8, 2026, 6:04:10 PM (8 hours ago) Apr 8
to goph...@pubsubhelper.golang.org, Robert Griesemer, golang-co...@googlegroups.com

Mark Freeman voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I6b11c87bc63e9eca925f2b8f21ca1a572a8e51fb
Gerrit-Change-Number: 764280
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Comment-Date: Wed, 08 Apr 2026 22:04:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Gopher Robot (Gerrit)

unread,
Apr 8, 2026, 6:21:24 PM (8 hours ago) Apr 8
to Mark Freeman, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Robert Griesemer, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
internal/gcimporter: rename ureader_yes.go to ureader.go

This just cleans up an artifact from when we had ureader_no.go and
ureader_yes.go and makes it so all our UIR readers are called the
same thing.
Change-Id: I6b11c87bc63e9eca925f2b8f21ca1a572a8e51fb
Reviewed-by: Robert Griesemer <g...@google.com>
Auto-Submit: Mark Freeman <markf...@google.com>
Files:
  • R internal/gcimporter/ureader.go
Change size: NoOp
Delta: 1 file changed, 0 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Robert Griesemer
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I6b11c87bc63e9eca925f2b8f21ca1a572a8e51fb
Gerrit-Change-Number: 764280
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages