[vscode-go] src: skip version check for golangci-lint

0 views

Skip to first unread message

Hongxiang Jiang (Gerrit)

unread,

Oct 1, 2025, 9:12:15 PM (7 hours ago) Oct 1

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Hongxiang Jiang has uploaded the change for review

Commit message

src: skip version check for golangci-lint

For golang/vscode-go#3843

Change-Id: I53029068b8baae51d120e30aeeb6ac731e8839f9

Change diff

diff --git a/extension/src/goLint.ts b/extension/src/goLint.ts
index 091301f..4818b1e 100644
--- a/extension/src/goLint.ts
+++ b/extension/src/goLint.ts
@@ -114,14 +114,9 @@
 		args.push(flag);
 	});
 	if (lintTool.startsWith('golangci-lint')) {
-		let version: number;
+		let version = 1;
 		if (lintTool === 'golangci-lint-v2') {
 			version = 2;
-		} else {
-			const { moduleVersion } = await inspectGoToolVersion(getBinPath(lintTool));
-			// if moduleVersion is undefined, treat it as version=1
-			// if moduleVersion is higher than v1 (v2, v3...), treat it as version=2
-			version = !moduleVersion || moduleVersion.startsWith('v1') ? 1 : 2;
 		}
 
 		// append common flags

Change information

Files:

M extension/src/goLint.ts

Change size: XS

Delta: 1 file changed, 1 insertion(+), 6 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Hongxiang Jiang (Gerrit)

unread,

Oct 1, 2025, 9:12:27 PM (7 hours ago) Oct 1

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Hongxiang Jiang voted

Auto-Submit	+1
Commit-Queue	+1