jiahua wang uploaded patch set #2 to this change.
encoding/base64: Add examples for Encode/Decode
Fixes: golang/go#37595
Change-Id: I83e5f6105748a0a9238322a4f7ec4b0bbf61a263
---
M src/encoding/base64/example_test.go
1 file changed, 22 insertions(+), 0 deletions(-)
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
jiahua wang has uploaded this change for review.
encoding/base64: Add examples for Encode/Decode
Change-Id: I83e5f6105748a0a9238322a4f7ec4b0bbf61a263
---
M src/encoding/base64/example_test.go
1 file changed, 22 insertions(+), 0 deletions(-)
diff --git a/src/encoding/base64/example_test.go b/src/encoding/base64/example_test.go
index 73f119a..5c2bf89 100644
--- a/src/encoding/base64/example_test.go
+++ b/src/encoding/base64/example_test.go
@@ -35,6 +35,15 @@
// YW55ICsgb2xkICYgZGF0YQ==
}
+func ExampleEncoding_Encode() {
+ data := []byte("Hello, world!")
+ dst := make([]byte, base64.StdEncoding.EncodedLen(len(data)))
+ base64.StdEncoding.Encode(dst, data)
+ fmt.Println(string(dst))
+ // Output:
+ // SGVsbG8sIHdvcmxkIQ==
+}
+
func ExampleEncoding_DecodeString() {
str := "c29tZSBkYXRhIHdpdGggACBhbmQg77u/"
data, err := base64.StdEncoding.DecodeString(str)
@@ -47,6 +56,19 @@
// "some data with \x00 and \ufeff"
}
+func ExampleEncoding_Decode() {
+ str := "SGVsbG8sIHdvcmxkIQ=="
+ dst := make([]byte, base64.StdEncoding.DecodedLen(len(str)))
+ n, err := base64.StdEncoding.Decode(dst, []byte(str))
+ if err != nil {
+ fmt.Println("decode error:", err)
+ return
+ }
+ fmt.Printf("%q: %d\n", dst, n)
+ // Output:
+ // "Hello, world!\x00\x00": 13
+}
+
func ExampleNewEncoder() {
input := []byte("foo\x00bar")
encoder := base64.NewEncoder(base64.StdEncoding, os.Stdout)
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Russ Cox.
Patch set 2:Code-Review +1
Attention is currently required from: Russ Cox.
jiahua wang uploaded patch set #3 to this change.
encoding/base64: Add examples for Encode/Decode
Fixes: golang/go#37595
Change-Id: I83e5f6105748a0a9238322a4f7ec4b0bbf61a263
---
M src/encoding/base64/example_test.go
1 file changed, 22 insertions(+), 0 deletions(-)
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Russ Cox.
Patch set 3:Run-TryBot +1
1 comment:
Commit Message:
Patch Set #3, Line 7: encoding/base64: Add examples for Encode/Decode
s/Add/add/
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Russ Cox.
jiahua wang uploaded patch set #4 to this change.
encoding/base64: add examples for Encode/Decode
Fixes: golang/go#37595
Change-Id: I83e5f6105748a0a9238322a4f7ec4b0bbf61a263
---
M src/encoding/base64/example_test.go
1 file changed, 32 insertions(+), 0 deletions(-)
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Russ Cox.
Patch set 4:Run-TryBot +1
Attention is currently required from: jiahua wang, Russ Cox.
1 comment:
File src/encoding/base64/example_test.go:
Patch Set #4, Line 67: fmt.Printf("%q: %d\n", dst, n)
This should be like the encoding/base32 example. dst = dst[:n] and then just print dst.
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Russ Cox.
jiahua wang uploaded patch set #5 to this change.
encoding/base64: add examples for Encode/Decode
Fixes golang/go#37595
Change-Id: I83e5f6105748a0a9238322a4f7ec4b0bbf61a263
---
M src/encoding/base64/example_test.go
1 file changed, 33 insertions(+), 0 deletions(-)
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Russ Cox.
Patch set 5:Run-TryBot +1
1 comment:
File src/encoding/base64/example_test.go:
Patch Set #4, Line 67: fmt.Printf("%q: %d\n", dst, n)
This should be like the encoding/base32 example. dst = dst[:n] and then just print dst.
Done
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Russ Cox.
Patch set 6:Run-TryBot +1
Attention is currently required from: jiahua wang, Russ Cox.
Patch set 6:Code-Review +2
1 comment:
Patchset:
Thanks.
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Ian Lance Taylor, Russ Cox.
Patch set 6:Trust +1
2 comments:
Commit Message:
Patch Set #3, Line 7: encoding/base64: Add examples for Encode/Decode
s/Add/add/
Ack
Commit Message:
Patch Set #6, Line 9: Fixes golang/go#37595
Minor: remove "golang/go" as this is already the Go repo. Also, add a blank line
after this line before the change ID line. Thanks.
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Ian Lance Taylor, Russ Cox.
jiahua wang uploaded patch set #7 to this change.
encoding/base64: add examples for Encode/Decode
Fixes #37595
Change-Id: I83e5f6105748a0a9238322a4f7ec4b0bbf61a263
---
M src/encoding/base64/example_test.go
1 file changed, 34 insertions(+), 0 deletions(-)
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: jiahua wang, Ian Lance Taylor, Russ Cox.
Patch set 7:Code-Review +2Trust +1
1 comment:
Patchset:
PS7 just updates the commit message, and PS6 passed the tests. Submitting.
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.
Daniel Martí submitted this change.
encoding/base64: add examples for Encode/Decode
Fixes #37595
Change-Id: I83e5f6105748a0a9238322a4f7ec4b0bbf61a263
Reviewed-on: https://go-review.googlesource.com/c/go/+/348394
Reviewed-by: Daniel Martí <mv...@mvdan.cc>
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
Trust: Daniel Martí <mv...@mvdan.cc>
Trust: Cherry Mui <cher...@google.com>
---
M src/encoding/base64/example_test.go
1 file changed, 39 insertions(+), 0 deletions(-)
diff --git a/src/encoding/base64/example_test.go b/src/encoding/base64/example_test.go
index 73f119a..61a3adc 100644
--- a/src/encoding/base64/example_test.go
+++ b/src/encoding/base64/example_test.go
@@ -35,6 +35,15 @@
// YW55ICsgb2xkICYgZGF0YQ==
}
+func ExampleEncoding_Encode() {
+ data := []byte("Hello, world!")
+ dst := make([]byte, base64.StdEncoding.EncodedLen(len(data)))
+ base64.StdEncoding.Encode(dst, data)
+ fmt.Println(string(dst))
+ // Output:
+ // SGVsbG8sIHdvcmxkIQ==
+}
+
func ExampleEncoding_DecodeString() {
str := "c29tZSBkYXRhIHdpdGggACBhbmQg77u/"
data, err := base64.StdEncoding.DecodeString(str)
@@ -47,6 +56,20 @@
// "some data with \x00 and \ufeff"
}
+func ExampleEncoding_Decode() {
+ str := "SGVsbG8sIHdvcmxkIQ=="
+ dst := make([]byte, base64.StdEncoding.DecodedLen(len(str)))
+ n, err := base64.StdEncoding.Decode(dst, []byte(str))
+ if err != nil {
+ fmt.Println("decode error:", err)
+ return
+ }
+ dst = dst[:n]
+ fmt.Printf("%q\n", dst)
+ // Output:
+ // "Hello, world!"
+}
+
func ExampleNewEncoder() {
input := []byte("foo\x00bar")
encoder := base64.NewEncoder(base64.StdEncoding, os.Stdout)
To view, visit change 348394. To unsubscribe, or for help writing mail filters, visit settings.