[go] simd/archsimd: guard test helpers with amd64 tag

5 views
Skip to first unread message

Cherry Mui (Gerrit)

unread,
Dec 23, 2025, 1:30:04 PM (2 days ago) Dec 23
to goph...@pubsubhelper.golang.org, David Chase, golang-co...@googlegroups.com
Attention needed from David Chase

Cherry Mui voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Chase
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ie75f1fbb3b91629bc477b3140630bc47a4ef5b63
Gerrit-Change-Number: 732380
Gerrit-PatchSet: 1
Gerrit-Owner: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Attention: David Chase <drc...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 18:29:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
Dec 24, 2025, 8:26:20 AM (18 hours ago) Dec 24
to Cherry Mui, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Cherry Mui

David Chase voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ie75f1fbb3b91629bc477b3140630bc47a4ef5b63
Gerrit-Change-Number: 732380
Gerrit-PatchSet: 1
Gerrit-Owner: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 13:26:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
Dec 24, 2025, 8:26:32 AM (18 hours ago) Dec 24
to Cherry Mui, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, golang-co...@googlegroups.com

David Chase submitted the change

Change information

Commit message:
simd/archsimd: guard test helpers with amd64 tag

The test helpers load vectors. Currently the load functions are
only available on AMD64, so guard them with the tag. Now

GOEXPERIMENT=simd go test simd/...

doesn't fail on a non-AMD64 machine.
Change-Id: Ie75f1fbb3b91629bc477b3140630bc47a4ef5b63
Reviewed-by: David Chase <drc...@google.com>
Files:
  • M src/simd/archsimd/_gen/tmplgen/main.go
  • M src/simd/archsimd/internal/simd_test/binary_helpers_test.go
  • M src/simd/archsimd/internal/simd_test/compare_helpers_test.go
  • M src/simd/archsimd/internal/simd_test/comparemasked_helpers_test.go
  • M src/simd/archsimd/internal/simd_test/ternary_helpers_test.go
  • M src/simd/archsimd/internal/simd_test/unary_helpers_test.go
Change size: S
Delta: 6 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ie75f1fbb3b91629bc477b3140630bc47a4ef5b63
Gerrit-Change-Number: 732380
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages