[go] go/ast: more idiomatic struct initilization
ideapark (Gerrit)
ideapark has uploaded this change for review.
go/ast: more idiomatic struct initilization
Signed-off-by: Park Zhou <buil...@gmail.com>
Change-Id: Iaacda58792dec6d981d220e1d837cdd4bb6b1b8f
---
M src/go/ast/resolve.go
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/go/ast/resolve.go b/src/go/ast/resolve.go
index 970aa88..6b9c2fc 100644
--- a/src/go/ast/resolve.go
+++ b/src/go/ast/resolve.go
@@ -71,8 +71,7 @@
// different package names are reported and then ignored.
// The result is a package node and a scanner.ErrorList if there were errors.
func NewPackage(fset *token.FileSet, files map[string]*File, importer Importer, universe *Scope) (*Package, error) {
- var p pkgBuilder
- p.fset = fset
+ var p = pkgBuilder{fset: fset}
// complete package scope
pkgName := ""
To view, visit change 407539. To unsubscribe, or for help writing mail filters, visit settings.
Robert Griesemer (Gerrit)
Attention is currently required from: Robert Griesemer, ideapark.
Patch set 1:Hold +1
2 comments:
Patchset:
Thanks, but the existing form was chosen on purpose. There's no need for this change. Please abandon.
File src/go/ast/resolve.go:
Patch Set #1, Line 74:
var p = pkgBuilder{fset: fset}The previous form (explicit setting of fset field) was chosen deliberately as we only set on field here, not all of them.
There's really no reason to change this.
To view, visit change 407539. To unsubscribe, or for help writing mail filters, visit settings.
ideapark (Gerrit)
ideapark abandoned this change.
To view, visit change 407539. To unsubscribe, or for help writing mail filters, visit settings.