[go] cmd/go: make the package loader a part of the module loader
3 views
Skip to first unread message
Michael Matloob (Gerrit)
Mar 9, 2026, 12:48:05 PM (9 days ago) Mar 9
to goph...@pubsubhelper.golang.org, Ian Alexander, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ian Alexander
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ian Alexander
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Mar 9, 2026, 12:48:07 PM (9 days ago) Mar 9
to goph...@pubsubhelper.golang.org, Ian Alexander, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ian Alexander
Michael Matloob voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Ian Alexander
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Mar 9, 2026, 12:48:19 PM (9 days ago) Mar 9
to Michael Matloob, goph...@pubsubhelper.golang.org, Ian Alexander, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ian Alexander and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Alexander
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Alexander (Gerrit)
Mar 17, 2026, 8:46:07 PM (17 hours ago) Mar 17
to Michael Matloob, goph...@pubsubhelper.golang.org, Go LUCI, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Ian Alexander added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Ian Alexander . unresolved
Expanding the commit message to explain why we are doing this would be helpful for posterity.
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
10:25 AM (4 hours ago) 10:25 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #3 to this change.
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
10:25 AM (3 hours ago) 10:25 AM
to goph...@pubsubhelper.golang.org, Go LUCI, Michael Matloob, Ian Alexander, golang-co...@googlegroups.com
Attention needed from Ian Alexander
Michael Matloob voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Matloob
| Auto-Submit | +1 |
Expanding the commit message to explain why we are doing this would be helpful for posterity.
Attention is currently required from:
- Ian Alexander
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Alexander (Gerrit)
12:28 PM (1 hour ago) 12:28 PM
to Michael Matloob, goph...@pubsubhelper.golang.org, Go LUCI, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Ian Alexander voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
12:35 PM (1 hour ago) 12:35 PM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Ian Alexander, Go LUCI, Michael Matloob, golang-co...@googlegroups.com
Michael Matloob submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/go: make the package loader a part of the module loader
This is a part of the project to remove global state in the module
loader. Before this change, the packageLoader was stored in a global
field "loaded" which meant that even though the module loader is no
longer global, part of the module loader still depended on global state.
This change will make progress to the point where we can potentially
have multiple module loaders in the same go/command execution.
Change-Id: If4963a8a9d0e04960cf5424e496114276a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/753220
Reviewed-by: Ian Alexander <ji...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <mat...@google.com>
Files:
- M src/cmd/go/internal/modcmd/vendor.go
- M src/cmd/go/internal/modcmd/why.go
- M src/cmd/go/internal/modget/get.go
- M src/cmd/go/internal/modload/build.go
- M src/cmd/go/internal/modload/init.go
- M src/cmd/go/internal/modload/load.go
- M src/cmd/go/internal/workcmd/sync.go
Change size: M
Delta: 7 files changed, 37 insertions(+), 37 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Ian Alexander, +1 by Michael Matloob
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages