[tools] cmd/compilebench: fix finding the end of exportdata

2 views
Skip to first unread message

Tim King (Gerrit)

unread,
Dec 3, 2024, 1:12:08 PMDec 3
to goph...@pubsubhelper.golang.org, David Chase, golang-co...@googlegroups.com
Attention needed from David Chase

Tim King voted and added 1 comment

Votes added by Tim King

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tim King . unresolved

Ask I mentioned offline, I don't really know how to test this. Any pointers?

Open in Gerrit

Related details

Attention is currently required from:
  • David Chase
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0b52b9a40b152f22457fb53f0ee3153a85fa7817
Gerrit-Change-Number: 633276
Gerrit-PatchSet: 1
Gerrit-Owner: Tim King <tak...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Tim King <tak...@google.com>
Gerrit-Attention: David Chase <drc...@google.com>
Gerrit-Comment-Date: Tue, 03 Dec 2024 18:12:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
Dec 3, 2024, 2:18:22 PMDec 3
to Tim King, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Tim King

David Chase voted and added 3 comments

Votes added by David Chase

Code-Review+2

3 comments

Patchset-level comments
Tim King . resolved

Ask I mentioned offline, I don't really know how to test this. Any pointers?

David Chase

But you did hand-test it, right?

File cmd/compilebench/main.go
Line 396, Patchset 1 (Latest): log.Printf("failed to find objext sizes in %q: %v", opath, err)
David Chase . unresolved

objext?

Line 696, Patchset 1 (Latest):// objectFileSizes opens a cm/compile generated objext file and
David Chase . unresolved

what is "cm"?

Open in Gerrit

Related details

Attention is currently required from:
  • Tim King
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0b52b9a40b152f22457fb53f0ee3153a85fa7817
Gerrit-Change-Number: 633276
Gerrit-PatchSet: 1
Gerrit-Owner: Tim King <tak...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Tim King <tak...@google.com>
Gerrit-Attention: Tim King <tak...@google.com>
Gerrit-Comment-Date: Tue, 03 Dec 2024 19:18:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim King <tak...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Tim King (Gerrit)

unread,
Dec 3, 2024, 6:45:22 PMDec 3
to goph...@pubsubhelper.golang.org, David Chase, Go LUCI, golang-co...@googlegroups.com
Attention needed from David Chase

Tim King added 1 comment

Patchset-level comments
Tim King . unresolved

Ask I mentioned offline, I don't really know how to test this. Any pointers?

David Chase

But you did hand-test it, right?

Tim King

No. I don't know how this tool is used. I just came across a bug using find-grep in x/tools while looking for something else.

Open in Gerrit

Related details

Attention is currently required from:
  • David Chase
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0b52b9a40b152f22457fb53f0ee3153a85fa7817
Gerrit-Change-Number: 633276
Gerrit-PatchSet: 1
Gerrit-Owner: Tim King <tak...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Tim King <tak...@google.com>
Gerrit-Attention: David Chase <drc...@google.com>
Gerrit-Comment-Date: Tue, 03 Dec 2024 23:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim King <tak...@google.com>
Comment-In-Reply-To: David Chase <drc...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
Dec 4, 2024, 11:11:09 AMDec 4
to Tim King, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Tim King

David Chase added 1 comment

Patchset-level comments
Tim King . unresolved

Ask I mentioned offline, I don't really know how to test this. Any pointers?

David Chase

But you did hand-test it, right?

Tim King

No. I don't know how this tool is used. I just came across a bug using find-grep in x/tools while looking for something else.

David Chase

It benchmarks the compiler.

```
% go install golang.org/x/tools/cmd/compilebench@latest
% compilebench -short
BenchmarkTemplate 1 58970833 ns/op 147949000 user-ns/op
BenchmarkUnicode 1 43797166 ns/op 46103000 user-ns/op
BenchmarkGoTypes 1 349501292 ns/op 1102874000 user-ns/op
BenchmarkCompiler 1 66763333 ns/op 76304000 user-ns/op
BenchmarkSSA 1 2663752375 ns/op 8821012000 user-ns/op
BenchmarkFlate 1 34896833 ns/op 79261000 user-ns/op
BenchmarkGoParser 1 89897084 ns/op 160999000 user-ns/op
BenchmarkReflect 1 194949000 ns/op 479634000 user-ns/op
BenchmarkTar 1 70947542 ns/op 169373000 user-ns/op
BenchmarkXML 1 85236417 ns/op 211498000 user-ns/op
BenchmarkLinkCompiler 1 630529416 ns/op 448776000 user-ns/op
BenchmarkExternalLinkCompiler 1 6208228417 ns/op 1448390000 user-ns/op
BenchmarkLinkWithoutDebugCompiler 1 198396375 ns/op 197716000 user-ns/op
BenchmarkStdCmd 1 23286951209 ns/op
BenchmarkHelloSize 1 557056 text-bytes 184160 data-bytes 1540866 exe-bytes
BenchmarkCmdGoSize 1 6963200 text-bytes 650832 data-bytes 18360546 exe-bytes
```
You would not want to run it as a test, it takes a while.

Open in Gerrit

Related details

Attention is currently required from:
  • Tim King
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0b52b9a40b152f22457fb53f0ee3153a85fa7817
Gerrit-Change-Number: 633276
Gerrit-PatchSet: 1
Gerrit-Owner: Tim King <tak...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Tim King <tak...@google.com>
Gerrit-Attention: Tim King <tak...@google.com>
Gerrit-Comment-Date: Wed, 04 Dec 2024 16:11:05 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages