[go] build: force GOWORK=off in make.{bash,bat,rc}
100 views
Skip to first unread message
Dmitri Shuralyov (Gerrit)
Mar 18, 2022, 7:59:28 PM3/18/22
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
Dmitri Shuralyov has uploaded this change for review.
build: force GOWORK=off in make.{bash,bat,rc}
While building Go from source, workspace mode should be disabled,
even if the external environment tries to configure it otherwise.
Fixes #51558.
Change-Id: Icd7577860271f59a8f94406214b111280e4b65b5
---
M src/make.bash
M src/make.bat
M src/make.rc
3 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/src/make.bash b/src/make.bash
index 9acf079..96cbbf3 100755
--- a/src/make.bash
+++ b/src/make.bash
@@ -66,6 +66,7 @@
set -e
export GOENV=off
+export GOWORK=off # Issue 51558
unset GOBIN # Issue 14340
unset GOFLAGS
unset GO111MODULE
diff --git a/src/make.bat b/src/make.bat
index 6bffee0..56da417 100644
--- a/src/make.bat
+++ b/src/make.bat
@@ -47,6 +47,7 @@
:nolocal
set GOENV=off
+set GOWORK=off
set GOBUILDFAIL=0
set GOFLAGS=
set GO111MODULE=
diff --git a/src/make.rc b/src/make.rc
index 37087d6..066c3ab 100755
--- a/src/make.rc
+++ b/src/make.rc
@@ -48,6 +48,7 @@
}
GOENV=off
+GOWORK=off
GOFLAGS=()
GO111MODULE=()
GOROOT = `{cd .. && pwd}
To view, visit change 393879. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Mar 18, 2022, 8:00:12 PM3/18/22
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Patch set 1:Run-TryBot +1
1 comment:
Patchset:
TRY=longtest
To view, visit change 393879. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Mar 18, 2022, 10:44:30 PM3/18/22
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Bryan Mills, Gopher Robot, golang-co...@googlegroups.com
Attention is currently required from: Dmitri Shuralyov.
Patch set 1:Code-Review +2
Michael Matloob (Gerrit)
Mar 21, 2022, 1:46:12 PM3/21/22
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Bryan Mills, Gopher Robot, golang-co...@googlegroups.com
Attention is currently required from: Dmitri Shuralyov.
Patch set 1:Code-Review +2
To view, visit change 393879. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Mar 21, 2022, 2:57:48 PM3/21/22
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Michael Matloob, Bryan Mills, Gopher Robot, golang-co...@googlegroups.com
Patch set 1:Auto-Submit +1
Gopher Robot (Gerrit)
Mar 21, 2022, 2:58:39 PM3/21/22
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Matloob, Bryan Mills, golang-co...@googlegroups.com
Gopher Robot submitted this change.
Approvals:
Bryan Mills: Looks good to me, approved
Michael Matloob: Looks good to me, approved
Dmitri Shuralyov: Trusted; Run TryBots; Automatically submit change
Gopher Robot: TryBots succeeded
build: force GOWORK=off in make.{bash,bat,rc}
While building Go from source, workspace mode should be disabled,
even if the external environment tries to configure it otherwise.
Fixes #51558.
Change-Id: Icd7577860271f59a8f94406214b111280e4b65b5
Reviewed-on: https://go-review.googlesource.com/c/go/+/393879
Trust: Dmitri Shuralyov <dmit...@golang.org>
Run-TryBot: Dmitri Shuralyov <dmit...@golang.org>
TryBot-Result: Gopher Robot <go...@golang.org>
Reviewed-by: Bryan Mills <bcm...@google.com>
Reviewed-by: Michael Matloob <mat...@golang.org>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
---
M src/make.bash
M src/make.bat
M src/make.rc
3 files changed, 24 insertions(+), 0 deletions(-)
To view, visit change 393879. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages