[go] internal/nettest: use TEST-NET-01 addresses by default
0 views
Skip to first unread message
Damien Neil (Gerrit)
Aug 11, 2026, 12:04:52 PM (15 hours ago) Aug 11
to goph...@pubsubhelper.golang.org, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Aug 11, 2026, 5:14:14 PM (10 hours ago) Aug 11
to Damien Neil, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Aug 11, 2026, 5:14:21 PM (10 hours ago) Aug 11
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Aug 11, 2026, 7:51:36 PM (8 hours ago) Aug 11
to goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Aug 11, 2026, 8:32:27 PM (7 hours ago) Aug 11
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com
Damien Neil submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/nettest: use TEST-NET-01 addresses by default
When assigning arbitrary addresses to a Listener or Conn,
use addresses in 192.0.2.0/24 (TEST-NET-01, RFC 5735)
rather than loopback.
Avoids issues with httptest fakenet servers routing a request
for a name such as example.com to a loopback address, and
triggering DNS rebind protection (see #80810). The address
assigned by netttest is arbitrary, so we may as well use
one that is highly unlikely to collide with anything in
actual use.
For #80810
Change-Id: I58df7fa07982b089048cc3fb53f740f16a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/813200
Reviewed-by: Nicholas Husin <n...@golang.org>
Reviewed-by: Nicholas Husin <hu...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M src/internal/nettest/conn.go
- M src/internal/nettest/listener.go
Change size: XS
Delta: 2 files changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Nicholas Husin, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Aug 11, 2026, 8:42:14 PM (7 hours ago) Aug 11
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages