[tools] go/packages: match the Plan 9 error for a missing driver

2 views
Skip to first unread message

David du Colombier (Gerrit)

unread,
Jun 26, 2026, 2:07:20 PM (17 hours ago) Jun 26
to Michael Matloob, Richard Miller, Alan Donovan, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan, Michael Matloob and Richard Miller

David du Colombier has uploaded the change for review

David du Colombier would like Michael Matloob, Richard Miller and Alan Donovan to review this change.

Commit message

go/packages: match the Plan 9 error for a missing driver

TestDriver checks that loading with a nonexistent
GOPACKAGESDRIVER fails with an error matching "no
such file" or "file does not exist".

On Plan 9, the error is "... does not exist", so
add that to the expected pattern.
Change-Id: I4b1e29c93da1bed135cc57f39eaf8df5a4a4bbdc

Change diff

diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go
index 7d6cffa..3b5b3c4 100644
--- a/go/packages/packages_test.go
+++ b/go/packages/packages_test.go
@@ -1705,7 +1705,7 @@
 			onpath:           true,
 			gopackagesdriver: gopackagesdriver + "nonesuch",
 			entrypoint:       "driver1",
-			want:             "error: no such file|file does not exist",
+			want:             "error: no such file|file does not exist|does not exist",
 		},
 		// -- tests of driver response payload --
 		{

Change information

Files:
  • M go/packages/packages_test.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Michael Matloob
  • Richard Miller
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I4b1e29c93da1bed135cc57f39eaf8df5a4a4bbdc
Gerrit-Change-Number: 794841
Gerrit-PatchSet: 1
Gerrit-Owner: David du Colombier <0in...@gmail.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
Jun 26, 2026, 2:08:34 PM (17 hours ago) Jun 26
to David du Colombier, goph...@pubsubhelper.golang.org, Alan Donovan, Richard Miller, golang-co...@googlegroups.com
Attention needed from Alan Donovan, David du Colombier and Richard Miller

Michael Matloob voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • David du Colombier
  • Richard Miller
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I4b1e29c93da1bed135cc57f39eaf8df5a4a4bbdc
Gerrit-Change-Number: 794841
Gerrit-PatchSet: 1
Gerrit-Owner: David du Colombier <0in...@gmail.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: David du Colombier <0in...@gmail.com>
Gerrit-Attention: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 18:08:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
Jun 26, 2026, 2:08:40 PM (17 hours ago) Jun 26
to David du Colombier, goph...@pubsubhelper.golang.org, Michael Matloob, Alan Donovan, Richard Miller, golang-co...@googlegroups.com
Attention needed from Alan Donovan, David du Colombier and Richard Miller

Michael Matloob voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • David du Colombier
  • Richard Miller
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I4b1e29c93da1bed135cc57f39eaf8df5a4a4bbdc
Gerrit-Change-Number: 794841
Gerrit-PatchSet: 1
Gerrit-Owner: David du Colombier <0in...@gmail.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@google.com>
Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: David du Colombier <0in...@gmail.com>
Gerrit-Attention: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 18:08:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Jun 26, 2026, 2:09:42 PM (17 hours ago) Jun 26
to David du Colombier, goph...@pubsubhelper.golang.org, Michael Matloob, Michael Matloob, Richard Miller, golang-co...@googlegroups.com
Attention needed from David du Colombier and Richard Miller

Alan Donovan voted and added 1 comment

Votes added by Alan Donovan

Auto-Submit+1
Code-Review+2
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alan Donovan . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • David du Colombier
  • Richard Miller
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: tools
    Gerrit-Branch: master
    Gerrit-Change-Id: I4b1e29c93da1bed135cc57f39eaf8df5a4a4bbdc
    Gerrit-Change-Number: 794841
    Gerrit-PatchSet: 1
    Gerrit-Owner: David du Colombier <0in...@gmail.com>
    Gerrit-Reviewer: Alan Donovan <adon...@google.com>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Michael Matloob <mat...@google.com>
    Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
    Gerrit-Attention: David du Colombier <0in...@gmail.com>
    Gerrit-Attention: Richard Miller <millerr...@gmail.com>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 18:09:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    Jun 26, 2026, 2:34:10 PM (16 hours ago) Jun 26
    to David du Colombier, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Alan Donovan, Michael Matloob, Michael Matloob, Richard Miller, golang-co...@googlegroups.com

    Gopher Robot submitted the change

    Change information

    Commit message:
    go/packages: match the Plan 9 error for a missing driver

    TestDriver checks that loading with a nonexistent
    GOPACKAGESDRIVER fails with an error matching "no
    such file" or "file does not exist".

    On Plan 9, the error is "... does not exist", so
    add that to the expected pattern.
    Change-Id: I4b1e29c93da1bed135cc57f39eaf8df5a4a4bbdc
    Reviewed-by: Alan Donovan <adon...@google.com>
    Reviewed-by: Michael Matloob <mat...@google.com>
    Auto-Submit: Alan Donovan <adon...@google.com>
    Reviewed-by: Michael Matloob <mat...@golang.org>
    Files:
    • M go/packages/packages_test.go
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/master
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: tools
    Gerrit-Branch: master
    Gerrit-Change-Id: I4b1e29c93da1bed135cc57f39eaf8df5a4a4bbdc
    Gerrit-Change-Number: 794841
    Gerrit-PatchSet: 2
    Gerrit-Owner: David du Colombier <0in...@gmail.com>
    Gerrit-Reviewer: Alan Donovan <adon...@google.com>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Michael Matloob <mat...@google.com>
    Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages