[go] runtime: cleanup comments from asm_ppc64x.s improvements

1 view
Skip to first unread message

Paul Murphy (Gerrit)

unread,
10:36 AM (12 hours ago) 10:36 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Paul Murphy has uploaded the change for review

Commit message

runtime: cleanup comments from asm_ppc64x.s improvements

CL 706395 consolidated the aix and elf startup code, further
update the comments to reflect this.
Change-Id: Iccb98008b3fe4a4b08e55ee822924fad76846cc2

Change diff

diff --git a/src/runtime/asm_ppc64x.s b/src/runtime/asm_ppc64x.s
index 3fbf11b..aaf62c6 100644
--- a/src/runtime/asm_ppc64x.s
+++ b/src/runtime/asm_ppc64x.s
@@ -11,10 +11,10 @@
 #include "asm_ppc64x.h"
 #include "cgo/abi_ppc64x.h"
 
-
+// This is called using the host ABI. argc and argv arguments
+// should be in R3 and R4 respectively.
 TEXT _rt0_ppc64x_lib(SB),NOSPLIT|NOFRAME,$0
-	// This is called with ELFv2 calling conventions. Convert to Go.
-	// Allocate argument storage for call to newosproc0.
+	// Convert to Go ABI, and Allocate argument storage for call to newosproc0.
 	STACK_AND_SAVE_HOST_TO_GO_ABI(16)
 
 	MOVD	R3, _rt0_ppc64x_lib_argc<>(SB)
@@ -45,7 +45,6 @@
 	BL	(CTR)
 
 done:
-	// Restore and return to ELFv2 caller.
 	UNSTACK_AND_RESTORE_GO_TO_HOST_ABI(16)
 	RET

Change information

Files:
  • M src/runtime/asm_ppc64x.s
Change size: XS
Delta: 1 file changed, 3 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Iccb98008b3fe4a4b08e55ee822924fad76846cc2
Gerrit-Change-Number: 708355
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Murphy <paum...@redhat.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Paul Murphy (Gerrit)

unread,
10:36 AM (12 hours ago) 10:36 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Paul Murphy voted

Auto-Submit+1
Commit-Queue+1
Run-TryBot+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedLegacy-TryBots-Pass
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Iccb98008b3fe4a4b08e55ee822924fad76846cc2
    Gerrit-Change-Number: 708355
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Murphy <paum...@redhat.com>
    Gerrit-Reviewer: Paul Murphy <paum...@redhat.com>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 14:36:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Murphy (Gerrit)

    unread,
    10:37 AM (12 hours ago) 10:37 AM
    to goph...@pubsubhelper.golang.org, Keith Randall, Quim Muntal, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Keith Randall

    Paul Murphy added 1 comment

    Patchset-level comments
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keith Randall
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedLegacy-TryBots-Pass
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Iccb98008b3fe4a4b08e55ee822924fad76846cc2
    Gerrit-Change-Number: 708355
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Murphy <paum...@redhat.com>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-Reviewer: Paul Murphy <paum...@redhat.com>
    Gerrit-CC: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Keith Randall <k...@google.com>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 14:37:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    10:38 AM (12 hours ago) 10:38 AM
    to Paul Murphy, goph...@pubsubhelper.golang.org, Keith Randall, Quim Muntal, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Keith Randall

    Message from Gopher Robot

    Congratulations on opening your first change. Thank you for your contribution!

    Next steps:
    A maintainer will review your change and provide feedback. See
    https://go.dev/doc/contribute#review for more info and tips to get your
    patch through code review.

    Most changes in the Go project go through a few rounds of revision. This can be
    surprising to people new to the project. The careful, iterative review process
    is our way of helping mentor contributors and ensuring that their contributions
    have a lasting impact.

    During May-July and Nov-Jan the Go project is in a code freeze, during which
    little code gets reviewed or merged. If a reviewer responds with a comment like
    R=go1.11 or adds a tag like "wait-release", it means that this CL will be
    reviewed as part of the next development cycle. See https://go.dev/s/release
    for more details.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keith Randall
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedLegacy-TryBots-Pass
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Iccb98008b3fe4a4b08e55ee822924fad76846cc2
    Gerrit-Change-Number: 708355
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Murphy <paum...@redhat.com>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-Reviewer: Paul Murphy <paum...@redhat.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-CC: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Keith Randall <k...@google.com>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 14:38:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Quim Muntal (Gerrit)

    unread,
    10:43 AM (12 hours ago) 10:43 AM
    to Paul Murphy, goph...@pubsubhelper.golang.org, Gopher Robot, Keith Randall, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Keith Randall and Paul Murphy

    Quim Muntal voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keith Randall
    • Paul Murphy
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedLegacy-TryBots-Pass
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Iccb98008b3fe4a4b08e55ee822924fad76846cc2
    Gerrit-Change-Number: 708355
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Murphy <paum...@redhat.com>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-Reviewer: Paul Murphy <paum...@redhat.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Keith Randall <k...@google.com>
    Gerrit-Attention: Paul Murphy <paum...@redhat.com>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 14:43:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages