[go] runtime: add microbenchmarks for sizespecializedmalloc

2 views
Skip to first unread message

Michael Matloob (Gerrit)

unread,
May 8, 2026, 1:09:26 PM (3 days ago) May 8
to goph...@pubsubhelper.golang.org, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Pratt

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I0490fd8d72721cf25960086e82e55da96a6a6964
Gerrit-Change-Number: 775980
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Fri, 08 May 2026 17:09:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
May 8, 2026, 1:20:01 PM (3 days ago) May 8
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt

Michael Matloob uploaded new patchset

Michael Matloob uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I0490fd8d72721cf25960086e82e55da96a6a6964
Gerrit-Change-Number: 775980
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
May 8, 2026, 4:28:47 PM (3 days ago) May 8
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt

Michael Matloob uploaded new patchset

Michael Matloob uploaded patch set #3 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Michael Pratt
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I0490fd8d72721cf25960086e82e55da96a6a6964
    Gerrit-Change-Number: 775980
    Gerrit-PatchSet: 3
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Michael Matloob (Gerrit)

    unread,
    3:07 PM (8 hours ago) 3:07 PM
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Michael Matloob and Michael Pratt

    Michael Matloob uploaded new patchset

    Michael Matloob uploaded patch set #7 to this change.
    Following approvals got outdated and were removed:

    Related details

    Attention is currently required from:
    • Michael Matloob
    • Michael Pratt
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I0490fd8d72721cf25960086e82e55da96a6a6964
      Gerrit-Change-Number: 775980
      Gerrit-PatchSet: 7
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Michael Pratt (Gerrit)

      unread,
      5:10 PM (6 hours ago) 5:10 PM
      to Michael Matloob, goph...@pubsubhelper.golang.org, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
      Attention needed from Michael Matloob

      Michael Pratt voted and added 1 comment

      Votes added by Michael Pratt

      Code-Review+2

      1 comment

      File src/runtime/malloc_bench_generated_test.go
      Line 1391, Patchset 7 (Latest): b.Run("size=1", BenchmarkMallocTiny1)
      Michael Pratt . unresolved

      This seems odd. Won't BenchmarkMallocTiny1 run as a top-level benchmark (since the name starts with Benchmark) and a sub-benchmark?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Matloob
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I0490fd8d72721cf25960086e82e55da96a6a6964
      Gerrit-Change-Number: 775980
      Gerrit-PatchSet: 7
      Gerrit-Owner: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Attention: Michael Matloob <mat...@golang.org>
      Gerrit-Comment-Date: Mon, 11 May 2026 21:10:13 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Matloob (Gerrit)

      unread,
      9:42 PM (1 hour ago) 9:42 PM
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

      Michael Matloob uploaded new patchset

      Michael Matloob uploaded patch set #8 to this change.
      Following approvals got outdated and were removed:
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I0490fd8d72721cf25960086e82e55da96a6a6964
      Gerrit-Change-Number: 775980
      Gerrit-PatchSet: 8
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Matloob (Gerrit)

      unread,
      9:42 PM (1 hour ago) 9:42 PM
      to goph...@pubsubhelper.golang.org, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

      Michael Matloob added 1 comment

      File src/runtime/malloc_bench_generated_test.go
      Line 1391, Patchset 7: b.Run("size=1", BenchmarkMallocTiny1)
      Michael Pratt . resolved

      This seems odd. Won't BenchmarkMallocTiny1 run as a top-level benchmark (since the name starts with Benchmark) and a sub-benchmark?

      Michael Matloob

      It will. I'll unexport them.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I0490fd8d72721cf25960086e82e55da96a6a6964
      Gerrit-Change-Number: 775980
      Gerrit-PatchSet: 8
      Gerrit-Owner: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Comment-Date: Tue, 12 May 2026 01:42:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Michael Pratt <mpr...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Matloob (Gerrit)

      unread,
      10:17 PM (1 hour ago) 10:17 PM
      to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, golang-co...@googlegroups.com
      Attention needed from Michael Matloob

      Michael Matloob voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Matloob
      Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I0490fd8d72721cf25960086e82e55da96a6a6964
        Gerrit-Change-Number: 775980
        Gerrit-PatchSet: 8
        Gerrit-Owner: Michael Matloob <mat...@golang.org>
        Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
        Gerrit-Reviewer: Michael Matloob <mat...@google.com>
        Gerrit-Attention: Michael Matloob <mat...@golang.org>
        Gerrit-Comment-Date: Tue, 12 May 2026 02:17:54 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages