[go] cmd/list: fix -retracted flag description
Gerrit Bot (Gerrit)
Gerrit Bot has uploaded this change for review.
cmd/list: fix -retracted flag description
Change-Id: Ia1ab220485af2f38c3ddcd4c5d5bca1b195a33ed
GitHub-Last-Rev: 1b0899539a6884bc32b229255303b9c5266ef118
GitHub-Pull-Request: golang/go#59847
---
M src/cmd/go/internal/list/list.go
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/cmd/go/internal/list/list.go b/src/cmd/go/internal/list/list.go
index dd3e5cd..98cc5aa 100644
--- a/src/cmd/go/internal/list/list.go
+++ b/src/cmd/go/internal/list/list.go
@@ -297,8 +297,8 @@
The -retracted flag causes list to report information about retracted
module versions. When -retracted is used with -f or -json, the Retracted
-field will be set to a string explaining why the version was retracted.
-The string is taken from comments on the retract directive in the
+field will be set to a string array explaining why the version was retracted.
+The strings are taken from comments on the retract directive in the
module's go.mod file. When -retracted is used with -versions, retracted
versions are listed together with unretracted versions. The -retracted
flag may be used with or without -m.
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Gopher Robot (Gerrit)
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.
Bryan Mills (Gerrit)
Attention is currently required from: Michael Matloob.
2 comments:
Patchset:
You will also need to re-run `go generate cmd/go` to update `alldocs.go`. Please run `go test -short cmd/go` and mark this comment as resolved when it passes.
File src/cmd/go/internal/list/list.go:
Patch Set #1, Line 300:
will be set to a string array“set to a string array” is somewhat awkward, since the Go type is a slice (not an array).
```
the strings in the Retracted field explain why the version was retracted.
The strings are taken …
```
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
Gerrit Bot uploaded patch set #2 to this change.
cmd/list: fix -retracted flag description
Change-Id: Ia1ab220485af2f38c3ddcd4c5d5bca1b195a33ed
GitHub-Last-Rev: 9aeeec3bd4ac864451aa313f4cfdaaa49f7aeb8d
GitHub-Pull-Request: golang/go#59847
---
M src/cmd/go/alldocs.go
M src/cmd/go/internal/list/list.go
2 files changed, 4 insertions(+), 4 deletions(-)
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Andrei Efanov (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
1 comment:
File src/cmd/go/internal/list/list.go:
Patch Set #1, Line 300:
will be set to a string array
“set to a string array” is somewhat awkward, since the Go type is a slice (not an array). […]
Sorry, I do not distinguish slices and arrays well yet. As I understand from the spec (https://go.dev/ref/spec#Array_types), the difference is that the size is not specified.
But I wonder if it matters in this case. The `go help list` command will show the CLI documentation, so the underlying go types matter less here. Moreover, the field itself is only accessible in two cases:
1. GoTemplate formatting is used (`... -f '{{ .Retracted }}'`). As far as I know, the slice API here is the same as for arrays.
2. JSON output is requested. In this case, the user will see a JSON Array. So I believe the `array` word will be more convenient.I will use the correct term, `slice,` but let me know if you find `array` a better fit here.
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Andrei Efanov (Gerrit)
File src/cmd/go/internal/list/list.go:
Patch Set #1, Line 300:
will be set to a string array
Sorry, I do not distinguish slices and arrays well yet. As I understand from the spec (https://go. […]
@bcm...@google.com, I don't know if I should mark this thread resolved or not. Waiting for your reply 😊
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Andrei Efanov (Gerrit)
Patchset:
You will also need to re-run `go generate cmd/go` to update `alldocs.go`. […]
The tests almost finished successfully. The only problem was the known bug described [here](https://github.com/golang/go/issues/59026). So I guess, I can mark it resolved.
Thank you for your help!
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Andrei Efanov, Michael Matloob.
1 comment:
File src/cmd/go/internal/list/list.go:
Patch Set #1, Line 300:
will be set to a string array
@bcm...@google.com, I don't know if I should mark this thread resolved or not. […]
Instead of “will be set to a string slice explaining”, how about “explains”?
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Andrei Efanov (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
1 comment:
File src/cmd/go/internal/list/list.go:
Patch Set #1, Line 300:
will be set to a string array
Instead of “will be set to a string slice explaining”, how about “explains”?
Agree, this message now looks much simpler and clear. Thank you for the idea!
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
Gerrit Bot uploaded patch set #3 to this change.
cmd/list: fix -retracted flag description
Change-Id: Ia1ab220485af2f38c3ddcd4c5d5bca1b195a33ed
GitHub-Last-Rev: 91ca2003e14f1903ceb0dea44bd5a33afd93dcf0
GitHub-Pull-Request: golang/go#59847
---
M src/cmd/go/alldocs.go
M src/cmd/go/internal/list/list.go
2 files changed, 4 insertions(+), 4 deletions(-)
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Michael Matloob.
Patch set 3:Run-TryBot +1Auto-Submit +1
1 comment:
Patchset:
TRY=longtest
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
Gerrit Bot uploaded patch set #4 to this change.
The following approvals got outdated and were removed: Auto-Submit+1 by Bryan Mills, Run-TryBot+1 by Bryan Mills, TryBot-Result-1 by Gopher Robot
cmd/list: fix -retracted flag description
Change-Id: Ia1ab220485af2f38c3ddcd4c5d5bca1b195a33ed
GitHub-Last-Rev: fb9933427d852518c93efbc4f2c2e4d4ee9b9197
GitHub-Pull-Request: golang/go#59847
---
M src/cmd/go/alldocs.go
M src/cmd/go/internal/list/list.go
2 files changed, 4 insertions(+), 4 deletions(-)
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Andrei Efanov (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
1 comment:
Patchset:
2 of 46 SlowBots failed. […]
@bcm...@google.com, I just rebased the branch to address this issue. Could you restart the build?
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.
Andrei Efanov (Gerrit)
Patchset:
@bcm...@google.com, I just rebased the branch to address this issue. […]
Done
To view, visit change 489175. To unsubscribe, or for help writing mail filters, visit settings.