[oscar] all: go fix -newexpr ./...
1 view
Skip to first unread message
Hyang-Ah Hana Kim (Gerrit)
Feb 26, 2026, 10:07:55 PM (20 hours ago) Feb 26
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Hyang-Ah Hana Kim has uploaded the change for review![]( "Open in Gerrit")
Commit message
all: go fix -newexpr ./...
Change-Id: I56557a27c3ab0fe2ed303dc122d9389b0b024a58
Change diff
diff --git a/internal/discussion/gqlclient.go b/internal/discussion/gqlclient.go
index c0e92e2..9cc216d 100644
--- a/internal/discussion/gqlclient.go
+++ b/internal/discussion/gqlclient.go
@@ -147,7 +147,7 @@
if !page.PageInfo.HasNextPage {
return
}
- vars[q.CursorName()] = gql.NewString(page.PageInfo.EndCursor)
+ vars[q.CursorName()] = new(page.PageInfo.EndCursor)
}
}
}
diff --git a/internal/overview/poster_test.go b/internal/overview/poster_test.go
index c171e75..6aff167 100644
--- a/internal/overview/poster_test.go
+++ b/internal/overview/poster_test.go
@@ -72,7 +72,7 @@
wantReport: &actions.RunReport{
Completed: 2,
},
- autoApprove: ptr(true),
+ autoApprove: new(true),
wantEdits: []*github.TestingEdit{
{Project: project, Issue: 1, IssueCommentChanges: &github.IssueCommentChanges{
Body: mustComment(t, `an overview of issue 1 with 2 comment(s)`, w),
@@ -99,7 +99,7 @@
gh.Testing().AddIssue(project, &github.Issue{Number: 2, Body: "issue 2", CreatedAt: dec31_2022})
gh.Testing().AddIssueComment(project, 2, &github.IssueComment{Body: "issue 2 comment 1"})
},
- autoApprove: ptr(true),
+ autoApprove: new(true),
wantReport: &actions.RunReport{
Completed: 1,
},
@@ -123,8 +123,8 @@
gh.Testing().AddIssue(project, &github.Issue{Number: 2, Body: "issue 2", CreatedAt: dec30_2023})
gh.Testing().AddIssueComment(project, 2, &github.IssueComment{Body: "issue 2 comment 1"})
},
- autoApprove: ptr(true),
- maxAge: ptr(time.Hour * 24),
+ autoApprove: new(true),
+ maxAge: new(time.Hour * 24),
wantReport: &actions.RunReport{
Completed: 1,
},
@@ -176,10 +176,6 @@
}
}
-func ptr[T any](v T) *T {
- return &v
-}
-
func mustComment(t *testing.T, s string, w *wrap.Wrapper) string {
t.Helper()
c, err := comment(s, w)
Change information
Files:
- M internal/discussion/gqlclient.go
- M internal/overview/poster_test.go
Change size: S
Delta: 2 files changed, 5 insertions(+), 9 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
Feb 26, 2026, 11:42:57 PM (19 hours ago) Feb 26
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Ian Lance Taylor voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
4:39 PM (2 hours ago) 4:39 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
4:44 PM (2 hours ago) 4:44 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Hyang-Ah Hana Kim submitted the change![]( "Open in Gerrit")
Change information
Commit message:
all: go fix -newexpr ./...
Change-Id: I56557a27c3ab0fe2ed303dc122d9389b0b024a58
Reviewed-on: https://go-review.googlesource.com/c/oscar/+/749645
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Nicholas Husin <hu...@google.com>
Files:
- M internal/discussion/gqlclient.go
- M internal/overview/poster_test.go
Change size: S
Delta: 2 files changed, 5 insertions(+), 9 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Ian Lance Taylor
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages