[tools] gopls/internal/server: disable TestCheckGoModDeps for js

2 views
Skip to first unread message

Ethan Lee (Gerrit)

unread,
Dec 18, 2025, 3:32:07 PM (21 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Ethan Lee has uploaded the change for review

Commit message

gopls/internal/server: disable TestCheckGoModDeps for js

- test relies on os.Executable() which isn't implemented in js.

For golang/go#76895
Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec

Change diff

diff --git a/gopls/internal/server/vulncheck_prompt_test.go b/gopls/internal/server/vulncheck_prompt_test.go
index 0085438..89a2acc 100644
--- a/gopls/internal/server/vulncheck_prompt_test.go
+++ b/gopls/internal/server/vulncheck_prompt_test.go
@@ -111,6 +111,9 @@
 }
 
 func TestCheckGoModDeps(t *testing.T) {
+	if runtime.GOOS == "js" {
+		t.Skip("test does not work in a js environment")
+	}
 	const (
 		yes    = "Yes"
 		no     = "No"

Change information

Files:
  • M gopls/internal/server/vulncheck_prompt_test.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
Gerrit-Change-Number: 731281
Gerrit-PatchSet: 1
Gerrit-Owner: Ethan Lee <etha...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
Dec 18, 2025, 3:32:32 PM (21 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, Hongxiang Jiang, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang

Ethan Lee voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hongxiang Jiang
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
Gerrit-Change-Number: 731281
Gerrit-PatchSet: 1
Gerrit-Owner: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 20:32:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
Dec 18, 2025, 3:45:45 PM (21 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Hongxiang Jiang

Ethan Lee uploaded new patchset

Ethan Lee uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
  • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Open in Gerrit

Related details

Attention is currently required from:
  • Ethan Lee
  • Hongxiang Jiang
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
Gerrit-Change-Number: 731281
Gerrit-PatchSet: 2
Gerrit-Owner: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Attention: Ethan Lee <etha...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
Dec 18, 2025, 4:14:02 PM (20 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Hongxiang Jiang

Ethan Lee uploaded new patchset

Ethan Lee uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
  • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Open in Gerrit

Related details

Attention is currently required from:
  • Ethan Lee
  • Hongxiang Jiang
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
Gerrit-Change-Number: 731281
Gerrit-PatchSet: 3
unsatisfied_requirement
satisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
Dec 18, 2025, 4:14:53 PM (20 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Hongxiang Jiang

Ethan Lee uploaded new patchset

Ethan Lee uploaded patch set #4 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Ethan Lee
  • Hongxiang Jiang
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
Gerrit-Change-Number: 731281
Gerrit-PatchSet: 4
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Dec 18, 2025, 4:31:15 PM (20 hours ago) Dec 18
to Ethan Lee, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, Hongxiang Jiang, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Hongxiang Jiang

Dmitri Shuralyov added 1 comment

File gopls/internal/server/vulncheck_prompt_test.go
Line 115, Patchset 4 (Latest): if runtime.GOOS == "js" || runtime.GOARCH == "wasm" {
Dmitri Shuralyov . unresolved

Consider @hxj...@golang.org's [suggestion](https://go.dev/issue/76894#issuecomment-3672203117) of using `testenv.NeedsExec(t)`: it will handle additional test environments where execute permission is absent, it's shorter, it consolidates maintenance to that one function, and it's consistent with other tests.

Open in Gerrit

Related details

Attention is currently required from:
  • Ethan Lee
  • Hongxiang Jiang
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: tools
    Gerrit-Branch: master
    Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
    Gerrit-Change-Number: 731281
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ethan Lee <etha...@google.com>
    Gerrit-Reviewer: Ethan Lee <etha...@google.com>
    Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-Attention: Ethan Lee <etha...@google.com>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 21:31:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Ethan Lee (Gerrit)

    unread,
    Dec 18, 2025, 6:25:35 PM (18 hours ago) Dec 18
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Ethan Lee and Hongxiang Jiang

    Ethan Lee uploaded new patchset

    Ethan Lee uploaded patch set #5 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ethan Lee
    • Hongxiang Jiang
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: tools
    Gerrit-Branch: master
    Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
    Gerrit-Change-Number: 731281
    Gerrit-PatchSet: 5
    unsatisfied_requirement
    open
    diffy

    Ethan Lee (Gerrit)

    unread,
    Dec 18, 2025, 6:28:44 PM (18 hours ago) Dec 18
    to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, Hongxiang Jiang, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov and Hongxiang Jiang

    Ethan Lee voted and added 1 comment

    Votes added by Ethan Lee

    Auto-Submit+1

    1 comment

    File gopls/internal/server/vulncheck_prompt_test.go
    Line 115, Patchset 4: if runtime.GOOS == "js" || runtime.GOARCH == "wasm" {
    Dmitri Shuralyov . resolved

    Consider @hxj...@golang.org's [suggestion](https://go.dev/issue/76894#issuecomment-3672203117) of using `testenv.NeedsExec(t)`: it will handle additional test environments where execute permission is absent, it's shorter, it consolidates maintenance to that one function, and it's consistent with other tests.

    Ethan Lee

    Sounds good, I feel like that testenv.NeedsExec(t) doesn't really make that clear in the documentation.

    But I agree with the part that this test should use the consolidated test utilities available to us.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitri Shuralyov
    • Hongxiang Jiang
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: tools
      Gerrit-Branch: master
      Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
      Gerrit-Change-Number: 731281
      Gerrit-PatchSet: 4
      Gerrit-Owner: Ethan Lee <etha...@google.com>
      Gerrit-Reviewer: Ethan Lee <etha...@google.com>
      Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
      Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
      Gerrit-Comment-Date: Thu, 18 Dec 2025 23:28:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Dmitri Shuralyov <dmit...@golang.org>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Hongxiang Jiang (Gerrit)

      unread,
      Dec 18, 2025, 10:01:11 PM (14 hours ago) Dec 18
      to Ethan Lee, goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com
      Attention needed from Dmitri Shuralyov and Ethan Lee

      Hongxiang Jiang voted Code-Review+2

      Code-Review+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dmitri Shuralyov
      • Ethan Lee
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: tools
      Gerrit-Branch: master
      Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
      Gerrit-Change-Number: 731281
      Gerrit-PatchSet: 5
      Gerrit-Owner: Ethan Lee <etha...@google.com>
      Gerrit-Reviewer: Ethan Lee <etha...@google.com>
      Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
      Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Attention: Ethan Lee <etha...@google.com>
      Gerrit-Comment-Date: Fri, 19 Dec 2025 03:01:05 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Gopher Robot (Gerrit)

      unread,
      Dec 18, 2025, 10:02:52 PM (14 hours ago) Dec 18
      to Ethan Lee, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hongxiang Jiang, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com

      Gopher Robot submitted the change

      Change information

      Commit message:
      gopls/internal/server: disable TestCheckGoModDeps for js and wasm

      - test relies on os.Executable() which isn't implemented in js and wasm.

      For golang/go#76895
      Fixes golang/go#76894
      Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
      Reviewed-by: Hongxiang Jiang <hxj...@golang.org>
      Auto-Submit: Ethan Lee <etha...@google.com>
      Files:
      • M gopls/internal/server/vulncheck_prompt_test.go
      Change size: XS
      Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      • requirement satisfiedCode-Review: +2 by Hongxiang Jiang
      • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: tools
      Gerrit-Branch: master
      Gerrit-Change-Id: Ia907ea01eb5f518ae371df12683e61613a2cddec
      Gerrit-Change-Number: 731281
      Gerrit-PatchSet: 6
      Gerrit-Owner: Ethan Lee <etha...@google.com>
      Gerrit-Reviewer: Ethan Lee <etha...@google.com>
      Gerrit-Reviewer: Gopher Robot <go...@golang.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages