[go] crypto/x509: update x509-limbo tests
4 views
Skip to first unread message
Daniel McCarney (Gerrit)
Sep 3, 2026, 1:41:42 PMSep 3
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Daniel McCarney
Message from Daniel McCarney![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Daniel McCarney
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Roland Shoemaker (Gerrit)
Sep 3, 2026, 2:25:42 PMSep 3
to Daniel McCarney, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Filippo Valsorda, golang-co...@googlegroups.com
Attention needed from Daniel McCarney and Filippo Valsorda
Roland Shoemaker voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Daniel McCarney
- Filippo Valsorda
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Sep 4, 2026, 5:58:32 PMSep 4
to Daniel McCarney, goph...@pubsubhelper.golang.org, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, Roland Shoemaker, Filippo Valsorda, golang-co...@googlegroups.com
Attention needed from Daniel McCarney and Filippo Valsorda
Michael Pratt voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Daniel McCarney
- Filippo Valsorda
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel McCarney (Gerrit)
Sep 5, 2026, 8:32:50 AMSep 5
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, Roland Shoemaker, Filippo Valsorda, golang-co...@googlegroups.com
Daniel McCarney submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
crypto/x509: update x509-limbo tests
This commit updates the pinned x509-limbo dependency, regenerating the
version metadata, and ensuring the updated testcases are run.
The updated corpus adds coverage for bare and leading-period email and
URI name constraints. It also adds tests for empty permittedSubtrees and
excludedSubtrees sequences, which Go accepts when the other field is
non-empty. Allow that existing behavior for now.
All other new test cases pass unmodified.
Change-Id: I066f9e4da0f7c817bc71737d9a49b7b1a54337a8
Reviewed-on: https://go-review.googlesource.com/c/go/+/827346
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Michael Pratt <mpr...@google.com>
Files:
- M src/crypto/internal/cryptotest/x509limbo/_schema/schema_gen.go
- M src/crypto/internal/cryptotest/x509limbo/schemaversion.go
- M src/crypto/x509/x509limbo_test.go
Change size: XS
Delta: 3 files changed, 7 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Michael Pratt, +2 by Roland Shoemaker
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages