[go] database/sql/driver: fix Rows.Next() comment

3 views

Skip to first unread message

Gerrit Bot (Gerrit)

unread,

May 8, 2025, 6:14:50 AM5/8/25

to goph...@pubsubhelper.golang.org, Inada Naoki, golang-co...@googlegroups.com

Gerrit Bot has uploaded the change for review

Commit message

database/sql/driver: fix Rows.Next() comment

CL 89936 introduced restriction that Rows.Close() shouldn't modify dest
in previous Next().
CL 497675 for #60304 removed that restriction. But it didn't remove doc
about the restriction.

Change-Id: Idc0f16462fba4d2013ec069d251b8ebffbc4bdd1

GitHub-Last-Rev: f37493acd7aa3ad7863ad9c29b41290ad557d9cd

GitHub-Pull-Request: golang/go#73632

Change diff

diff --git a/src/database/sql/driver/driver.go b/src/database/sql/driver/driver.go
index d0892e8..ac4bd92 100644
--- a/src/database/sql/driver/driver.go
+++ b/src/database/sql/driver/driver.go
@@ -436,10 +436,6 @@
 	// size as the Columns() are wide.
 	//
 	// Next should return io.EOF when there are no more rows.
-	//
-	// The dest should not be written to outside of Next. Care
-	// should be taken when closing Rows not to modify
-	// a buffer held in dest.
 	Next(dest []Value) error
 }

Change information

Files:

M src/database/sql/driver/driver.go

Change size: XS

Delta: 1 file changed, 0 insertions(+), 4 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Sean Liao (Gerrit)

unread,

6:17 PM (5 hours ago) 6:17 PM

to Inada Naoki, Gerrit Bot, goph...@pubsubhelper.golang.org, Brad Fitzpatrick, Daniel Theophanes, Kevin Burke, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Brad Fitzpatrick and Daniel Theophanes

Sean Liao voted

Auto-Submit	+1
Code-Review	+2
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Brad Fitzpatrick
Daniel Theophanes

Submit Requirements:

Code-Review

No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages