[go] internal/poll: omit embedded type field in splicePipe construction

3 views
Skip to first unread message

Tobias Klauser (Gerrit)

unread,
5:33 AM (3 hours ago) 5:33 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Tobias Klauser has uploaded the change for review

Commit message

internal/poll: omit embedded type field in splicePipe construction

As flagged by the modernize linter.
Change-Id: Iba6ea62d617f7e3622773c76a47655f1ad8be0e5

Change diff

diff --git a/src/internal/poll/splice_linux.go b/src/internal/poll/splice_linux.go
index 4409d2f..6de3511 100644
--- a/src/internal/poll/splice_linux.go
+++ b/src/internal/poll/splice_linux.go
@@ -234,7 +234,7 @@
// although it will require more system calls.
unix.Fcntl(fds[0], syscall.F_SETPIPE_SZ, maxSpliceSize)

- return &splicePipe{splicePipeFields: splicePipeFields{rfd: fds[0], wfd: fds[1]}}
+ return &splicePipe{rfd: fds[0], wfd: fds[1]}
}

// destroyPipe destroys a pipe.

Change information

Files:
  • M src/internal/poll/splice_linux.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Iba6ea62d617f7e3622773c76a47655f1ad8be0e5
Gerrit-Change-Number: 779661
Gerrit-PatchSet: 1
Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages