[go] encoding/json/jsontext: clarify safety of AvailableBuffer
3 views
Skip to first unread message
Michael Pratt (Gerrit)
Aug 6, 2026, 3:13:15 PM (yesterday) Aug 6
to Michael Pratt, goph...@pubsubhelper.golang.org, Jonathan Amsterdam, Joseph Tsai, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil, Jonathan Amsterdam and Joseph Tsai
Michael Pratt voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Damien Neil
- Jonathan Amsterdam
- Joseph Tsai
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Amsterdam (Gerrit)
Aug 6, 2026, 4:50:52 PM (yesterday) Aug 6
to Michael Pratt, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Joseph Tsai, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil, Joseph Tsai and Michael Pratt
Jonathan Amsterdam voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Damien Neil
- Joseph Tsai
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Aug 6, 2026, 8:48:28 PM (yesterday) Aug 6
to Michael Pratt, goph...@pubsubhelper.golang.org, Jonathan Amsterdam, golang...@luci-project-accounts.iam.gserviceaccount.com, Joseph Tsai, golang-co...@googlegroups.com
Attention needed from Joseph Tsai and Michael Pratt
Damien Neil voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Joseph Tsai
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
11:28 AM (11 hours ago) 11:28 AM
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Joseph Tsai and Michael Pratt
Michael Pratt uploaded new patchset![]( "Open in Gerrit")
Michael Pratt uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Joseph Tsai
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
11:28 AM (11 hours ago) 11:28 AM
to Michael Pratt, goph...@pubsubhelper.golang.org, Damien Neil, Jonathan Amsterdam, golang...@luci-project-accounts.iam.gserviceaccount.com, Joseph Tsai, golang-co...@googlegroups.com
Attention needed from Joseph Tsai
Michael Pratt voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Joseph Tsai
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
1:01 PM (10 hours ago) 1:01 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Damien Neil, Jonathan Amsterdam, Joseph Tsai, golang-co...@googlegroups.com
Michael Pratt submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
encoding/json/jsontext: clarify safety of AvailableBuffer
The current wording makes it sound like the buffer itself is unsafe, but
this is just trying to warn that manually constructing a Value is
error-prone.
For #71497.
Change-Id: I12ab3ea4e858860f8a241c514a883d376a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/811780
Reviewed-by: Jonathan Amsterdam <j...@google.com>
Reviewed-by: Damien Neil <dn...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M src/encoding/json/jsontext/encode.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Damien Neil, +2 by Jonathan Amsterdam
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
1:01 PM (10 hours ago) 1:01 PM
to goph...@pubsubhelper.golang.org, Michael Pratt, golang-co...@googlegroups.com
Michael Pratt has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.27] encoding/json/jsontext: clarify safety of AvailableBuffer
The current wording makes it sound like the buffer itself is unsafe, but
this is just trying to warn that manually constructing a Value is
error-prone.
For #71497.
Change-Id: I12ab3ea4e858860f8a241c514a883d376a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/811780
Reviewed-by: Jonathan Amsterdam <j...@google.com>
Reviewed-by: Damien Neil <dn...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 35a7a64d0fef48dadd0af07c1f8e6f46ec770bc0)
Change diff
diff --git a/src/encoding/json/jsontext/encode.go b/src/encoding/json/jsontext/encode.go
index 116e150..047b00a 100644
--- a/src/encoding/json/jsontext/encode.go
+++ b/src/encoding/json/jsontext/encode.go
@@ -913,9 +913,9 @@
// b = append(b, '"')
// ... := e.WriteValue(b)
//
-// WriteValue expects a JSON value. Using AvailableBuffer to manually construct
-// a value requires caution to avoid producing an invalid JSON value that would
-// then cause WriteValue to fail.
+// Note that WriteValue expects a valid JSON value. Constructing a value in a
+// raw []byte requires more care than using constructor functions like
+// [String], which always return valid [Token]s or [Value]s.
func (e *Encoder) AvailableBuffer() []byte {
// NOTE: We don't return e.Buf[len(e.Buf):cap(e.Buf)] since WriteValue would
// need to take special care to avoid mangling the data while reformatting.
Change information
Files:
- M src/encoding/json/jsontext/encode.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
1:02 PM (10 hours ago) 1:02 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, Jonathan Amsterdam, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil and Jonathan Amsterdam
Michael Pratt voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Damien Neil
- Jonathan Amsterdam
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages