[go] net/http: restore accidentally removed package doc

4 views
Skip to first unread message

Damien Neil (Gerrit)

unread,
Mar 4, 2026, 4:24:21 PMMar 4
to goph...@pubsubhelper.golang.org, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Nicholas Husin

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Nicholas Husin
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964
Gerrit-Change-Number: 751520
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Nicholas Husin <n...@golang.org>
Gerrit-Comment-Date: Wed, 04 Mar 2026 21:24:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
Mar 4, 2026, 4:25:02 PMMar 4
to Damien Neil, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Damien Neil

Nicholas Husin voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964
Gerrit-Change-Number: 751520
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Wed, 04 Mar 2026 21:24:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
Mar 4, 2026, 4:25:06 PMMar 4
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Damien Neil

Nicholas Husin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964
    Gerrit-Change-Number: 751520
    Gerrit-PatchSet: 1
    Gerrit-Owner: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Nicholas Husin <hu...@google.com>
    Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
    Gerrit-Attention: Damien Neil <dn...@google.com>
    Gerrit-Comment-Date: Wed, 04 Mar 2026 21:25:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Damien Neil (Gerrit)

    unread,
    Mar 4, 2026, 4:30:10 PMMar 4
    to goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com

    Damien Neil voted

    Auto-Submit+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964
    Gerrit-Change-Number: 751520
    Gerrit-PatchSet: 1
    Gerrit-Owner: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Nicholas Husin <hu...@google.com>
    Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
    Gerrit-Comment-Date: Wed, 04 Mar 2026 21:30:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Damien Neil (Gerrit)

    unread,
    Mar 4, 2026, 4:30:49 PMMar 4
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

    Damien Neil has uploaded the change for review

    Commit message

    [release-branch.go1.26] net/http: restore accidentally removed package doc

    Remove a blank line which accidentally crept in between
    the package doc comment and the package line.

    For #77948
    Fixes #77950
    Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964

    Change diff

    diff --git a/src/net/http/doc.go b/src/net/http/doc.go
    index 24e0735..e50cf5f 100644
    --- a/src/net/http/doc.go
    +++ b/src/net/http/doc.go
    @@ -105,5 +105,4 @@
     The "omithttp2" build tag may be used to disable the HTTP/2 implementation
     contained in the http package.
     */
    -
     package http

    Change information

    Files:
    • M src/net/http/doc.go
    Change size: XS
    Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newchange
    Gerrit-Project: go
    Gerrit-Branch: release-branch.go1.26
    Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964
    Gerrit-Change-Number: 751463
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Damien Neil (Gerrit)

    unread,
    Mar 4, 2026, 4:39:14 PMMar 4
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

    Damien Neil voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: release-branch.go1.26
    Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964
    Gerrit-Change-Number: 751463
    Gerrit-PatchSet: 1
    Gerrit-Owner: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Comment-Date: Wed, 04 Mar 2026 21:39:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    Mar 4, 2026, 4:48:45 PMMar 4
    to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com

    Gopher Robot submitted the change

    Change information

    Commit message:
    net/http: restore accidentally removed package doc

    Remove a blank line which accidentally crept in between
    the package doc comment and the package line.

    Fixes #77948
    Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964
    Auto-Submit: Damien Neil <dn...@google.com>
    Reviewed-by: Nicholas Husin <hu...@google.com>
    Reviewed-by: Nicholas Husin <n...@golang.org>
    Files:
    • M src/net/http/doc.go
    Change size: XS
    Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nicholas Husin, +2 by Nicholas Husin
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: master 
    

     Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964 
    

     Gerrit-Change-Number: 751520 
    

     Gerrit-PatchSet: 2 
    

     Gerrit-Owner: Damien Neil <dn...@google.com> 
    

     Gerrit-Reviewer: Damien Neil <dn...@google.com> 
    

    

     Gerrit-Reviewer: Gopher Robot <go...@golang.org> 
    open
    diffy
    satisfied_requirement
    Cherry Mui (Gerrit)
    unread,
    Mar 9, 2026, 8:35:29 PM (10 days ago) Mar 9
    to Damien Neil, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Damien Neil
    Cherry Mui voted Code-Review+2
    Code-Review+2
    Open in Gerrit
    Related details
    Attention is currently required from:
    • Damien Neil
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: comment 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: release-branch.go1.26 
    

     Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964 
    

     Gerrit-Change-Number: 751463 
    

     Gerrit-PatchSet: 1 
    

     Gerrit-Owner: Damien Neil <dn...@google.com> 
    

     Gerrit-Reviewer: Cherry Mui <cher...@google.com> 
    

     Gerrit-Reviewer: Damien Neil <dn...@google.com> 
    


     Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org> 
    

     Gerrit-CC: Gopher Robot <go...@golang.org> 
    

     Gerrit-CC: Russ Cox <r...@golang.org> 
    

     Gerrit-Attention: Damien Neil <dn...@google.com> 
    

     Gerrit-Comment-Date: Tue, 10 Mar 2026 00:35:26 +0000 
    

     Gerrit-HasComments: No 
    

     Gerrit-Has-Labels: Yes 
    


    satisfied_requirement
    open
    diffy
    Damien Neil (Gerrit)
    unread,
    Mar 10, 2026, 1:54:37 PM (9 days ago) Mar 10
    to goph...@pubsubhelper.golang.org, Cherry Mui, Dmitri Shuralyov, Go LUCI, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
    Damien Neil voted Code-Review+2
    Code-Review+2
    Open in Gerrit
    Related details
    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: comment 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: release-branch.go1.26 
    

     Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964 
    

     Gerrit-Change-Number: 751463 
    

     Gerrit-PatchSet: 1 
    

     Gerrit-Owner: Damien Neil <dn...@google.com> 
    

     Gerrit-Reviewer: Cherry Mui <cher...@google.com> 
    

     Gerrit-Reviewer: Damien Neil <dn...@google.com> 
    


     Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org> 
    

     Gerrit-CC: Gopher Robot <go...@golang.org> 
    

     Gerrit-CC: Russ Cox <r...@golang.org> 
    

     Gerrit-Comment-Date: Tue, 10 Mar 2026 17:54:33 +0000 
    

     Gerrit-HasComments: No 
    

     Gerrit-Has-Labels: Yes 
    


    satisfied_requirement
    open
    diffy
    Carlos Amedee (Gerrit)
    unread,
    5:03 PM (2 hours ago) 5:03 PM
    to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Dmitri Shuralyov, Go LUCI, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
    Carlos Amedee submitted the change
    Change information
    Commit message:
    [release-branch.go1.26] net/http: restore accidentally removed package doc


    Remove a blank line which accidentally crept in between
    the package doc comment and the package line.

    For #77948
    Fixes #77950
    Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964
    Reviewed-by: Damien Neil <dn...@google.com>
    Reviewed-by: Cherry Mui <cher...@google.com>
    Files:
    • M src/net/http/doc.go
    Change size: XS
    Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
    Branch: refs/heads/release-branch.go1.26
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Cherry Mui, +2 by Damien Neil
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: release-branch.go1.26 
    

     Gerrit-Change-Id: I6b513c1e9ea97d2a4b3c6f7b9b10092a6a6a6964 
    

     Gerrit-Change-Number: 751463 
    

     Gerrit-PatchSet: 2 
    

     Gerrit-Owner: Damien Neil <dn...@google.com> 
    

     Gerrit-Reviewer: Carlos Amedee <car...@golang.org> 
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages