[go] all: use the built-in min/max function
shuang cui (Gerrit)
shuang cui has uploaded this change for review.
all: use the built-in min/max function
Go1.21 uses min and max as built-in functions, which can be used directly without additional definitions
Change-Id: I26be9a9faa27c6c03cf8b9dec5908d8617d61312
---
M src/cmd/dist/util.go
M src/internal/fuzz/mutator.go
M src/strconv/ftoa.go
3 files changed, 0 insertions(+), 28 deletions(-)
diff --git a/src/cmd/dist/util.go b/src/cmd/dist/util.go
index 2eeab18..4d5e358 100644
--- a/src/cmd/dist/util.go
+++ b/src/cmd/dist/util.go
@@ -405,13 +405,6 @@
return "7"
}
-func min(a, b int) int {
- if a < b {
- return a
- }
- return b
-}
-
// elfIsLittleEndian detects if the ELF file is little endian.
func elfIsLittleEndian(fn string) bool {
// read the ELF file header to determine the endianness without using the
diff --git a/src/internal/fuzz/mutator.go b/src/internal/fuzz/mutator.go
index bb96066..4310d57 100644
--- a/src/internal/fuzz/mutator.go
+++ b/src/internal/fuzz/mutator.go
@@ -44,13 +44,6 @@
}
}
-func min(a, b int) int {
- if a < b {
- return a
- }
- return b
-}
-
// mutate performs several mutations on the provided values.
func (m *mutator) mutate(vals []any, maxBytes int) {
// TODO(katiehockman): pull some of these functions into helper methods and
diff --git a/src/strconv/ftoa.go b/src/strconv/ftoa.go
index fcbf4df..c514e66 100644
--- a/src/strconv/ftoa.go
+++ b/src/strconv/ftoa.go
@@ -568,17 +568,3 @@
return dst
}
-
-func min(a, b int) int {
- if a < b {
- return a
- }
- return b
-}
-
-func max(a, b int) int {
- if a > b {
- return a
- }
- return b
-}
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Robert Griesemer, Roland Shoemaker, Russ Cox.
shuang cui uploaded patch set #2 to this change.
all: use the built-in min/max function
Go1.21 uses min and max as built-in functions, which can be used directly without additional definitions
Change-Id: I26be9a9faa27c6c03cf8b9dec5908d8617d61312
---
M src/cmd/dist/util.go
M src/internal/fuzz/mutator.go
2 files changed, 0 insertions(+), 14 deletions(-)
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Robert Griesemer, Roland Shoemaker, Russ Cox.
Patch set 2:Run-TryBot +1
Ian Lance Taylor (Gerrit)
Attention is currently required from: Robert Griesemer, Roland Shoemaker, Russ Cox, shuang cui.
1 comment:
Patchset:
cmd/dist has to build with the bootstrap compiler, which doesn't support min and max as predeclared functions.
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Robert Griesemer, Roland Shoemaker, Russ Cox, shuang cui.
shuang cui uploaded patch set #3 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by shuang cui, TryBot-Result-1 by Gopher Robot
all: use the built-in min/max function
Go1.21 uses min and max as built-in functions, which can be used directly without additional definitions
Change-Id: I26be9a9faa27c6c03cf8b9dec5908d8617d61312
---
M src/internal/fuzz/mutator.go
1 file changed, 0 insertions(+), 7 deletions(-)
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Robert Griesemer, Roland Shoemaker, Russ Cox, shuang cui.
shuang cui uploaded patch set #4 to this change.
internal/fuzz: use the built-in min/max function
Go1.21 uses min and max as built-in functions, which can be used directly without additional definitions
Change-Id: I26be9a9faa27c6c03cf8b9dec5908d8617d61312
---
M src/internal/fuzz/mutator.go
1 file changed, 0 insertions(+), 7 deletions(-)
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Ian Lance Taylor, Robert Griesemer, Roland Shoemaker, Russ Cox.
Patch set 4:Run-TryBot +1
2 comments:
Patchset:
cmd/dist has to build with the bootstrap compiler, which doesn't support min and max as predeclared […]
Thanks your guidance.
45 of 45 TryBots failed. […]
Done
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Ian Lance Taylor, Robert Griesemer, Roland Shoemaker, Russ Cox.
shuang cui uploaded patch set #5 to this change.
internal/fuzz: use the built-in min function
Go1.21 uses min as built-in functions, which can be used directly without additional definitions
Change-Id: I26be9a9faa27c6c03cf8b9dec5908d8617d61312
---
M src/internal/fuzz/mutator.go
1 file changed, 0 insertions(+), 7 deletions(-)
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
qiulaidongfeng (Gerrit)
Attention is currently required from: Ian Lance Taylor, Robert Griesemer, Roland Shoemaker, Russ Cox, shuang cui.
Patch set 5:Code-Review +1
Gerrit Bot (Gerrit)
Gerrit Bot has uploaded this change for review.
all: use the built-in min/max function
This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.
**Please ensure you adhere to every item in this list.**
More info can be found at https://github.com/golang/go/wiki/CommitMessage
+ The PR title is formatted as follows: `net/http: frob the quux before blarfing`
+ The package name goes before the colon
+ The part after the colon uses the verb tense + phrase that completes the blank in,
"This change modifies Go to ___________"
+ Lowercase verb after the colon
+ No trailing period
+ Keep the title as short as possible. ideally under 76 characters or shorter
+ No Markdown
+ The first PR comment (this one) is wrapped at 76 characters, unless it's
really needed (ASCII art, table, or long link)
+ If there is a corresponding issue, add either `Fixes #1234` or `Updates #1234`
(the latter if this is not a complete fix) to this comment
+ If referring to a repo other than `golang/go` you can use the
`owner/repo#issue_number` syntax: `Fixes golang/tools#1234`
+ We do not use Signed-off-by lines in Go. Please don't add them.
Our Gerrit server & GitHub bots enforce CLA compliance instead.
+ Delete these instructions once you have read and applied them
Change-Id: I71a38dd20bfaf2b1aed18892d54eeb017d3d7d66
GitHub-Last-Rev: 8d014c2ad350c237a135054a6a4e120ea6453be7
GitHub-Pull-Request: golang/go#61955
---
M src/cmd/compile/internal/abt/avlint32.go
M src/cmd/compile/internal/ssa/rewrite.go
M src/cmd/dist/util.go
M src/go/doc/testdata/benchmark.go
M src/internal/fuzz/mutator.go
M src/math/big/nat.go
M src/math/rand/rand_test.go
7 files changed, 0 insertions(+), 56 deletions(-)
diff --git a/src/cmd/compile/internal/abt/avlint32.go b/src/cmd/compile/internal/abt/avlint32.go
index 28c1642..ddfca34 100644
--- a/src/cmd/compile/internal/abt/avlint32.go
+++ b/src/cmd/compile/internal/abt/avlint32.go
@@ -819,13 +819,6 @@
return left
}
-func max(a, b int8) int8 {
- if a > b {
- return a
- }
- return b
-}
-
func (t *node32) copy() *node32 {
u := *t
return &u
diff --git a/src/cmd/compile/internal/ssa/rewrite.go b/src/cmd/compile/internal/ssa/rewrite.go
index 6ee661d..aeb0d17 100644
--- a/src/cmd/compile/internal/ssa/rewrite.go
+++ b/src/cmd/compile/internal/ssa/rewrite.go
@@ -1177,13 +1177,6 @@
var ruleFile io.Writer
-func min(x, y int64) int64 {
- if x < y {
- return x
- }
- return y
-}
-
func isConstZero(v *Value) bool {
switch v.Op {
case OpConstNil:
diff --git a/src/cmd/dist/util.go b/src/cmd/dist/util.go
index 2eeab18..4d5e358 100644
--- a/src/cmd/dist/util.go
+++ b/src/cmd/dist/util.go
@@ -405,13 +405,6 @@
return "7"
}
-func min(a, b int) int {
- if a < b {
- return a
- }
- return b
-}
-
// elfIsLittleEndian detects if the ELF file is little endian.
func elfIsLittleEndian(fn string) bool {
// read the ELF file header to determine the endianness without using the
diff --git a/src/go/doc/testdata/benchmark.go b/src/go/doc/testdata/benchmark.go
index dbf6b4f..b3732f2 100644
--- a/src/go/doc/testdata/benchmark.go
+++ b/src/go/doc/testdata/benchmark.go
@@ -85,20 +85,6 @@
b.StopTimer()
}
-func min(x, y int) int {
- if x > y {
- return y
- }
- return x
-}
-
-func max(x, y int) int {
- if x < y {
- return y
- }
- return x
-}
-
// roundDown10 rounds a number down to the nearest power of 10.
func roundDown10(n int) int {
var tens = 0
diff --git a/src/internal/fuzz/mutator.go b/src/internal/fuzz/mutator.go
index bb96066..4310d57 100644
--- a/src/internal/fuzz/mutator.go
+++ b/src/internal/fuzz/mutator.go
@@ -44,13 +44,6 @@
}
}
-func min(a, b int) int {
- if a < b {
- return a
- }
- return b
-}
-
// mutate performs several mutations on the provided values.
func (m *mutator) mutate(vals []any, maxBytes int) {
// TODO(katiehockman): pull some of these functions into helper methods and
diff --git a/src/math/big/nat.go b/src/math/big/nat.go
index 90ce6d1..b9f4026 100644
--- a/src/math/big/nat.go
+++ b/src/math/big/nat.go
@@ -389,13 +389,6 @@
}
}
-func max(x, y int) int {
- if x > y {
- return x
- }
- return y
-}
-
// karatsubaLen computes an approximation to the maximum k <= n such that
// k = p<<i for a number p <= threshold and an i >= 0. Thus, the
// result is the largest number that can be divided repeatedly by 2 before
diff --git a/src/math/rand/rand_test.go b/src/math/rand/rand_test.go
index 7eba1dc..4ad2ae2 100644
--- a/src/math/rand/rand_test.go
+++ b/src/math/rand/rand_test.go
@@ -33,13 +33,6 @@
maxError float64
}
-func max(a, b float64) float64 {
- if a > b {
- return a
- }
- return b
-}
-
func nearEqual(a, b, closeEnough, maxError float64) bool {
absDiff := math.Abs(a - b)
if absDiff < closeEnough { // Necessary when one value is zero and one value is close to zero.
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Robert Griesemer, Roland Shoemaker, Russ Cox, shuang cui.
1 comment:
Commit Message:
Patch Set #5, Line 9:
Go1.21 uses min as built-in functions, which can be used directly without additional definitionsYou can just remove this paragraph. The topic is enough. Thanks.
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Keith Randall, Robert Griesemer, Roland Shoemaker.
2 comments:
Patchset:
Please run all.bash with your changes. I think you'll find some errors.
Commit Message:
Patch Set #1, Line 9:
This PR will be imported into Gerrit with the title and firstPlease read and follow these instructions. Thanks.
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Mauri de Souza Meneguzzo (Gerrit)
Attention is currently required from: Keith Randall, Robert Griesemer, Roland Shoemaker.
1 comment:
File src/cmd/dist/util.go:
Patch Set #1, Line 408:
func min(a, b int) int {I'm quite sure this won't bootstrap. You might be able to get rid of some of the min/max functions that are not directly involved in bootstrapping tho. I think you will have better luck removing one function at a time and then running all.bash, if you get a failure then revert the change.
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Robert Griesemer, Roland Shoemaker, Russ Cox, shuang cui.
shuang cui uploaded patch set #6 to this change.
internal/fuzz: use the built-in min function
Change-Id: I26be9a9faa27c6c03cf8b9dec5908d8617d61312
---
M src/internal/fuzz/mutator.go
1 file changed, 0 insertions(+), 7 deletions(-)
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Ian Lance Taylor, Robert Griesemer, Roland Shoemaker, Russ Cox.
Patch set 6:Run-TryBot +1
1 comment:
Commit Message:
Patch Set #5, Line 9:
Go1.21 uses min as built-in functions, which can be used directly without additional definitionsYou can just remove this paragraph. The topic is enough. Thanks.
Done. Thanks
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Ian Lance Taylor, Robert Griesemer, Roland Shoemaker, Russ Cox.
Patch Set #5, Line 9:
Go1.21 uses min as built-in functions, which can be used directly without additional definitions
Done. […]
Done
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Ian Lance Taylor, Robert Griesemer, Roland Shoemaker, Russ Cox, shuang cui.
Patch set 6:Run-TryBot +1Auto-Submit +1Code-Review +2
1 comment:
Patchset:
Thanks.
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Ian Lance Taylor, Robert Griesemer, Roland Shoemaker, Russ Cox, shuang cui.
Patch set 6:Code-Review +1
Gopher Robot (Gerrit)
Gopher Robot submitted this change.
internal/fuzz: use the built-in min function
Change-Id: I26be9a9faa27c6c03cf8b9dec5908d8617d61312
Reviewed-on: https://go-review.googlesource.com/c/go/+/518276
Run-TryBot: shuang cui <imc...@gmail.com>
Reviewed-by: qiulaidongfeng <26454...@qq.com>
Reviewed-by: Ian Lance Taylor <ia...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
Auto-Submit: Ian Lance Taylor <ia...@google.com>
Run-TryBot: Ian Lance Taylor <ia...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
---
M src/internal/fuzz/mutator.go
1 file changed, 0 insertions(+), 7 deletions(-)
diff --git a/src/internal/fuzz/mutator.go b/src/internal/fuzz/mutator.go
index bb96066..4310d57 100644
--- a/src/internal/fuzz/mutator.go
+++ b/src/internal/fuzz/mutator.go
@@ -44,13 +44,6 @@
}
}
-func min(a, b int) int {
- if a < b {
- return a
- }
- return b
-}
-
// mutate performs several mutations on the provided values.
func (m *mutator) mutate(vals []any, maxBytes int) {
// TODO(katiehockman): pull some of these functions into helper methods and
To view, visit change 518276. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Keith Randall, Robert Griesemer, Roland Shoemaker.
This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.
**Please ensure you adhere to every item in this list.**
More info can be found at https://github.com/golang/go/wiki/CommitMessage
+ The PR title is formatted as follows: `net/http: frob the quux before blarfing`
+ The package name goes before the colon
+ The part after the colon uses the verb tense + phrase that completes the blank in,
"This change modifies Go to ___________"
+ Lowercase verb after the colon
+ No trailing period
+ Keep the title as short as possible. ideally under 76 characters or shorter
+ No Markdown
+ The first PR comment (this one) is wrapped at 76 characters, unless it's
really needed (ASCII art, table, or long link)
+ If there is a corresponding issue, add either `Fixes #1234` or `Updates #1234`
(the latter if this is not a complete fix) to this comment
+ If referring to a repo other than `golang/go` you can use the
`owner/repo#issue_number` syntax: `Fixes golang/tools#1234`
+ We do not use Signed-off-by lines in Go. Please don't add them.
Our Gerrit server & GitHub bots enforce CLA compliance instead.
+ Delete these instructions once you have read and applied them
Change-Id: I71a38dd20bfaf2b1aed18892d54eeb017d3d7d66
GitHub-Last-Rev: d3fed409da91a0beaddd7431ac02dedfe4e5b26d
GitHub-Pull-Request: golang/go#61955
---
M src/math/big/nat.go
M src/math/rand/rand_test.go
2 files changed, 0 insertions(+), 14 deletions(-)
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
产学红 (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
3 comments:
Patchset:
Please run all.bash with your changes. I think you'll find some errors.
Yes, I have found it, thank you.
Commit Message:
Patch Set #1, Line 9:
This PR will be imported into Gerrit with the title and firstPlease read and follow these instructions. Thanks.
Sorry, I just saw this today and it has been resolved
File src/cmd/dist/util.go:
Patch Set #1, Line 408:
func min(a, b int) int {
I'm quite sure this won't bootstrap. […]
Thanks for your advice!
I have modified it, please review it again.
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
Gerrit Bot uploaded patch set #3 to this change.
math/big+math/rand: use the built-in min/max function
Change-Id: I71a38dd20bfaf2b1aed18892d54eeb017d3d7d66
GitHub-Last-Rev: bc9b816678e1e192e0ff1328c02ec4a509a908ff
GitHub-Pull-Request: golang/go#61955
---
M src/math/big/nat.go
M src/math/rand/rand_test.go
2 files changed, 0 insertions(+), 14 deletions(-)
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
Patch set 3:Run-TryBot +1
1 comment:
Commit Message:
Patch Set #3, Line 7:
math/big+math/rand: use the built-in min/max functionUse a comma:
math/big, math/rand: use the built-in min/max function
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
Gerrit Bot uploaded patch set #4 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Ian Lance Taylor, TryBot-Result+1 by Gopher Robot
math/big+math/rand: use the built-in min/max function
Change-Id: I71a38dd20bfaf2b1aed18892d54eeb017d3d7d66
GitHub-Last-Rev: ec25534727837d31b5c234da5377e987580c1f0f
GitHub-Pull-Request: golang/go#61955
---
M src/math/big/nat.go
M src/math/rand/rand_test.go
2 files changed, 0 insertions(+), 14 deletions(-)
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
Gerrit Bot uploaded patch set #5 to this change.
math/big, math/rand: use the built-in min/max function
Change-Id: I71a38dd20bfaf2b1aed18892d54eeb017d3d7d66
GitHub-Last-Rev: ec25534727837d31b5c234da5377e987580c1f0f
GitHub-Pull-Request: golang/go#61955
---
M src/math/big/nat.go
M src/math/rand/rand_test.go
2 files changed, 0 insertions(+), 14 deletions(-)
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
产学红 (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
1 comment:
Commit Message:
Patch Set #3, Line 7:
math/big+math/rand: use the built-in min/max functionUse a comma: […]
DONE
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
qiulaidongfeng (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
1 comment:
Commit Message:
Patch Set #5, Line 7:
math/big, math/rand: use the built-in min/max functionThis CL only changes max to use built-in functions.
Please change the submission information to: math/bigs, math/rand: use the build in max function.
Thanks.
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
Gerrit Bot uploaded patch set #6 to this change.
math/big, math/rand: use the built-in max function
Change-Id: I71a38dd20bfaf2b1aed18892d54eeb017d3d7d66
GitHub-Last-Rev: 8da43b2cbd563ed123690709e519c9f84272b332
GitHub-Pull-Request: golang/go#61955
---
M src/math/big/nat.go
M src/math/rand/rand_test.go
2 files changed, 0 insertions(+), 14 deletions(-)
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
产学红 (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker, qiulaidongfeng.
1 comment:
Commit Message:
Patch Set #5, Line 7:
math/big, math/rand: use the built-in min/max function
This CL only changes max to use built-in functions. […]
Done
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
qiulaidongfeng (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
Patch set 6:Run-TryBot +1Auto-Submit +1Code-Review +2
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Ian Lance Taylor, Keith Randall, Mauri de Souza Meneguzzo, Robert Griesemer, Roland Shoemaker.
Patch set 6:Code-Review +1
Gopher Robot (Gerrit)
Gopher Robot submitted this change.
math/big, math/rand: use the built-in max function
Change-Id: I71a38dd20bfaf2b1aed18892d54eeb017d3d7d66
GitHub-Last-Rev: 8da43b2cbd563ed123690709e519c9f84272b332
GitHub-Pull-Request: golang/go#61955
Reviewed-on: https://go-review.googlesource.com/c/go/+/518595
Run-TryBot: Ian Lance Taylor <ia...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
Auto-Submit: Ian Lance Taylor <ia...@google.com>
Reviewed-by: Ian Lance Taylor <ia...@google.com>
Reviewed-by: qiulaidongfeng <26454...@qq.com>
---
M src/math/big/nat.go
M src/math/rand/rand_test.go
2 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/src/math/big/nat.go b/src/math/big/nat.go
index 90ce6d1..b9f4026 100644
--- a/src/math/big/nat.go
+++ b/src/math/big/nat.go
@@ -389,13 +389,6 @@
}
}
-func max(x, y int) int {
- if x > y {
- return x
- }
- return y
-}
-
// karatsubaLen computes an approximation to the maximum k <= n such that
// k = p<<i for a number p <= threshold and an i >= 0. Thus, the
// result is the largest number that can be divided repeatedly by 2 before
diff --git a/src/math/rand/rand_test.go b/src/math/rand/rand_test.go
index 7eba1dc..4ad2ae2 100644
--- a/src/math/rand/rand_test.go
+++ b/src/math/rand/rand_test.go
@@ -33,13 +33,6 @@
maxError float64
}
-func max(a, b float64) float64 {
- if a > b {
- return a
- }
- return b
-}
-
func nearEqual(a, b, closeEnough, maxError float64) bool {
absDiff := math.Abs(a - b)
if absDiff < closeEnough { // Necessary when one value is zero and one value is close to zero.
To view, visit change 518595. To unsubscribe, or for help writing mail filters, visit settings.