[go] cmd/go/internal/base: reject an empty tool name
15 views
Skip to first unread message
Olivier Mengué (Gerrit)
Jul 25, 2025, 4:44:31 AM7/25/25
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Olivier Mengué has uploaded the change for review![]( "Open in Gerrit")
Commit message
cmd/go/internal/base: reject an empty tool name
An empty tool name ("") is incorrectly resolved as the directory
containing the tools binaries:
$ go tool ""
go tool : fork/exec /opt/homebrew/Cellar/go/1.24.5/libexec/pkg/tool/darwin_arm64: permission denied
To fix that case we also explicitely disallow an empty tool name in the
validToolName func.
Fixes #74757.
Change-Id: I6dd14096526c9113cef8e4d16a5aaa2120410b08
Change diff
diff --git a/src/cmd/go/internal/base/tool.go b/src/cmd/go/internal/base/tool.go
index f2fc0ff..dc35ca2 100644
--- a/src/cmd/go/internal/base/tool.go
+++ b/src/cmd/go/internal/base/tool.go
@@ -42,6 +42,9 @@
}
func ValidToolName(toolName string) bool {
+ if toolName == "" {
+ return false
+ }
for _, c := range toolName {
switch {
case 'a' <= c && c <= 'z', '0' <= c && c <= '9', c == '_':
Change information
Files:
- M src/cmd/go/internal/base/tool.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
qiu laidongfeng (Gerrit)
Jul 25, 2025, 10:07:19 AM7/25/25
to Olivier Mengué, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Olivier Mengué
qiu laidongfeng voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Jul 26, 2025, 7:28:20 AM7/26/25
to Olivier Mengué, goph...@pubsubhelper.golang.org, Go LUCI, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué and qiu laidongfeng
Sean Liao added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Mengué
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Mengué (Gerrit)
Jul 26, 2025, 6:55:17 PM7/26/25
to goph...@pubsubhelper.golang.org, Go LUCI, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Sean Liao and qiu laidongfeng
Olivier Mengué added 1 comment![]( "Open in Gerrit")
Patchset-level comments
this should have a test as well
Attention is currently required from:
- Sean Liao
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Mengué (Gerrit)
Jul 27, 2025, 8:17:04 AM7/27/25
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Sean Liao and qiu laidongfeng
Olivier Mengué uploaded new patchset![]( "Open in Gerrit")
Olivier Mengué uploaded patch set #3 to this change.
Related details
Attention is currently required from:
- Sean Liao
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Mengué (Gerrit)
Jul 27, 2025, 8:20:07 AM7/27/25
to goph...@pubsubhelper.golang.org, Go LUCI, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Sean Liao and qiu laidongfeng
Olivier Mengué added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sean Liao . resolved
Olivier Menguéthis should have a test as well
Acknowledged
Olivier Mengué
New tests added for "go tool":
```
go test cmd/go -v -run=Script/^tool_name$
```
Related details
Attention is currently required from:
- Sean Liao
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
t hepudds (Gerrit)
Jul 27, 2025, 10:02:46 AM7/27/25
to Olivier Mengué, goph...@pubsubhelper.golang.org, Go LUCI, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué, Sean Liao and qiu laidongfeng
t hepudds voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Mengué
- Sean Liao
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
t hepudds (Gerrit)
Jul 27, 2025, 11:48:27 AM7/27/25
to Olivier Mengué, goph...@pubsubhelper.golang.org, Go LUCI, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué, Sean Liao and qiu laidongfeng
t hepudds added 1 comment![]( "Open in Gerrit")
File src/cmd/go/testdata/script/tool_name.txt
Line 1, Patchset 3 (Latest):
# Tool name can't be empty. Issue #74757.t hepudds . unresolved
It's probably OK to create a new testscript file if needed, but it might be better to see if these checks fit in an existing file. I didn't look too hard, but for example, the existing tool_exename.txt has some checks like:
```
# Don't use v2 as the short name of the tool.
! go tool v2
stderr 'go: no such tool "v2"'
```
So you could consider instead adding your new tests to the end of the existing checks in tool_exename.txt for example, or looking to see if there is a better fit in another file.
Related details
Attention is currently required from:
- Olivier Mengué
- Sean Liao
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Mengué (Gerrit)
Jul 29, 2025, 3:31:58 AM7/29/25
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Olivier Mengué, Sean Liao and qiu laidongfeng
Olivier Mengué uploaded new patchset![]( "Open in Gerrit")
Olivier Mengué uploaded patch set #4 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Related details
Attention is currently required from:
- Olivier Mengué
- Sean Liao
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Mengué (Gerrit)
Jul 29, 2025, 3:33:47 AM7/29/25
to goph...@pubsubhelper.golang.org, Go LUCI, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Sean Liao, qiu laidongfeng and t hepudds
Olivier Mengué added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Olivier Mengué . resolved
Tests moved to tool_exename.txt as suggested.
File src/cmd/go/testdata/script/tool_name.txt
It's probably OK to create a new testscript file if needed, but it might be better to see if these checks fit in an existing file. I didn't look too hard, but for example, the existing tool_exename.txt has some checks like:
```
# Don't use v2 as the short name of the tool.
! go tool v2
stderr 'go: no such tool "v2"'
```So you could consider instead adding your new tests to the end of the existing checks in tool_exename.txt for example, or looking to see if there is a better fit in another file.
Attention is currently required from:
- Sean Liao
- qiu laidongfeng
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
t hepudds (Gerrit)
Jul 29, 2025, 6:13:15 AM7/29/25
to Olivier Mengué, goph...@pubsubhelper.golang.org, Go LUCI, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué, Sean Liao and qiu laidongfeng
t hepudds voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Mengué
- Sean Liao
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 5, 2025, 2:48:07 PM8/5/25
to Olivier Mengué, goph...@pubsubhelper.golang.org, Go LUCI, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué, Sean Liao and qiu laidongfeng
Michael Matloob voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Matloob
| Code-Review | +2 |
# Tool name can't be empty. Issue #74757.
! go tool ''
stderr 'go: no such tool ""'
! go tool -n ''
stderr 'go: no such tool ""'
# Invalid tool name
! go tool @
stderr 'go: no such tool "@"'
! go tool -n @
stderr 'go: no such tool "@"'
Michael Matloob . unresolved
We're not checking for the name of the produced executable in these testcases. Perhaps we should put these cases in a different file?
Related details
Attention is currently required from:
- Olivier Mengué
- Sean Liao
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Mengué (Gerrit)
Sep 19, 2025, 9:42:44 AM9/19/25
to goph...@pubsubhelper.golang.org, Michael Matloob, Go LUCI, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Michael Matloob and qiu laidongfeng
Olivier Mengué added 1 comment![]( "Open in Gerrit")
File src/cmd/go/testdata/script/tool_exename.txt
Line 40, Patchset 4 (Latest):
# Tool name can't be empty. Issue #74757.
! go tool ''
stderr 'go: no such tool ""'
! go tool -n ''
stderr 'go: no such tool ""'
# Invalid tool name
! go tool @
stderr 'go: no such tool "@"'
! go tool -n @
stderr 'go: no such tool "@"'
Michael Matloob . unresolved
We're not checking for the name of the produced executable in these testcases. Perhaps we should put these cases in a different file?
Olivier Mengué
In "tool_exename.txt", "exename" refers to the name of the tool to execute. Any suggestion for a better name for the test file?
Related details
Attention is currently required from:
- Michael Matloob
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Mar 16, 2026, 12:48:38 PM (2 days ago) Mar 16
to Olivier Mengué, goph...@pubsubhelper.golang.org, Go LUCI, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué and qiu laidongfeng
Michael Matloob added 1 comment![]( "Open in Gerrit")
File src/cmd/go/testdata/script/tool_exename.txt
Line 40, Patchset 4 (Latest):
# Tool name can't be empty. Issue #74757.
! go tool ''
stderr 'go: no such tool ""'
! go tool -n ''
stderr 'go: no such tool ""'
# Invalid tool name
! go tool @
stderr 'go: no such tool "@"'
! go tool -n @
stderr 'go: no such tool "@"'
Michael Matloob . unresolved
Olivier MenguéWe're not checking for the name of the produced executable in these testcases. Perhaps we should put these cases in a different file?
In "tool_exename.txt", "exename" refers to the name of the tool to execute. Any suggestion for a better name for the test file?
Attention is currently required from:
- Olivier Mengué
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Mengué (Gerrit)
Mar 17, 2026, 7:00:45 PM (21 hours ago) Mar 17
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob, Olivier Mengué and qiu laidongfeng
Olivier Mengué uploaded new patchset![]( "Open in Gerrit")
Olivier Mengué uploaded patch set #5 to this change.
Following approvals got outdated and were removed:
- Code-Review: +2 by Michael Matloob
- TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Attention is currently required from:
- Michael Matloob
- Olivier Mengué
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Mengué (Gerrit)
Mar 17, 2026, 7:04:50 PM (21 hours ago) Mar 17
to goph...@pubsubhelper.golang.org, Michael Matloob, Go LUCI, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Michael Matloob and qiu laidongfeng
Olivier Mengué added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Olivier Mengué . resolved
Test script moved to tool_name.txt as proposed by Michael.
File src/cmd/go/testdata/script/tool_exename.txt
# Tool name can't be empty. Issue #74757.
! go tool ''
stderr 'go: no such tool ""'
! go tool -n ''
stderr 'go: no such tool ""'
# Invalid tool name
! go tool @
stderr 'go: no such tool "@"'
! go tool -n @
stderr 'go: no such tool "@"'
Michael Matloob . resolved
Olivier MenguéWe're not checking for the name of the produced executable in these testcases. Perhaps we should put these cases in a different file?
Michael MatloobIn "tool_exename.txt", "exename" refers to the name of the tool to execute. Any suggestion for a better name for the test file?
tool_name?
Attention is currently required from:
- Michael Matloob
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
10:26 AM (5 hours ago) 10:26 AM
to Olivier Mengué, goph...@pubsubhelper.golang.org, Go LUCI, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué and qiu laidongfeng
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Mengué
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
10:26 AM (5 hours ago) 10:26 AM
to Olivier Mengué, goph...@pubsubhelper.golang.org, Michael Matloob, Go LUCI, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué and qiu laidongfeng
Michael Matloob voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Olivier Mengué
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
10:26 AM (5 hours ago) 10:26 AM
to Olivier Mengué, goph...@pubsubhelper.golang.org, Michael Matloob, Go LUCI, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué and qiu laidongfeng
Michael Matloob voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Michael Matloob (Gerrit)
11:32 AM (4 hours ago) 11:32 AM
to Olivier Mengué, goph...@pubsubhelper.golang.org, Go LUCI, Michael Matloob, t hepudds, qiu laidongfeng, golang-co...@googlegroups.com
Attention needed from Olivier Mengué and qiu laidongfeng
Michael Matloob voted![]( "Open in Gerrit")
| Code-Review | +2 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Olivier Mengué
- qiu laidongfeng
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages