[go/dev.simd] [dev.simd] simd: remove stray "LoadSlice" from generated amd64 doc comment

1 view
Skip to first unread message

David Chase (Gerrit)

unread,
4:56 PM (6 hours ago) 4:56 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

David Chase has uploaded the change for review

Commit message

[dev.simd] simd: remove stray "LoadSlice" from generated amd64 doc comment
Change-Id: I6820f032a072cf1b8f8febeb433a7d561f3fe60d

Change diff

diff --git a/src/simd/archsimd/_gen/tmplgen/main.go b/src/simd/archsimd/_gen/tmplgen/main.go
index d6708eb..77bc742 100644
--- a/src/simd/archsimd/_gen/tmplgen/main.go
+++ b/src/simd/archsimd/_gen/tmplgen/main.go
@@ -561,7 +561,7 @@
 // Load{{.VType}}Part loads a {{.VType}} from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than {{.Count}} elements, the remaining elements of the vector are filled with zeroes.
-// If s has {{.Count}} or more elements, the function is equivalent to Load{{.VType}}Slice.
+// If s has {{.Count}} or more elements, the function is equivalent to Load{{.VType}}.
 func Load{{.VType}}Part(s []{{.Etype}}) ({{.VType}}, int) {
 	l := len(s)
 	if l >= {{.Count}} {
@@ -596,7 +596,7 @@
 // Load{{.VType}}Part loads a {{.VType}} from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than {{.Count}} elements, the remaining elements of the vector are filled with zeroes.
-// If s has {{.Count}} or more elements, the function is equivalent to Load{{.VType}}Slice.
+// If s has {{.Count}} or more elements, the function is equivalent to Load{{.VType}}.
 func Load{{.VType}}Part(s []{{.Etype}}) ({{.VType}}, int) {
 	l := len(s)
 	if l >= {{.Count}} {
@@ -631,7 +631,7 @@
 // Load{{.VType}}Part loads a {{.VType}} from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than {{.Count}} elements, the remaining elements of the vector are filled with zeroes.
-// If s has {{.Count}} or more elements, the function is equivalent to Load{{.VType}}Slice.
+// If s has {{.Count}} or more elements, the function is equivalent to Load{{.VType}}.
 func Load{{.VType}}Part(s []{{.Etype}}) ({{.VType}}, int) {
 	if len(s) == 0 {
 		var zero {{.VType}}
diff --git a/src/simd/archsimd/slice_gen_amd64.go b/src/simd/archsimd/slice_gen_amd64.go
index 60785d2..0d4e74d 100644
--- a/src/simd/archsimd/slice_gen_amd64.go
+++ b/src/simd/archsimd/slice_gen_amd64.go
@@ -369,7 +369,7 @@
 // LoadInt8x64Part loads a Int8x64 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 64 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 64 or more elements, the function is equivalent to LoadInt8x64Slice.
+// If s has 64 or more elements, the function is equivalent to LoadInt8x64.
 func LoadInt8x64Part(s []int8) (Int8x64, int) {
 	l := len(s)
 	if l >= 64 {
@@ -402,7 +402,7 @@
 // LoadInt16x32Part loads a Int16x32 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 32 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 32 or more elements, the function is equivalent to LoadInt16x32Slice.
+// If s has 32 or more elements, the function is equivalent to LoadInt16x32.
 func LoadInt16x32Part(s []int16) (Int16x32, int) {
 	l := len(s)
 	if l >= 32 {
@@ -435,7 +435,7 @@
 // LoadInt32x16Part loads a Int32x16 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 16 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 16 or more elements, the function is equivalent to LoadInt32x16Slice.
+// If s has 16 or more elements, the function is equivalent to LoadInt32x16.
 func LoadInt32x16Part(s []int32) (Int32x16, int) {
 	l := len(s)
 	if l >= 16 {
@@ -468,7 +468,7 @@
 // LoadInt64x8Part loads a Int64x8 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 8 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 8 or more elements, the function is equivalent to LoadInt64x8Slice.
+// If s has 8 or more elements, the function is equivalent to LoadInt64x8.
 func LoadInt64x8Part(s []int64) (Int64x8, int) {
 	l := len(s)
 	if l >= 8 {
@@ -501,7 +501,7 @@
 // LoadUint8x64Part loads a Uint8x64 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 64 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 64 or more elements, the function is equivalent to LoadUint8x64Slice.
+// If s has 64 or more elements, the function is equivalent to LoadUint8x64.
 func LoadUint8x64Part(s []uint8) (Uint8x64, int) {
 	l := len(s)
 	if l >= 64 {
@@ -534,7 +534,7 @@
 // LoadUint16x32Part loads a Uint16x32 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 32 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 32 or more elements, the function is equivalent to LoadUint16x32Slice.
+// If s has 32 or more elements, the function is equivalent to LoadUint16x32.
 func LoadUint16x32Part(s []uint16) (Uint16x32, int) {
 	l := len(s)
 	if l >= 32 {
@@ -567,7 +567,7 @@
 // LoadUint32x16Part loads a Uint32x16 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 16 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 16 or more elements, the function is equivalent to LoadUint32x16Slice.
+// If s has 16 or more elements, the function is equivalent to LoadUint32x16.
 func LoadUint32x16Part(s []uint32) (Uint32x16, int) {
 	l := len(s)
 	if l >= 16 {
@@ -600,7 +600,7 @@
 // LoadUint64x8Part loads a Uint64x8 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 8 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 8 or more elements, the function is equivalent to LoadUint64x8Slice.
+// If s has 8 or more elements, the function is equivalent to LoadUint64x8.
 func LoadUint64x8Part(s []uint64) (Uint64x8, int) {
 	l := len(s)
 	if l >= 8 {
@@ -633,7 +633,7 @@
 // LoadFloat32x16Part loads a Float32x16 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 16 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 16 or more elements, the function is equivalent to LoadFloat32x16Slice.
+// If s has 16 or more elements, the function is equivalent to LoadFloat32x16.
 func LoadFloat32x16Part(s []float32) (Float32x16, int) {
 	l := len(s)
 	if l >= 16 {
@@ -666,7 +666,7 @@
 // LoadFloat64x8Part loads a Float64x8 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 8 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 8 or more elements, the function is equivalent to LoadFloat64x8Slice.
+// If s has 8 or more elements, the function is equivalent to LoadFloat64x8.
 func LoadFloat64x8Part(s []float64) (Float64x8, int) {
 	l := len(s)
 	if l >= 8 {
@@ -699,7 +699,7 @@
 // LoadInt32x4Part loads a Int32x4 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 4 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 4 or more elements, the function is equivalent to LoadInt32x4Slice.
+// If s has 4 or more elements, the function is equivalent to LoadInt32x4.
 func LoadInt32x4Part(s []int32) (Int32x4, int) {
 	l := len(s)
 	if l >= 4 {
@@ -732,7 +732,7 @@
 // LoadInt64x2Part loads a Int64x2 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 2 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 2 or more elements, the function is equivalent to LoadInt64x2Slice.
+// If s has 2 or more elements, the function is equivalent to LoadInt64x2.
 func LoadInt64x2Part(s []int64) (Int64x2, int) {
 	l := len(s)
 	if l >= 2 {
@@ -765,7 +765,7 @@
 // LoadUint32x4Part loads a Uint32x4 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 4 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 4 or more elements, the function is equivalent to LoadUint32x4Slice.
+// If s has 4 or more elements, the function is equivalent to LoadUint32x4.
 func LoadUint32x4Part(s []uint32) (Uint32x4, int) {
 	l := len(s)
 	if l >= 4 {
@@ -798,7 +798,7 @@
 // LoadUint64x2Part loads a Uint64x2 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 2 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 2 or more elements, the function is equivalent to LoadUint64x2Slice.
+// If s has 2 or more elements, the function is equivalent to LoadUint64x2.
 func LoadUint64x2Part(s []uint64) (Uint64x2, int) {
 	l := len(s)
 	if l >= 2 {
@@ -831,7 +831,7 @@
 // LoadFloat32x4Part loads a Float32x4 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 4 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 4 or more elements, the function is equivalent to LoadFloat32x4Slice.
+// If s has 4 or more elements, the function is equivalent to LoadFloat32x4.
 func LoadFloat32x4Part(s []float32) (Float32x4, int) {
 	l := len(s)
 	if l >= 4 {
@@ -864,7 +864,7 @@
 // LoadFloat64x2Part loads a Float64x2 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 2 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 2 or more elements, the function is equivalent to LoadFloat64x2Slice.
+// If s has 2 or more elements, the function is equivalent to LoadFloat64x2.
 func LoadFloat64x2Part(s []float64) (Float64x2, int) {
 	l := len(s)
 	if l >= 2 {
@@ -897,7 +897,7 @@
 // LoadInt32x8Part loads a Int32x8 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 8 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 8 or more elements, the function is equivalent to LoadInt32x8Slice.
+// If s has 8 or more elements, the function is equivalent to LoadInt32x8.
 func LoadInt32x8Part(s []int32) (Int32x8, int) {
 	l := len(s)
 	if l >= 8 {
@@ -930,7 +930,7 @@
 // LoadInt64x4Part loads a Int64x4 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 4 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 4 or more elements, the function is equivalent to LoadInt64x4Slice.
+// If s has 4 or more elements, the function is equivalent to LoadInt64x4.
 func LoadInt64x4Part(s []int64) (Int64x4, int) {
 	l := len(s)
 	if l >= 4 {
@@ -963,7 +963,7 @@
 // LoadUint32x8Part loads a Uint32x8 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 8 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 8 or more elements, the function is equivalent to LoadUint32x8Slice.
+// If s has 8 or more elements, the function is equivalent to LoadUint32x8.
 func LoadUint32x8Part(s []uint32) (Uint32x8, int) {
 	l := len(s)
 	if l >= 8 {
@@ -996,7 +996,7 @@
 // LoadUint64x4Part loads a Uint64x4 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 4 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 4 or more elements, the function is equivalent to LoadUint64x4Slice.
+// If s has 4 or more elements, the function is equivalent to LoadUint64x4.
 func LoadUint64x4Part(s []uint64) (Uint64x4, int) {
 	l := len(s)
 	if l >= 4 {
@@ -1029,7 +1029,7 @@
 // LoadFloat32x8Part loads a Float32x8 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 8 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 8 or more elements, the function is equivalent to LoadFloat32x8Slice.
+// If s has 8 or more elements, the function is equivalent to LoadFloat32x8.
 func LoadFloat32x8Part(s []float32) (Float32x8, int) {
 	l := len(s)
 	if l >= 8 {
@@ -1062,7 +1062,7 @@
 // LoadFloat64x4Part loads a Float64x4 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 4 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 4 or more elements, the function is equivalent to LoadFloat64x4Slice.
+// If s has 4 or more elements, the function is equivalent to LoadFloat64x4.
 func LoadFloat64x4Part(s []float64) (Float64x4, int) {
 	l := len(s)
 	if l >= 4 {
@@ -1095,7 +1095,7 @@
 // LoadUint8x16Part loads a Uint8x16 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 16 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 16 or more elements, the function is equivalent to LoadUint8x16Slice.
+// If s has 16 or more elements, the function is equivalent to LoadUint8x16.
 func LoadUint8x16Part(s []uint8) (Uint8x16, int) {
 	if len(s) == 0 {
 		var zero Uint8x16
@@ -1120,7 +1120,7 @@
 // LoadUint16x8Part loads a Uint16x8 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 8 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 8 or more elements, the function is equivalent to LoadUint16x8Slice.
+// If s has 8 or more elements, the function is equivalent to LoadUint16x8.
 func LoadUint16x8Part(s []uint16) (Uint16x8, int) {
 	if len(s) == 0 {
 		var zero Uint16x8
@@ -1145,7 +1145,7 @@
 // LoadUint8x32Part loads a Uint8x32 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 32 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 32 or more elements, the function is equivalent to LoadUint8x32Slice.
+// If s has 32 or more elements, the function is equivalent to LoadUint8x32.
 func LoadUint8x32Part(s []uint8) (Uint8x32, int) {
 	if len(s) == 0 {
 		var zero Uint8x32
@@ -1170,7 +1170,7 @@
 // LoadUint16x16Part loads a Uint16x16 from the slice s, it returns the loaded vector and the
 // number of elements loaded.
 // If s has fewer than 16 elements, the remaining elements of the vector are filled with zeroes.
-// If s has 16 or more elements, the function is equivalent to LoadUint16x16Slice.
+// If s has 16 or more elements, the function is equivalent to LoadUint16x16.
 func LoadUint16x16Part(s []uint16) (Uint16x16, int) {
 	if len(s) == 0 {
 		var zero Uint16x16

Change information

Files:
  • M src/simd/archsimd/_gen/tmplgen/main.go
  • M src/simd/archsimd/slice_gen_amd64.go
Change size: M
Delta: 2 files changed, 29 insertions(+), 29 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: dev.simd
Gerrit-Change-Id: I6820f032a072cf1b8f8febeb433a7d561f3fe60d
Gerrit-Change-Number: 776962
Gerrit-PatchSet: 1
Gerrit-Owner: David Chase <drc...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
5:42 PM (5 hours ago) 5:42 PM
to goph...@pubsubhelper.golang.org, Junyang Shao, Cherry Mui, Alexander Musman, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Junyang Shao

David Chase voted and added 1 comment

Votes added by David Chase

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
David Chase . resolved

Inspired by alexander musman's comments on the WASM CL, I went looking for trouble, and found it (and fixed it).

Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Junyang Shao
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: dev.simd
Gerrit-Change-Id: I6820f032a072cf1b8f8febeb433a7d561f3fe60d
Gerrit-Change-Number: 776962
Gerrit-PatchSet: 1
Gerrit-Owner: David Chase <drc...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>
Gerrit-CC: Alexander Musman <alexande...@gmail.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: Junyang Shao <shaoj...@google.com>
Gerrit-Comment-Date: Mon, 11 May 2026 21:42:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages