[vscode-go] docs/contributing.md: discuss kokoro and how to use it
Hyang-Ah Hana Kim (Gerrit)
Hyang-Ah Hana Kim has uploaded this change for review.
docs/contributing.md: discuss kokoro and how to use it
Change-Id: I8248aef0b8acb6ca696525d2bc53b2e625f0490c
---
M docs/contributing.md
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/docs/contributing.md b/docs/contributing.md
index 354c4f9..8e2f13c 100644
--- a/docs/contributing.md
+++ b/docs/contributing.md
@@ -15,6 +15,7 @@
* [Test](#test)
* [Sideload](#sideload)
* [Mail your change for review](#mail-your-change-for-review)
+ * [Presubmit test in CI](#presubmit-test-in-ci)
## Before you start coding
@@ -187,7 +188,18 @@
Once you've sent out your change, a maintainer will take a look at your contribution within a few weeks. If you don't hear back, feel free to ping the issue or send a message to the [#vscode-dev] channel of the [Gophers Slack].
-<!-- TODO: Kokoro setup details -->
+### Presubmit Test in CI
+
+When you mail your CL or upload a new patch to an existing CL, *AND*
+you or a fellow contributor assigns the `Run-TryBot=1` label in Gerrit, the test command defined in
+`build/all.bash` will run by `Kokoro`, which is Jenkins-like Google infrastructure
+for running Dockerized tests. `Kokoro` will post the result as a comment, and add its `TryBot-Result`
+vote after each test run completes.
+
+To force a re-run of the Kokoro CI,
+ * Remove `TryBot-Result` vote (hover over the label, and click the trashcan icon).
+ * Reply in Gerrit with the comment "kokoro rerun". Make sure to keep the `Run-TryBot` +1 vote.
+
[#vscode-dev]: https://gophers.slack.com/archives/CUWGEKH5Z
[Gophers Slack]: https://invite.slack.golangbridge.org/
To view, visit change 397482. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Jamal Carvalho, Polina Sokolova.
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/7ff0e72e-e5dc-4f5d-a298-8acf849ba54b
Patch set 2:TryBot-Result +1
Polina Sokolova (Gerrit)
Attention is currently required from: Jamal Carvalho, Hyang-Ah Hana Kim.
3 comments:
Patchset:
I think I can guess what inspired this doc change 😊
Worth referencing this issue? https://github.com/golang/go/issues/38620
File docs/contributing.md:
Patch Set #2, Line 194:
you or a fellow contributor assigns the `Run-TryBot=1` label in Gerrit, the test command defined inIs this sticky? If it's set once, will all subsequent new patches and kokoro rerun requests use it or are there circumstances where you might want to clear and reset?
Why is it not just set automatically by default?Patch Set #2, Line 194:
you or a fellow contributor assigns the `Run-TryBot=1` label in Gerrit, the test command defined in+1, no =1
To view, visit change 397482. To unsubscribe, or for help writing mail filters, visit settings.
Hyang-Ah Hana Kim (Gerrit)
Attention is currently required from: Jamal Carvalho, Polina Sokolova.
Patch set 3:Trust +1
3 comments:
Patchset:
I think I can guess what inspired this doc change 😊 […]
That issue is about the regular builder.
This is about kokoro builder which is different, so I fear this adds noise.
File docs/contributing.md:
Patch Set #2, Line 194:
you or a fellow contributor assigns the `Run-TryBot=1` label in Gerrit, the test command defined in
+1, no =1
Done
Patch Set #2, Line 194:
you or a fellow contributor assigns the `Run-TryBot=1` label in Gerrit, the test command defined in
Is this sticky? If it's set once, will all subsequent new patches and kokoro rerun requests use it o […]
No. Run-TryBot is reset when a new patch is uploaded. Otherwise, that violates our security model (we shouldn't run random patches in our builder or google infrastructure).
Most go contributors with the permission don't use github pr workflow, but use git-codereview, which allows them to configure `-trybot` flag for any of their uploaded changes automatically. https://pkg.go.dev/golang.org/x/review/git-codereview
I strongly recommend the gerrit-based review workflow.
To view, visit change 397482. To unsubscribe, or for help writing mail filters, visit settings.
Polina Sokolova (Gerrit)
Attention is currently required from: Jamal Carvalho, Hyang-Ah Hana Kim.
Patch set 3:Code-Review +2
Jamal Carvalho (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
Patch set 3:Code-Review +2
To view, visit change 397482. To unsubscribe, or for help writing mail filters, visit settings.
Hyang-Ah Hana Kim (Gerrit)
Hyang-Ah Hana Kim submitted this change.
docs/contributing.md: discuss kokoro and how to use it
Change-Id: I8248aef0b8acb6ca696525d2bc53b2e625f0490c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/397482
Trust: Hyang-Ah Hana Kim <hya...@gmail.com>
Reviewed-by: Polina Sokolova <pol...@google.com>
Reviewed-by: Jamal Carvalho <ja...@golang.org>
---
M docs/contributing.md
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/docs/contributing.md b/docs/contributing.md
index 354c4f9..e2fa033 100644
--- a/docs/contributing.md
+++ b/docs/contributing.md
@@ -15,6 +15,7 @@
* [Test](#test)
* [Sideload](#sideload)
* [Mail your change for review](#mail-your-change-for-review)
+ * [Presubmit test in CI](#presubmit-test-in-ci)
## Before you start coding
@@ -187,7 +188,18 @@
Once you've sent out your change, a maintainer will take a look at your contribution within a few weeks. If you don't hear back, feel free to ping the issue or send a message to the [#vscode-dev] channel of the [Gophers Slack].
-<!-- TODO: Kokoro setup details -->
+### Presubmit Test in CI
+
+When you mail your CL or upload a new patch to an existing CL, *AND*
+you or a fellow contributor assigns the `Run-TryBot=+1` label in Gerrit, the test command defined in
+`build/all.bash` will run by `Kokoro`, which is Jenkins-like Google infrastructure
+for running Dockerized tests. `Kokoro` will post the result as a comment, and add its `TryBot-Result`
+vote after each test run completes.
+
+To force a re-run of the Kokoro CI,
+ * Remove `TryBot-Result` vote (hover over the label, and click the trashcan icon).
+ * Reply in Gerrit with the comment "kokoro rerun". Make sure to keep the `Run-TryBot` +1 vote.
+
[#vscode-dev]: https://gophers.slack.com/archives/CUWGEKH5Z
[Gophers Slack]: https://invite.slack.golangbridge.org/
To view, visit change 397482. To unsubscribe, or for help writing mail filters, visit settings.