[pkgsite] internal/source: clean up redundancies and typos after CL 708175
1 view
Skip to first unread message
Hyang-Ah Hana Kim (Gerrit)
1:24 PM (10 hours ago) 1:24 PM
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Hyang-Ah Hana Kim has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/source: clean up redundancies and typos after CL 708175
Remove redundant assignment of repoSubdir and redundant break in
switch statement in internal/source/meta-tags.go.
Fix typos in comments ("minium" -> "minimum").
Change-Id: I24e413c3942f5af50dfeec594b96b680b04ff7e2
Change diff
diff --git a/internal/source/meta-tags.go b/internal/source/meta-tags.go
index d1c271e..cc32064 100644
--- a/internal/source/meta-tags.go
+++ b/internal/source/meta-tags.go
@@ -102,10 +102,9 @@
repoSubdir := ""
switch len(fields) {
case 3:
- // go-import meta tag support minium 3 fields (root-path vcs repo-url).
- break // good to proceed
+ // go-import meta tag support minimum 3 fields (root-path vcs repo-url).
case 4:
- // go-import meta tag support minium 3 fields (root-path vcs repo-url), and additionally "subdirectory" field since Go 1.25.
+ // go-import meta tag support minimum 3 fields (root-path vcs repo-url), and additionally "subdirectory" field since Go 1.25.
repoSubdir = fields[3]
default:
errorMessage = "go-import meta tag content attribute does not have three or four fields"
@@ -149,7 +148,6 @@
break metaScan
}
repoURL = sm.repoURL
- repoSubdir = sm.repoSubdir
}
sm = &sourceMeta{
repoRootPrefix: repoRootPrefix,
Change information
Files:
- M internal/source/meta-tags.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 4 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
1:49 PM (9 hours ago) 1:49 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, kokoro, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Nicholas Husin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Code-Review | +2 |
2 comments
Patchset-level comments
File internal/source/meta-tags.go
Line 105, Patchset 1 (Latest):
// go-import meta tag support minimum 3 fields (root-path vcs repo-url).Nicholas Husin . unresolved
Should be `supports` I think. Maybe `supports a minimum of 3 fields` would read clearer too.
Same below.
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
1:49 PM (9 hours ago) 1:49 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, kokoro, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
1:56 PM (9 hours ago) 1:56 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
kokoro voted kokoro-CI+1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/690632b6-cea4-417d-b482-6a0aead27bd6
| kokoro-CI | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
2:42 PM (8 hours ago) 2:42 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Hyang-Ah Hana Kim uploaded new patchset![]( "Open in Gerrit")
Hyang-Ah Hana Kim uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
- kokoro-CI-Passes: kokoro-CI+1 by kokoro
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
3:14 PM (8 hours ago) 3:14 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, Nicholas Husin, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Hyang-Ah Hana Kim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hyang-Ah Hana Kim
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File internal/source/meta-tags.go
Line 105, Patchset 1:
// go-import meta tag support minimum 3 fields (root-path vcs repo-url).Nicholas Husin . resolved
Should be `supports` I think. Maybe `supports a minimum of 3 fields` would read clearer too.
Same below.
Hyang-Ah Hana Kim
Done
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
3:44 PM (7 hours ago) 3:44 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
kokoro voted kokoro-CI+1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: SUCCESS
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
4:43 PM (6 hours ago) 4:43 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com
Hyang-Ah Hana Kim voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
4:43 PM (6 hours ago) 4:43 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com
Hyang-Ah Hana Kim removed a vote from this change![]( "Open in Gerrit")
Removed LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
4:59 PM (6 hours ago) 4:59 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: internal/source/meta-tags.go
Insertions: 2, Deletions: 2.
@@ -102,9 +102,9 @@
repoSubdir := ""
switch len(fields) {
case 3:
- // go-import meta tag support minimum 3 fields (root-path vcs repo-url).
+ // go-import meta tag supports a minimum of 3 fields (root-path vcs repo-url).
case 4:
- // go-import meta tag support minimum 3 fields (root-path vcs repo-url), and additionally "subdirectory" field since Go 1.25.
+ // go-import meta tag supports a minimum of 3 fields (root-path vcs repo-url), and additionally "subdirectory" field since Go 1.25.
repoSubdir = fields[3]
default:
errorMessage = "go-import meta tag content attribute does not have three or four fields"
```
Change information
Commit message:
internal/source: clean up redundancies and typos after CL 708175
Remove redundant assignment of repoSubdir and redundant break in
switch statement in internal/source/meta-tags.go.
Fix typos in comments ("minium" -> "minimum").
Change-Id: I24e413c3942f5af50dfeec594b96b680b04ff7e2
Auto-Submit: Hyang-Ah Hana Kim <hya...@gmail.com>
kokoro-CI: kokoro <noreply...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Files:
- M internal/source/meta-tags.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 4 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
kokoro-CI-Passes: kokoro-CI+1 by kokoro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages