[go] cmd/compile/internal/ssa: move Op to op package

9 views
Skip to first unread message

Michael Matloob (Gerrit)

unread,
Jul 21, 2026, 4:18:37 PMJul 21
to goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Keith Randall

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
Gerrit-Change-Number: 803781
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Comment-Date: Tue, 21 Jul 2026 20:18:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
Jul 21, 2026, 4:20:46 PMJul 21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall

Michael Matloob uploaded new patchset

Michael Matloob uploaded patch set #6 to this change.
Following approvals got outdated and were removed:
Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
    Gerrit-Change-Number: 803781
    Gerrit-PatchSet: 6
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Michael Matloob (Gerrit)

    unread,
    Jul 21, 2026, 10:39:45 PMJul 21
    to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, golang-co...@googlegroups.com
    Attention needed from Keith Randall and Michael Matloob

    Michael Matloob voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keith Randall
    • Michael Matloob
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
      Gerrit-Change-Number: 803781
      Gerrit-PatchSet: 6
      Gerrit-Owner: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Michael Matloob <mat...@google.com>
      Gerrit-Attention: Michael Matloob <mat...@golang.org>
      Gerrit-Comment-Date: Wed, 22 Jul 2026 02:39:39 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Keith Randall (Gerrit)

      unread,
      Jul 27, 2026, 5:20:02 PM (12 days ago) Jul 27
      to Michael Matloob, goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, golang-co...@googlegroups.com
      Attention needed from Michael Matloob

      Keith Randall voted Code-Review+2

      Code-Review+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Matloob
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
      Gerrit-Change-Number: 803781
      Gerrit-PatchSet: 11
      Gerrit-Owner: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Michael Matloob <mat...@google.com>
      Gerrit-Attention: Michael Matloob <mat...@golang.org>
      Gerrit-Comment-Date: Mon, 27 Jul 2026 21:19:53 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Matloob (Gerrit)

      unread,
      Jul 28, 2026, 12:04:25 PM (11 days ago) Jul 28
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Michael Matloob

      Michael Matloob uploaded new patchset

      Michael Matloob uploaded patch set #13 to this change.
      Following approvals got outdated and were removed:

      Related details

      Attention is currently required from:
      • Michael Matloob
      Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
        Gerrit-Change-Number: 803781
        Gerrit-PatchSet: 13
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Michael Matloob (Gerrit)

        unread,
        Aug 1, 2026, 12:05:42 PM (7 days ago) Aug 1
        to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

        Michael Matloob uploaded new patchset

        Michael Matloob uploaded patch set #14 to this change.
        Following approvals got outdated and were removed:
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
        Gerrit-Change-Number: 803781
        Gerrit-PatchSet: 14
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Cherry Mui (Gerrit)

        unread,
        Aug 3, 2026, 1:25:13 AM (6 days ago) Aug 3
        to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
        Attention needed from Michael Matloob

        Cherry Mui added 10 comments

        File src/cmd/compile/internal/amd64/simdssa.go
        File-level comment, Patchset 14 (Latest):
        Cherry Mui . unresolved

        This file is generated. Please update the generator instead.

        File src/cmd/compile/internal/amd64/ssa.go
        Line 17, Patchset 14 (Latest): "cmd/compile/internal/ssa/op"
        oppkg "cmd/compile/internal/ssa/op"
        Cherry Mui . unresolved

        Why import a package twice? Seems pretty weird. (I see that op is used as local variable names in some places. That said, importing a package twice still seem weird. We could rename the local variable. Or, if we really don't want to do that, we probably should always use a renamed import.)

        File src/cmd/compile/internal/arm64/simdssa.go
        File-level comment, Patchset 14 (Latest):
        Cherry Mui . unresolved

        Also this.

        File src/cmd/compile/internal/arm64/ssa.go
        Line 16, Patchset 14 (Latest): "cmd/compile/internal/ssa/op"
        oppkg "cmd/compile/internal/ssa/op"
        Cherry Mui . unresolved

        Also here. And other files.

        File src/cmd/compile/internal/ssa/op/regalloc.go
        Line 5, Patchset 14 (Latest):// Register allocation.
        Cherry Mui . unresolved

        I don't think we should copy this comment. The files probably should be regmask.go.

        File src/cmd/compile/internal/ssa/op/schedule.go
        File-level comment, Patchset 14 (Latest):
        Cherry Mui . unresolved

        The file name is unfortunate. Maybe just put into op.go.

        File src/cmd/compile/internal/ssagen/simdAMD64intrinsics.go
        File-level comment, Patchset 14 (Latest):
        Cherry Mui . unresolved

        Also the file. It is generated.

        File src/cmd/compile/internal/ssagen/simdARM64intrinsics.go
        File-level comment, Patchset 14 (Latest):
        Cherry Mui . unresolved

        Also this.

        File src/cmd/compile/internal/ssagen/simdWasmintrinsics.go
        File-level comment, Patchset 14 (Latest):
        Cherry Mui . unresolved

        And this.

        File src/cmd/compile/internal/wasm/simdssa.go
        File-level comment, Patchset 14 (Latest):
        Cherry Mui . unresolved

        Also this.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Michael Matloob
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
        Gerrit-Change-Number: 803781
        Gerrit-PatchSet: 14
        Gerrit-Owner: Michael Matloob <mat...@golang.org>
        Gerrit-Reviewer: Keith Randall <k...@golang.org>
        Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
        Gerrit-Reviewer: Michael Matloob <mat...@google.com>
        Gerrit-CC: Cherry Mui <cher...@google.com>
        Gerrit-Attention: Michael Matloob <mat...@golang.org>
        Gerrit-Comment-Date: Mon, 03 Aug 2026 05:25:07 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Michael Matloob (Gerrit)

        unread,
        Aug 3, 2026, 9:01:38 PM (5 days ago) Aug 3
        to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Michael Matloob

        Michael Matloob uploaded new patchset

        Michael Matloob uploaded patch set #16 to this change.
        Following approvals got outdated and were removed:

        Related details

        Attention is currently required from:
        • Michael Matloob
        Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: newpatchset
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
          Gerrit-Change-Number: 803781
          Gerrit-PatchSet: 16
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Michael Matloob (Gerrit)

          unread,
          Aug 4, 2026, 8:18:30 AM (4 days ago) Aug 4
          to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
          Attention needed from Cherry Mui, Keith Randall and Michael Matloob

          Michael Matloob uploaded new patchset

          Michael Matloob uploaded patch set #17 to this change.
          Following approvals got outdated and were removed:
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Cherry Mui
          • Keith Randall
          • Michael Matloob
          Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: newpatchset
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
          Gerrit-Change-Number: 803781
          Gerrit-PatchSet: 17
          Gerrit-Owner: Michael Matloob <mat...@golang.org>
          Gerrit-Reviewer: Keith Randall <k...@golang.org>
          Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
          Gerrit-Reviewer: Michael Matloob <mat...@google.com>
          Gerrit-CC: Cherry Mui <cher...@google.com>
          Gerrit-Attention: Keith Randall <k...@golang.org>
          Gerrit-Attention: Cherry Mui <cher...@google.com>
          Gerrit-Attention: Michael Matloob <mat...@google.com>
          unsatisfied_requirement
          open
          diffy

          Michael Matloob (Gerrit)

          unread,
          Aug 4, 2026, 8:18:30 AM (4 days ago) Aug 4
          to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
          Attention needed from Cherry Mui, Keith Randall and Michael Matloob

          Michael Matloob added 3 comments

          File src/cmd/compile/internal/amd64/ssa.go
          Line 17, Patchset 14: "cmd/compile/internal/ssa/op"
          oppkg "cmd/compile/internal/ssa/op"
          Cherry Mui . resolved

          Why import a package twice? Seems pretty weird. (I see that op is used as local variable names in some places. That said, importing a package twice still seem weird. We could rename the local variable. Or, if we really don't want to do that, we probably should always use a renamed import.)

          Michael Matloob

          This was done automatically by rf because of the conflict. I think maybe the easiest thing to do for now is to name the package ssaop to avoid the conflict?

          File src/cmd/compile/internal/arm64/simdssa.go
          File-level comment, Patchset 14:
          Cherry Mui . resolved

          Also this.

          Michael Matloob

          renamed package.

          File src/cmd/compile/internal/arm64/ssa.go
          Line 16, Patchset 14: "cmd/compile/internal/ssa/op"
          oppkg "cmd/compile/internal/ssa/op"
          Cherry Mui . resolved

          Also here. And other files.

          Michael Matloob

          Renamed package.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Cherry Mui
          • Keith Randall
          • Michael Matloob
          Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
          Gerrit-Change-Number: 803781
          Gerrit-PatchSet: 17
          Gerrit-Owner: Michael Matloob <mat...@golang.org>
          Gerrit-Reviewer: Keith Randall <k...@golang.org>
          Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
          Gerrit-Reviewer: Michael Matloob <mat...@google.com>
          Gerrit-CC: Cherry Mui <cher...@google.com>
          Gerrit-Attention: Keith Randall <k...@golang.org>
          Gerrit-Attention: Cherry Mui <cher...@google.com>
          Gerrit-Attention: Michael Matloob <mat...@google.com>
          Gerrit-Comment-Date: Tue, 04 Aug 2026 12:18:09 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Cherry Mui <cher...@google.com>
          unsatisfied_requirement
          open
          diffy

          Michael Matloob (Gerrit)

          unread,
          Aug 4, 2026, 12:08:21 PM (4 days ago) Aug 4
          to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
          Attention needed from Cherry Mui, Keith Randall and Michael Matloob

          Michael Matloob uploaded new patchset

          Michael Matloob uploaded patch set #18 to this change.
          Following approvals got outdated and were removed:
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Cherry Mui
          • Keith Randall
          • Michael Matloob
          Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: newpatchset
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
          Gerrit-Change-Number: 803781
          Gerrit-PatchSet: 18
          unsatisfied_requirement
          open
          diffy

          Michael Matloob (Gerrit)

          unread,
          Aug 4, 2026, 12:08:22 PM (4 days ago) Aug 4
          to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
          Attention needed from Cherry Mui, Keith Randall and Michael Matloob

          Michael Matloob added 2 comments

          File src/cmd/compile/internal/amd64/simdssa.go
          File-level comment, Patchset 14:
          Cherry Mui . resolved

          This file is generated. Please update the generator instead.

          Michael Matloob

          Done

          File src/cmd/compile/internal/ssagen/simdAMD64intrinsics.go
          File-level comment, Patchset 14:
          Cherry Mui . resolved

          Also the file. It is generated.

          Michael Matloob

          Done

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Cherry Mui
          • Keith Randall
          • Michael Matloob
          Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
          Gerrit-Change-Number: 803781
          Gerrit-PatchSet: 18
          Gerrit-Owner: Michael Matloob <mat...@golang.org>
          Gerrit-Reviewer: Keith Randall <k...@golang.org>
          Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
          Gerrit-Reviewer: Michael Matloob <mat...@google.com>
          Gerrit-CC: Cherry Mui <cher...@google.com>
          Gerrit-Attention: Keith Randall <k...@golang.org>
          Gerrit-Attention: Cherry Mui <cher...@google.com>
          Gerrit-Attention: Michael Matloob <mat...@google.com>
          Gerrit-Comment-Date: Tue, 04 Aug 2026 16:08:13 +0000
          unsatisfied_requirement
          open
          diffy

          Michael Matloob (Gerrit)

          unread,
          Aug 4, 2026, 12:09:03 PM (4 days ago) Aug 4
          to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
          Attention needed from Cherry Mui, Keith Randall and Michael Matloob

          Michael Matloob added 3 comments

          File src/cmd/compile/internal/ssagen/simdARM64intrinsics.go
          File-level comment, Patchset 14:
          Cherry Mui . resolved

          Also this.

          Michael Matloob

          Done

          File src/cmd/compile/internal/ssagen/simdWasmintrinsics.go
          File-level comment, Patchset 14:
          Cherry Mui . resolved

          And this.

          Michael Matloob

          Done

          File src/cmd/compile/internal/wasm/simdssa.go
          File-level comment, Patchset 14:
          Cherry Mui . resolved

          Also this.

          Michael Matloob

          Done

          Gerrit-Comment-Date: Tue, 04 Aug 2026 16:08:59 +0000
          unsatisfied_requirement
          open
          diffy

          Michael Matloob (Gerrit)

          unread,
          Aug 4, 2026, 12:11:36 PM (4 days ago) Aug 4
          to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
          Attention needed from Cherry Mui, Keith Randall and Michael Matloob

          Michael Matloob added 1 comment

          File src/cmd/compile/internal/ssa/op/regalloc.go
          Line 5, Patchset 14:// Register allocation.
          Cherry Mui . unresolved

          I don't think we should copy this comment. The files probably should be regmask.go.

          Michael Matloob

          still need to do this- the change is done by rf

          Gerrit-Comment-Date: Tue, 04 Aug 2026 16:11:31 +0000
          unsatisfied_requirement
          open
          diffy

          Michael Matloob (Gerrit)

          unread,
          Aug 4, 2026, 12:21:32 PM (4 days ago) Aug 4
          to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, golang-co...@googlegroups.com
          Attention needed from Cherry Mui, Keith Randall and Michael Matloob

          Michael Matloob voted Code-Review+1

          Code-Review+1
          Gerrit-Attention: Michael Matloob <mat...@golang.org>
          Gerrit-Attention: Cherry Mui <cher...@google.com>
          Gerrit-Comment-Date: Tue, 04 Aug 2026 16:21:28 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          unsatisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages