[go] cmd/compile/internal/ssa: move Op to op package
17 views
Skip to first unread message
Michael Matloob (Gerrit)
Jul 21, 2026, 4:18:37 PMJul 21
to goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Keith Randall
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 21, 2026, 4:20:46 PMJul 21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #6 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 21, 2026, 10:39:45 PMJul 21
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Jul 27, 2026, 5:20:02 PMJul 27
to Michael Matloob, goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Keith Randall voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 28, 2026, 12:04:25 PMJul 28
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #13 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 1, 2026, 12:05:42 PMAug 1
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #14 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Aug 3, 2026, 1:25:13 AMAug 3
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Cherry Mui added 10 comments![]( "Open in Gerrit")
File src/cmd/compile/internal/amd64/simdssa.go
File-level comment, Patchset 14 (Latest):
Cherry Mui . unresolved
This file is generated. Please update the generator instead.
File src/cmd/compile/internal/amd64/ssa.go
Line 17, Patchset 14 (Latest):
"cmd/compile/internal/ssa/op"
oppkg "cmd/compile/internal/ssa/op"Cherry Mui . unresolved
Why import a package twice? Seems pretty weird. (I see that op is used as local variable names in some places. That said, importing a package twice still seem weird. We could rename the local variable. Or, if we really don't want to do that, we probably should always use a renamed import.)
File src/cmd/compile/internal/arm64/simdssa.go
File src/cmd/compile/internal/arm64/ssa.go
Line 16, Patchset 14 (Latest):
"cmd/compile/internal/ssa/op"
oppkg "cmd/compile/internal/ssa/op"Cherry Mui . unresolved
Also here. And other files.
File src/cmd/compile/internal/ssa/op/regalloc.go
Line 5, Patchset 14 (Latest):
// Register allocation.Cherry Mui . unresolved
I don't think we should copy this comment. The files probably should be regmask.go.
File src/cmd/compile/internal/ssa/op/schedule.go
File-level comment, Patchset 14 (Latest):
Cherry Mui . unresolved
The file name is unfortunate. Maybe just put into op.go.
File src/cmd/compile/internal/ssagen/simdAMD64intrinsics.go
File src/cmd/compile/internal/ssagen/simdARM64intrinsics.go
File src/cmd/compile/internal/ssagen/simdWasmintrinsics.go
File src/cmd/compile/internal/wasm/simdssa.go
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 3, 2026, 9:01:38 PMAug 3
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #16 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 4, 2026, 8:18:30 AMAug 4
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #17 to this change.
Following approvals got outdated and were removed:
- Code-Review: +1 by Michael Matloob, +2 by Keith Randall
- TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 4, 2026, 8:18:30 AMAug 4
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob added 3 comments![]( "Open in Gerrit")
File src/cmd/compile/internal/amd64/ssa.go
Line 17, Patchset 14:
"cmd/compile/internal/ssa/op"
oppkg "cmd/compile/internal/ssa/op"Cherry Mui . resolved
Why import a package twice? Seems pretty weird. (I see that op is used as local variable names in some places. That said, importing a package twice still seem weird. We could rename the local variable. Or, if we really don't want to do that, we probably should always use a renamed import.)
Michael Matloob
This was done automatically by rf because of the conflict. I think maybe the easiest thing to do for now is to name the package ssaop to avoid the conflict?
File src/cmd/compile/internal/arm64/simdssa.go
File src/cmd/compile/internal/arm64/ssa.go
Line 16, Patchset 14:
"cmd/compile/internal/ssa/op"
oppkg "cmd/compile/internal/ssa/op"Cherry Mui . resolved
Also here. And other files.
Michael Matloob
Renamed package.
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 4, 2026, 12:08:21 PMAug 4
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #18 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 4, 2026, 12:08:22 PMAug 4
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob added 2 comments![]( "Open in Gerrit")
File src/cmd/compile/internal/amd64/simdssa.go
File-level comment, Patchset 14:
Cherry Mui . resolved
Michael MatloobThis file is generated. Please update the generator instead.
Done
File src/cmd/compile/internal/ssagen/simdAMD64intrinsics.go
File-level comment, Patchset 14:
Cherry Mui . resolved
Michael MatloobAlso the file. It is generated.
Done
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 4, 2026, 12:09:03 PMAug 4
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob added 3 comments![]( "Open in Gerrit")
File src/cmd/compile/internal/ssagen/simdARM64intrinsics.go
File src/cmd/compile/internal/ssagen/simdWasmintrinsics.go
File src/cmd/compile/internal/wasm/simdssa.go
Michael Matloob (Gerrit)
Aug 4, 2026, 12:11:36 PMAug 4
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob added 1 comment![]( "Open in Gerrit")
File src/cmd/compile/internal/ssa/op/regalloc.go
Line 5, Patchset 14:
// Register allocation.Cherry Mui . unresolved
I don't think we should copy this comment. The files probably should be regmask.go.
Michael Matloob
still need to do this- the change is done by rf
Michael Matloob (Gerrit)
Aug 4, 2026, 12:21:32 PMAug 4
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Michael Matloob (Gerrit)
Aug 8, 2026, 10:59:12 PMAug 8
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Cherry Mui, Keith Randall, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob added 2 comments![]( "Open in Gerrit")
File src/cmd/compile/internal/ssa/op/regalloc.go
Line 5, Patchset 14:
// Register allocation.Cherry Mui . resolved
Michael MatloobI don't think we should copy this comment. The files probably should be regmask.go.
still need to do this- the change is done by rf
Michael Matloob
Done
File src/cmd/compile/internal/ssa/op/schedule.go
File-level comment, Patchset 14:
Cherry Mui . resolved
Michael MatloobThe file name is unfortunate. Maybe just put into op.go.
Done
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 8, 2026, 10:59:14 PMAug 8
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #19 to this change.
Following approvals got outdated and were removed:
- Code-Review: +1 by Michael Matloob
- TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 9, 2026, 10:20:10 PMAug 9
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #20 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 10, 2026, 2:49:27 PMAug 10
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #22 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 10, 2026, 3:33:39 PMAug 10
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Keith Randall, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 11, 2026, 1:15:26 PMAug 11
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #23 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 11, 2026, 3:51:46 PMAug 11
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #24 to this change.
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jorropo (Gerrit)
Aug 11, 2026, 4:13:32 PMAug 11
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Cherry Mui, Keith Randall, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Jorropo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 24 (Latest):
Jorropo . resolved
If you are unhappy about the compilation performance of that package still I've found that the compiler is not very good at handling never touched after `init` initializers particularly when they are big and long.
In some old project I've touched I've replaced a `go:generate` generating a million or so long initializer with one generating a binary file that then gets consumed by `//go:embed` into a `string`.
Then I had a function which used `binary` to map the manually packed binary data in the string into the return value.
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 12, 2026, 10:32:08 AMAug 12
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #25 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 13, 2026, 1:47:42 PMAug 13
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #26 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Aug 13, 2026, 2:08:07 PMAug 13
to Michael Matloob, goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, Michael Matloob, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Michael Matloob
Keith Randall voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 13, 2026, 4:35:59 PMAug 13
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall, Michael Matloob and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #27 to this change.
Following approvals got outdated and were removed:
- Code-Review: +2 by Keith Randall, +1 by Michael Matloob
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 13, 2026, 4:52:04 PMAug 13
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 13, 2026, 4:58:38 PMAug 13
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall, Michael Matloob and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #28 to this change.
Following approvals got outdated and were removed:
- Code-Review: +1 by Michael Matloob
- TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 13, 2026, 5:08:11 PMAug 13
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 13, 2026, 5:12:36 PMAug 13
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Keith Randall, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Michael Matloob voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 14, 2026, 4:18:50 PMAug 14
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall, Michael Matloob and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #31 to this change.
Following approvals got outdated and were removed:
- Code-Review: +1 by Michael Matloob
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 14, 2026, 4:23:54 PMAug 14
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Keith Randall, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Michael Matloob voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 14, 2026, 4:26:05 PMAug 14
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 14, 2026, 4:57:01 PMAug 14
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #33 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 14, 2026, 5:48:22 PMAug 14
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Keith Randall, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Michael Matloob voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 17, 2026, 4:50:44 PMAug 17
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #36 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Aug 17, 2026, 5:38:44 PMAug 17
to Michael Matloob, goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Michael Matloob
Keith Randall voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Aug 17, 2026, 5:38:58 PMAug 17
to Michael Matloob, goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Michael Matloob
Keith Randall voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Aug 17, 2026, 5:46:32 PMAug 17
to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Keith Randall, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, Cherry Mui, golang-co...@googlegroups.com
Michael Matloob submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/compile/internal/ssa: move Op to op package
This change makes an op package with the Op type, the op definitions, and
supporting types. It exports the names of the types and fields to make that
possible.
This CL adds name stutter just like the block one did. We'll want to fix
that in a later CL. Unfortunately it's not as easy as just removing the
op prefix because if we removed the Op in op.Op386ORL for instance the name
op.386ORL would start with a digit.
For #80409
[git-generate]
cd src/cmd/compile/internal/ssa
rf "mv AuxType_ AuxTypeNone Op OpInvalid OpInfo OutputInfo RegInfo OpcodeTable SymEffect SymRead RegMask InputInfo OutputInfo Register ./ssaop"
cd ssaop
rf '
mv AuxType_ AuxType
mv regalloc.go regmask.go
rm regmask.go:/Register allocation/-0,/TODO: maybe we should/+0
'
cd ../_gen
rf 'sub splitPhase var splitPhase = phase1Op'
sed 's/= Op/= ssaop.Op/g' -i *.rules
sed 's/\[Op/\[ssaop.Op/g' -i *.rules
# Update and re-run simdgen
cd ../../../../../simd/archsimd/_gen
sed -i 's/^var splitPhase = .*$/var splitPhase = phase1Op/' \
simdgen/main.go wasmgen/main.go tmplgen/main.go
sed 's/OpARM64LessThanU/ssaop.OpARM64LessThanU/g' -i simdgen/ops/ShiftRotate/go_arm64.yaml
go run . -tmplgen -simdgen -wasmgen
Change-Id: I25911b07dabad30603f92d105538a4ba6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/803781
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <k...@google.com>
Reviewed-by: Michael Matloob <mat...@google.com>
Reviewed-by: Keith Randall <k...@golang.org>
Files:
- M src/cmd/compile/internal/amd64/simdssa.go
- M src/cmd/compile/internal/amd64/ssa.go
- M src/cmd/compile/internal/arm/ssa.go
- M src/cmd/compile/internal/arm64/simdssa.go
- M src/cmd/compile/internal/arm64/ssa.go
- M src/cmd/compile/internal/liveness/arg.go
- M src/cmd/compile/internal/liveness/mergelocals.go
- M src/cmd/compile/internal/liveness/plive.go
- M src/cmd/compile/internal/loong64/ssa.go
- M src/cmd/compile/internal/mips/ssa.go
- M src/cmd/compile/internal/mips64/ssa.go
- M src/cmd/compile/internal/ppc64/ssa.go
- M src/cmd/compile/internal/riscv64/ssa.go
- M src/cmd/compile/internal/s390x/ssa.go
- M src/cmd/compile/internal/ssa/_gen/386.rules
- M src/cmd/compile/internal/ssa/_gen/AMD64.rules
- M src/cmd/compile/internal/ssa/_gen/ARM64.rules
- M src/cmd/compile/internal/ssa/_gen/LOONG64.rules
- M src/cmd/compile/internal/ssa/_gen/MIPS64.rules
- M src/cmd/compile/internal/ssa/_gen/PPC64.rules
- M src/cmd/compile/internal/ssa/_gen/RISCV64.rules
- M src/cmd/compile/internal/ssa/_gen/S390X.rules
- M src/cmd/compile/internal/ssa/_gen/Wasm.rules
- M src/cmd/compile/internal/ssa/_gen/dec.rules
- M src/cmd/compile/internal/ssa/_gen/dec64.rules
- M src/cmd/compile/internal/ssa/_gen/divisible.rules
- M src/cmd/compile/internal/ssa/_gen/generic.rules
- M src/cmd/compile/internal/ssa/_gen/main.go
- M src/cmd/compile/internal/ssa/_gen/simdARM64.rules
- M src/cmd/compile/internal/ssa/addressingmodes.go
- M src/cmd/compile/internal/ssa/amd64_helpers.go
- M src/cmd/compile/internal/ssa/arm64_helpers.go
- M src/cmd/compile/internal/ssa/branchelim.go
- M src/cmd/compile/internal/ssa/branchelim_test.go
- M src/cmd/compile/internal/ssa/check.go
- M src/cmd/compile/internal/ssa/checkbce.go
- M src/cmd/compile/internal/ssa/config.go
- M src/cmd/compile/internal/ssa/copyelim.go
- M src/cmd/compile/internal/ssa/copyelim_test.go
- M src/cmd/compile/internal/ssa/cpufeatures.go
- M src/cmd/compile/internal/ssa/critical.go
- M src/cmd/compile/internal/ssa/cse.go
- M src/cmd/compile/internal/ssa/cse_test.go
- M src/cmd/compile/internal/ssa/deadcode.go
- M src/cmd/compile/internal/ssa/deadcode_test.go
- M src/cmd/compile/internal/ssa/deadstore.go
- M src/cmd/compile/internal/ssa/deadstore_test.go
- M src/cmd/compile/internal/ssa/debug.go
- M src/cmd/compile/internal/ssa/decompose.go
- M src/cmd/compile/internal/ssa/dom_test.go
- M src/cmd/compile/internal/ssa/downward_counting_loop.go
- M src/cmd/compile/internal/ssa/expand_calls.go
- M src/cmd/compile/internal/ssa/flagalloc.go
- M src/cmd/compile/internal/ssa/func.go
- M src/cmd/compile/internal/ssa/func_test.go
- M src/cmd/compile/internal/ssa/fuse.go
- M src/cmd/compile/internal/ssa/fuse_branchredirect.go
- M src/cmd/compile/internal/ssa/fuse_comparisons.go
- M src/cmd/compile/internal/ssa/fuse_test.go
- M src/cmd/compile/internal/ssa/generic_helpers.go
- M src/cmd/compile/internal/ssa/known_bits.go
- M src/cmd/compile/internal/ssa/licm.go
- M src/cmd/compile/internal/ssa/licm_test.go
- M src/cmd/compile/internal/ssa/likelyadjust.go
- M src/cmd/compile/internal/ssa/loopbce.go
- M src/cmd/compile/internal/ssa/loopreschedchecks.go
- M src/cmd/compile/internal/ssa/looprotate_test.go
- M src/cmd/compile/internal/ssa/lower.go
- M src/cmd/compile/internal/ssa/memcombine.go
- M src/cmd/compile/internal/ssa/merge_conditional_branches.go
- M src/cmd/compile/internal/ssa/merge_conditional_branches_test.go
- M src/cmd/compile/internal/ssa/nilcheck.go
- M src/cmd/compile/internal/ssa/nilcheck_test.go
- M src/cmd/compile/internal/ssa/numberlines.go
- M src/cmd/compile/internal/ssa/op.go
- M src/cmd/compile/internal/ssa/opGen.go
- M src/cmd/compile/internal/ssa/pair.go
- M src/cmd/compile/internal/ssa/passbm_test.go
- M src/cmd/compile/internal/ssa/phiopt.go
- M src/cmd/compile/internal/ssa/poset_test.go
- M src/cmd/compile/internal/ssa/ppc64latelower_helpers.go
- M src/cmd/compile/internal/ssa/print.go
- M src/cmd/compile/internal/ssa/prove.go
- M src/cmd/compile/internal/ssa/regalloc.go
- M src/cmd/compile/internal/ssa/regalloc_test.go
- M src/cmd/compile/internal/ssa/rewrite.go
- M src/cmd/compile/internal/ssa/rewrite386.go
- M src/cmd/compile/internal/ssa/rewrite386splitload.go
- M src/cmd/compile/internal/ssa/rewriteAMD64.go
- M src/cmd/compile/internal/ssa/rewriteAMD64latelower.go
- M src/cmd/compile/internal/ssa/rewriteAMD64splitload.go
- M src/cmd/compile/internal/ssa/rewriteARM.go
- M src/cmd/compile/internal/ssa/rewriteARM64.go
- M src/cmd/compile/internal/ssa/rewriteARM64latelower.go
- M src/cmd/compile/internal/ssa/rewriteLOONG64.go
- M src/cmd/compile/internal/ssa/rewriteLOONG64latelower.go
- M src/cmd/compile/internal/ssa/rewriteMIPS.go
- M src/cmd/compile/internal/ssa/rewriteMIPS64.go
- M src/cmd/compile/internal/ssa/rewriteMIPS64latelower.go
- M src/cmd/compile/internal/ssa/rewritePPC64.go
- M src/cmd/compile/internal/ssa/rewritePPC64latelower.go
- M src/cmd/compile/internal/ssa/rewriteRISCV64.go
- M src/cmd/compile/internal/ssa/rewriteRISCV64latelower.go
- M src/cmd/compile/internal/ssa/rewriteS390X.go
- M src/cmd/compile/internal/ssa/rewriteWasm.go
- M src/cmd/compile/internal/ssa/rewritedec.go
- M src/cmd/compile/internal/ssa/rewritedec64.go
- M src/cmd/compile/internal/ssa/rewritedivisible.go
- M src/cmd/compile/internal/ssa/rewritedivmod.go
- M src/cmd/compile/internal/ssa/rewritegeneric.go
- M src/cmd/compile/internal/ssa/sccp.go
- M src/cmd/compile/internal/ssa/sccp_test.go
- M src/cmd/compile/internal/ssa/schedule.go
- M src/cmd/compile/internal/ssa/schedule_test.go
- M src/cmd/compile/internal/ssa/shift_test.go
- M src/cmd/compile/internal/ssa/shortcircuit.go
- M src/cmd/compile/internal/ssa/shortcircuit_test.go
- M src/cmd/compile/internal/ssa/softfloat.go
- A src/cmd/compile/internal/ssa/ssaop/op.go
- A src/cmd/compile/internal/ssa/ssaop/opGen.go
- A src/cmd/compile/internal/ssa/ssaop/regmask.go
- M src/cmd/compile/internal/ssa/stackalloc.go
- M src/cmd/compile/internal/ssa/tern_helpers.go
- M src/cmd/compile/internal/ssa/tighten.go
- M src/cmd/compile/internal/ssa/trim.go
- M src/cmd/compile/internal/ssa/tuple.go
- M src/cmd/compile/internal/ssa/value.go
- M src/cmd/compile/internal/ssa/writebarrier.go
- M src/cmd/compile/internal/ssa/writebarrier_test.go
- M src/cmd/compile/internal/ssa/zcse.go
- M src/cmd/compile/internal/ssagen/intrinsics.go
- M src/cmd/compile/internal/ssagen/pgen.go
- M src/cmd/compile/internal/ssagen/phi.go
- M src/cmd/compile/internal/ssagen/simdAMD64intrinsics.go
- M src/cmd/compile/internal/ssagen/simdARM64intrinsics.go
- M src/cmd/compile/internal/ssagen/simdWasmintrinsics.go
- M src/cmd/compile/internal/ssagen/ssa.go
- M src/cmd/compile/internal/wasm/simdssa.go
- M src/cmd/compile/internal/wasm/ssa.go
- M src/cmd/compile/internal/x86/ssa.go
- M src/simd/archsimd/_gen/simdgen/main.go
- M src/simd/archsimd/_gen/simdgen/ops/ShiftRotate/go_arm64.yaml
- M src/simd/archsimd/_gen/tmplgen/main.go
- M src/simd/archsimd/_gen/wasmgen/main.go
Change size: XL
Delta: 144 files changed, 178145 insertions(+), 177948 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Michael Matloob, +1 by Keith Randall, +2 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages