[go] cmd/distpack: add a test on distribution size

[Michael Matloob (Gerrit)]

Attention needed from Dmitri Shuralyov and Michael Matloob

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Dmitri Shuralyov
• Michael Matloob

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I8c04d6afc5d7b5f28ba2b6090fd81271db173f83

Gerrit-Change-Number: 754921

Gerrit-PatchSet: 6

Gerrit-Owner: Michael Matloob <mat...@golang.org>

Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Matloob <mat...@golang.org>

Gerrit-Reviewer: Michael Matloob <mat...@google.com>

Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>

Gerrit-Attention: Michael Matloob <mat...@google.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 17:59:51 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Michael Matloob (Gerrit)]

Attention needed from Dmitri Shuralyov and Michael Matloob

Michael Matloob voted

Auto-Submit	+1
Code-Review	+1

Open in Gerrit

Related details

Attention is currently required from:

• Dmitri Shuralyov
• Michael Matloob

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I8c04d6afc5d7b5f28ba2b6090fd81271db173f83

Gerrit-Change-Number: 754921

Gerrit-PatchSet: 6

Gerrit-Owner: Michael Matloob <mat...@golang.org>

Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Matloob <mat...@golang.org>

Gerrit-Reviewer: Michael Matloob <mat...@google.com>

Gerrit-Attention: Michael Matloob <mat...@golang.org>

Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>

Gerrit-Comment-Date: Fri, 13 Mar 2026 18:00:16 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dmitri Shuralyov (Gerrit)]

Attention needed from Michael Matloob

Dmitri Shuralyov added 4 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Dmitri Shuralyov . resolved

Thanks for working on this. I left some high level comments to get your feedback; that said, please let me know if you'd find it useful to consider them out of scope for this issue/CL, and instead aim to land this test largely as is as an intermediate step that improves over our current state.

File src/cmd/distpack/distsize_test.go

Line 25, Patchset 6 (Latest): testenv.SkipIfShortAndSlow(t)

Dmitri Shuralyov . unresolved

A couple related points/questions here.

Have you checked how well this countWriter approach that reuses the current GOROOT (i.e., without a dedicated make.bash in front) maps to the actual toolchain distribution sizes for releases?

Right now this is setup to run on many platforms, even those without longtest builders. Do you think we'd lose much useful coverage by limiting this further to only the platforms that perf builders run on (e.g., primarily linux/amd64)?

If not, an advantage of skipping the intermediate step of having a test and going directly to having this as a tracked benchmark is that it would eliminate having time-sensitive failures modes if some arbitrary CL happens to push one of the GOOS/GOARCH distribution sizes just slightly over the edge, even if most of distribution size increase comes from prior CLs.

File src/cmd/distpack/pack.go

Line 69, Patchset 6 (Parent):func main() {

Dmitri Shuralyov . unresolved

From a readability perspective, `main` was previously near the top and I find that kind of arrangement (i.e., highest level code near the top of the file, lower-level helpers placed below rather than above) helps, so I suggest not changing that arrangement unless you think this does help improve readability.

File src/cmd/internal/bootstrap_test/reboot_test.go

Open in Gerrit

Related details

Attention is currently required from:

• Michael Matloob

Submit Requirements:

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I8c04d6afc5d7b5f28ba2b6090fd81271db173f83

Gerrit-Change-Number: 754921

Gerrit-PatchSet: 6

Gerrit-Owner: Michael Matloob <mat...@golang.org>

Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Matloob <mat...@golang.org>

Gerrit-Reviewer: Michael Matloob <mat...@google.com>

Gerrit-Attention: Michael Matloob <mat...@golang.org>

Gerrit-Comment-Date: Thu, 19 Mar 2026 17:37:09 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Michael Matloob (Gerrit)]

Michael Matloob abandoned this change.

View Change

Abandoned I'm going to abandon this in favor of adding a benchmark to golang.org/x/bench.

Michael Matloob abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon