[go] simd/archsimd: delete DotProductQuadruple methods for now
4 views
Skip to first unread message
Cherry Mui (Gerrit)
Dec 19, 2025, 5:20:29 PM (5 days ago) Dec 19
to goph...@pubsubhelper.golang.org, David Chase, golang-co...@googlegroups.com
Attention needed from David Chase
Cherry Mui voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- David Chase
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Chase (Gerrit)
Dec 19, 2025, 5:36:00 PM (5 days ago) Dec 19
to Cherry Mui, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Cherry Mui
David Chase voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Dec 19, 2025, 5:39:39 PM (5 days ago) Dec 19
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, David Chase, golang-co...@googlegroups.com
Cherry Mui submitted the change![]( "Open in Gerrit")
Change information
Commit message:
simd/archsimd: delete DotProductQuadruple methods for now
The DotProductQuadruple methods are currently defined on Int8
vectors. There are some problems for that.
1. We defined a DotProductQuadrupleSaturated method, but the dot
product part does not need saturation, as it cannot overflow. It
is the addition part of VPDPBUSDS that does the saturation.
Currently we have optimization rules like
x.DotProductQuadrupleSaturated(y).Add(z) -> VPDPBUSDS
which is incorrect, in that the dot product doesn't do (or need)
saturation, and the Add is a regular Add, but we rewrite it to a
saturated add. The correct rule should be something like
x.DotProductQuadruple(y).AddSaturated(z) -> VPDPBUSDS
2. There are multiple flavors of DotProductQuadruple:
signed/unsigned × signed/unsigned, which cannot be completely
disambiguated by the type. The current naming may preclude adding
all the flavors.
For these reasons, remove the methods for now. We can add them
later with the issues addressed.
Change-Id: I549c0925afaa68c7e2cc956105619f2c1b46b325
Reviewed-on: https://go-review.googlesource.com/c/go/+/731441
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drc...@google.com>
Files:
- M src/cmd/compile/internal/amd64/simdssa.go
- M src/cmd/compile/internal/ssa/_gen/AMD64.rules
- M src/cmd/compile/internal/ssa/_gen/simdAMD64.rules
- M src/cmd/compile/internal/ssa/_gen/simdAMD64ops.go
- M src/cmd/compile/internal/ssa/_gen/simdgenericOps.go
- M src/cmd/compile/internal/ssa/opGen.go
- M src/cmd/compile/internal/ssa/rewriteAMD64.go
- M src/cmd/compile/internal/ssagen/simdintrinsics.go
- M src/simd/archsimd/_gen/simdgen/ops/MLOps/categories.yaml
- M src/simd/archsimd/_gen/simdgen/ops/MLOps/go.yaml
- M src/simd/archsimd/internal/simd_test/simd_test.go
- M src/simd/archsimd/ops_amd64.go
Change size: XL
Delta: 12 files changed, 0 insertions(+), 1120 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by David Chase
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Melissa Brown-Forbs (Gerrit)
Dec 22, 2025, 5:25:23 PM (2 days ago) Dec 22
to Cherry Mui, goph...@pubsubhelper.golang.org, Go LUCI, David Chase, golang-co...@googlegroups.com
Melissa Brown-Forbs added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages