Keith Randall (Gerrit)

unread,

Feb 26, 2026, 10:51:28 PMFeb 26

to Junyang Shao, goph...@pubsubhelper.golang.org, Keith Randall, golang-co...@googlegroups.com

Attention needed from Junyang Shao

Keith Randall has uploaded the change for review

Keith Randall would like Junyang Shao to review this change.

Commit message

cmd/compile: fix bloop test

Not 100% sure this is right, but it seems to fix the issue.

Fixes #77832

Change-Id: Ifa6eae61a5444f4fd88b310536b1caf7144e7797

Change diff

diff --git a/src/cmd/compile/internal/bloop/bloop.go b/src/cmd/compile/internal/bloop/bloop.go
index 4a7a57e..8af29b7 100644
--- a/src/cmd/compile/internal/bloop/bloop.go
+++ b/src/cmd/compile/internal/bloop/bloop.go
@@ -86,7 +86,7 @@
 	if name != nil {
 		debugName(name, pos)
 		return ir.Nodes{name}
-	} else if deref := n.(*ir.StarExpr); deref != nil {
+	} else if deref, ok := n.(*ir.StarExpr); ok && deref != nil {
 		if base.Flag.LowerM > 1 {
 			base.WarnfAt(pos, "dereference will be kept alive")
 		}

Change information

Files:

M src/cmd/compile/internal/bloop/bloop.go

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Open in Gerrit

Related details

Attention is currently required from:

Junyang Shao

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Keith Randall (Gerrit)

unread,

Feb 26, 2026, 10:52:59 PMFeb 26

to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, Junyang Shao, golang-co...@googlegroups.com

Attention needed from Junyang Shao and Keith Randall

Keith Randall voted

Auto-Submit	+1
Code-Review	+1

Open in Gerrit

Related details

Attention is currently required from:

Junyang Shao
Keith Randall

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Junyang Shao (Gerrit)

unread,

Feb 26, 2026, 11:36:45 PMFeb 26

to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, Keith Randall, golang-co...@googlegroups.com

Attention needed from Keith Randall

Junyang Shao voted and added 1 comment

Votes added by Junyang Shao

Code-Review

+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Junyang Shao . resolved

Thanks for the fix

Open in Gerrit

Related details

Attention is currently required from:

Keith Randall

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Gopher Robot (Gerrit)

unread,

Feb 26, 2026, 11:38:06 PMFeb 26

to Keith Randall, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, Go LUCI, Keith Randall, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

cmd/compile: fix bloop test

Not 100% sure this is right, but it seems to fix the issue.

Fixes #77832

Change-Id: Ifa6eae61a5444f4fd88b310536b1caf7144e7797

Reviewed-on: https://go-review.googlesource.com/c/go/+/749660

Reviewed-by: Keith Randall <k...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Auto-Submit: Keith Randall <k...@google.com>

Files:

M src/cmd/compile/internal/bloop/bloop.go

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Keith Randall, +2 by Junyang Shao
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Keith Randall (Gerrit)

unread,

Mar 3, 2026, 4:58:44 PMMar 3

to Junyang Shao, goph...@pubsubhelper.golang.org, Keith Randall, golang-co...@googlegroups.com

Attention needed from Junyang Shao

Keith Randall has uploaded the change for review

Keith Randall would like Junyang Shao to review this change.

Commit message

[release-branch.go1.26] cmd/compile: fix bloop test

Backport of CL 749660. It isn't a simple cherry pick because
there was a refactor at tip.

Fixes #77838

Change-Id: I761c441e82d41d1a7d7c91313401913bb5454546

Change diff

diff --git a/src/cmd/compile/internal/bloop/bloop.go b/src/cmd/compile/internal/bloop/bloop.go
index 69c889e..b8ff1f0 100644
--- a/src/cmd/compile/internal/bloop/bloop.go
+++ b/src/cmd/compile/internal/bloop/bloop.go
@@ -144,7 +144,7 @@
 		if name != nil {
 			debugName(name, n.Pos())
 			ret = keepAliveAt([]ir.Node{name}, n)
-		} else if deref := n.X.(*ir.StarExpr); deref != nil {
+		} else if deref, ok := n.X.(*ir.StarExpr); ok && deref != nil {
 			ret = keepAliveAt([]ir.Node{deref}, n)
 			if base.Flag.LowerM > 1 {
 				base.WarnfAt(n.Pos(), "dereference will be kept alive")
@@ -159,7 +159,7 @@
 			if name != nil {
 				debugName(name, n.Pos())
 				ns = append(ns, name)
-			} else if deref := lhs.(*ir.StarExpr); deref != nil {
+			} else if deref, ok := lhs.(*ir.StarExpr); ok && deref != nil {
 				ns = append(ns, deref)
 				if base.Flag.LowerM > 1 {
 					base.WarnfAt(n.Pos(), "dereference will be kept alive")
@@ -174,7 +174,7 @@
 		if name != nil {
 			debugName(name, n.Pos())
 			ret = keepAliveAt([]ir.Node{name}, n)
-		} else if deref := n.X.(*ir.StarExpr); deref != nil {
+		} else if deref, ok := n.X.(*ir.StarExpr); ok && deref != nil {
 			ret = keepAliveAt([]ir.Node{deref}, n)
 			if base.Flag.LowerM > 1 {
 				base.WarnfAt(n.Pos(), "dereference will be kept alive")

Change information

Files:

M src/cmd/compile/internal/bloop/bloop.go

Change size: XS

Delta: 1 file changed, 3 insertions(+), 3 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Junyang Shao

Submit Requirements:

Code-Review
No-Unresolved-Comments

Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Keith Randall (Gerrit)

unread,

Mar 3, 2026, 4:59:44 PMMar 3

to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, Junyang Shao, golang-co...@googlegroups.com

Attention needed from Junyang Shao and Keith Randall

Keith Randall voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Junyang Shao
Keith Randall

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Junyang Shao (Gerrit)

unread,

Mar 3, 2026, 5:28:16 PMMar 3

to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, Keith Randall, golang-co...@googlegroups.com

Attention needed from Keith Randall

Junyang Shao voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Keith Randall

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Carlos Amedee (Gerrit)

unread,

4:43 PM (2 hours ago) 4:43 PM

to Keith Randall, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, Go LUCI, Keith Randall, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:

[release-branch.go1.26] cmd/compile: fix bloop test

Backport of CL 749660. It isn't a simple cherry pick because
there was a refactor at tip.

Fixes #77838

Change-Id: I761c441e82d41d1a7d7c91313401913bb5454546

Reviewed-on: https://go-review.googlesource.com/c/go/+/751240

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Reviewed-by: Keith Randall <k...@google.com>

Files:

M src/cmd/compile/internal/bloop/bloop.go

Change size: XS

Delta: 1 file changed, 3 insertions(+), 3 deletions(-)

Branch: refs/heads/release-branch.go1.26

Submit Requirements:

Code-Review: +2 by Junyang Shao, +1 by Keith Randall

TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[go] cmd/compile: fix bloop test

Keith Randall (Gerrit)

Keith Randall has uploaded the change for review

Commit message

Change diff

Change information

Related details

Keith Randall (Gerrit)

Keith Randall voted

Related details

Junyang Shao (Gerrit)

Junyang Shao voted and added 1 comment

Votes added by Junyang Shao

1 comment

Related details

Gopher Robot (Gerrit)

Gopher Robot submitted the change

Change information

Keith Randall (Gerrit)

Keith Randall has uploaded the change for review

Commit message

Change diff

Change information

Related details

Keith Randall (Gerrit)

Keith Randall voted Code-Review+1

Related details

Junyang Shao (Gerrit)

Junyang Shao voted Code-Review+2

Related details

Carlos Amedee (Gerrit)

Carlos Amedee submitted the change

Change information