[go] net/netip: correct ipv6 address in ParsePrefix comment

Ian Lance Taylor (Gerrit)

unread,

Feb 1, 2022, 4:28:22 PM2/1/22

to Brad Fitzpatrick, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Brad Fitzpatrick.

Ian Lance Taylor would like Brad Fitzpatrick to review this change.

net/netip: correct ipv6 address in ParsePrefix comment

Fixes #50950

Change-Id: Iea94dba6e57d7e7985d4ae06a9b59ad126568599
---
M src/net/netip/netip.go
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/net/netip/netip.go b/src/net/netip/netip.go
index 591d38a..f27984a 100644
--- a/src/net/netip/netip.go
+++ b/src/net/netip/netip.go
@@ -1288,7 +1288,7 @@
 func (p Prefix) IsSingleIP() bool { return p.bits != 0 && int(p.bits) == p.ip.BitLen() }
 
 // ParsePrefix parses s as an IP address prefix.
-// The string can be in the form "192.168.1.0/24" or "2001::db8::/32",
+// The string can be in the form "192.168.1.0/24" or "2001:db8::/32",
 // the CIDR notation defined in RFC 4632 and RFC 4291.
 //
 // Note that masked address bits are not zeroed. Use Masked for that.

To view, visit change 382294. To unsubscribe, or for help writing mail filters, visit settings.

Tobias Klauser (Gerrit)

unread,

Feb 2, 2022, 5:28:15 AM2/2/22

to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Gopher Robot, Brad Fitzpatrick, golang-co...@googlegroups.com

Attention is currently required from: Brad Fitzpatrick, Ian Lance Taylor.

Patch set 1:Code-Review +2

View Change

To view, visit change 382294. To unsubscribe, or for help writing mail filters, visit settings.

Brad Fitzpatrick (Gerrit)

unread,

Feb 2, 2022, 9:49:15 AM2/2/22

to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Brad Fitzpatrick, Tobias Klauser, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Ian Lance Taylor.

Patch set 1:Code-Review +2

View Change

To view, visit change 382294. To unsubscribe, or for help writing mail filters, visit settings.

Ian Lance Taylor (Gerrit)

unread,

Feb 2, 2022, 10:21:20 PM2/2/22

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Brad Fitzpatrick, Tobias Klauser, Gopher Robot, golang-co...@googlegroups.com

Ian Lance Taylor submitted this change.

View Change

Approvals:
  Brad Fitzpatrick: Looks good to me, approved
  Tobias Klauser: Looks good to me, approved
  Ian Lance Taylor: Trusted; Run TryBots
  Gopher Robot: TryBots succeeded

net/netip: correct ipv6 address in ParsePrefix comment

Fixes #50950

Change-Id: Iea94dba6e57d7e7985d4ae06a9b59ad126568599

Reviewed-on: https://go-review.googlesource.com/c/go/+/382294
Trust: Ian Lance Taylor <ia...@golang.org>
Run-TryBot: Ian Lance Taylor <ia...@golang.org>
TryBot-Result: Gopher Robot <go...@golang.org>
Reviewed-by: Tobias Klauser <tobias....@gmail.com>
Reviewed-by: Brad Fitzpatrick <brad...@golang.org>
---
M src/net/netip/netip.go
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/net/netip/netip.go b/src/net/netip/netip.go
index 591d38a..f27984a 100644
--- a/src/net/netip/netip.go
+++ b/src/net/netip/netip.go
@@ -1288,7 +1288,7 @@
 func (p Prefix) IsSingleIP() bool { return p.bits != 0 && int(p.bits) == p.ip.BitLen() }
 
 // ParsePrefix parses s as an IP address prefix.
-// The string can be in the form "192.168.1.0/24" or "2001::db8::/32",
+// The string can be in the form "192.168.1.0/24" or "2001:db8::/32",
 // the CIDR notation defined in RFC 4632 and RFC 4291.
 //
 // Note that masked address bits are not zeroed. Use Masked for that.

To view, visit change 382294. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward