[oscar] all: go fix -stringsseq ./...
1 view
Skip to first unread message
Hyang-Ah Hana Kim (Gerrit)
Feb 26, 2026, 10:07:56 PM (20 hours ago) Feb 26
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Hyang-Ah Hana Kim has uploaded the change for review![]( "Open in Gerrit")
Commit message
all: go fix -stringsseq ./...
Change-Id: Ib3bbde35bfbd309d73f3e1b810fdca2e3d9079ba
Change diff
diff --git a/internal/gerrit/testing.go b/internal/gerrit/testing.go
index 23e86f1..b247e51 100644
--- a/internal/gerrit/testing.go
+++ b/internal/gerrit/testing.go
@@ -266,7 +266,7 @@
case reflect.Int:
// For ints just put all the values on one line.
var ints []int
- for _, vi := range strings.Fields(val) {
+ for vi := range strings.FieldsSeq(val) {
i, err := strconv.Atoi(vi)
if err != nil {
return "", fmt.Errorf("%s: field %q: %v", filename, key, err)
@@ -279,7 +279,7 @@
// For strings just put all the values on one line.
// Strings are space separated, no quoting.
var strs []string
- for _, vs := range strings.Fields(val) {
+ for vs := range strings.FieldsSeq(val) {
vs = strings.TrimSpace(vs)
if vs == "" {
continue
diff --git a/internal/github/testing.go b/internal/github/testing.go
index 4d988fa..87995f3 100644
--- a/internal/github/testing.go
+++ b/internal/github/testing.go
@@ -330,7 +330,7 @@
issue.ClosedAt = tm
case "Labels":
if val != "" {
- for _, name := range strings.Split(val, ", ") {
+ for name := range strings.SplitSeq(val, ", ") {
issue.Labels = append(issue.Labels, Label{Name: name})
}
}
diff --git a/internal/secret/secret.go b/internal/secret/secret.go
index 1ac3eb7..ab66b03 100644
--- a/internal/secret/secret.go
+++ b/internal/secret/secret.go
@@ -77,7 +77,7 @@
func openNetrc(file string) ReadOnlyMap {
m := make(ReadOnlyMap)
if data, err := os.ReadFile(file); err == nil {
- for _, line := range strings.Split(string(data), "\n") {
+ for line := range strings.SplitSeq(string(data), "\n") {
f := strings.Fields(line)
if len(f) == 6 && f[0] == "machine" && f[2] == "login" && f[4] == "password" {
m[f[1]] = f[3] + ":" + f[5]
Change information
Files:
- M internal/gerrit/testing.go
- M internal/github/testing.go
- M internal/secret/secret.go
Change size: XS
Delta: 3 files changed, 4 insertions(+), 4 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
4:21 PM (2 hours ago) 4:21 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Ian Lance Taylor voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
4:40 PM (2 hours ago) 4:40 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
4:44 PM (2 hours ago) 4:44 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Hyang-Ah Hana Kim submitted the change![]( "Open in Gerrit")
Change information
Commit message:
all: go fix -stringsseq ./...
Change-Id: Ib3bbde35bfbd309d73f3e1b810fdca2e3d9079ba
Reviewed-on: https://go-review.googlesource.com/c/oscar/+/749650
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M internal/gerrit/testing.go
- M internal/github/testing.go
- M internal/secret/secret.go
Change size: XS
Delta: 3 files changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Ian Lance Taylor
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages