[go/release-branch.go1.26] test/convert5: skip mipsle
Rongrong (Gerrit)
Rongrong has uploaded the change for review![]( "Open in Gerrit")
Commit message
test/convert5: skip mipsle
It's broken on 32-bit architectures, and mips (be) has been in the skip
list. mipsle is somehow forgotten, so add it.
Updates #67304
Fixes #77836
Change-Id: I6d12185c21c37d0524d245e0a7025e30add1fb6b
Reviewed-on: https://go-review.googlesource.com/c/go/+/743740
Reviewed-by: Julian Zhu <jz53...@gmail.com>
Reviewed-by: Keith Randall <k...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
(cherry picked from commit d3ddc4854429185e6e06ca1f7628bb790404abb5)
Change diff
diff --git a/test/convert5.go b/test/convert5.go
index df247ca..6a78707 100644
--- a/test/convert5.go
+++ b/test/convert5.go
@@ -4,7 +4,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
-//go:build !wasm && !386 && !arm && !mips
+//go:build !wasm && !386 && !arm && !mips && !mipsle
// TODO fix this to work for wasm and 32-bit architectures.
// Doing more than this, however, expands the change.
Change information
- M test/convert5.go
Related details
Code-Review
Matching-Subject-Prefix
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Keith Randall added 1 comment![]( "Open in Gerrit")
We generally don't backport test-only things like this.
Is there a reason why this fix needs to be in 1.26?
Related details
- Rongrong
Code-Review
Matching-Subject-Prefix
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rongrong (Gerrit)
Rongrong uploaded new patchset![]( "Open in Gerrit")
Related details
- Rongrong
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rongrong (Gerrit)
Rongrong added 1 comment![]( "Open in Gerrit")
We generally don't backport test-only things like this.
Is there a reason why this fix needs to be in 1.26?
We (#67304) and AaronGrand (#77417) are adding builders for linux-mipsle. This bug generates failing CI on 1.26. This bug wouldn't have been introduced if we had a working builder (#75979) at that time when convert5 was added.
If having a failing CI in the release branch isn't a blocker of continuing the process of adding a builder, I am OK to abandon this CL.
(I said CL 748780 was the only one needed to fix CI, but it turned out I forgot this. Sorry for that.)
Related details
- Keith Randall
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Keith Randall voted and added 1 comment![]( "Open in Gerrit")
Votes added by Keith Randall
| Hold | +1 |
RongrongWe generally don't backport test-only things like this.
Is there a reason why this fix needs to be in 1.26?
We (#67304) and AaronGrand (#77417) are adding builders for linux-mipsle. This bug generates failing CI on 1.26. This bug wouldn't have been introduced if we had a working builder (#75979) at that time when convert5 was added.
If having a failing CI in the release branch isn't a blocker of continuing the process of adding a builder, I am OK to abandon this CL.
(I said CL 748780 was the only one needed to fix CI, but it turned out I forgot this. Sorry for that.)
Let's put this on ice for now. Getting the builder passing on tip is the main thing. Once we have that, we can discuss with the release team whether they think it is worth backporting this CL to get the 1.26 builder to pass.
Related details
- Rongrong
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Dmitri Shuralyov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dmitri Shuralyov
| Code-Review | +2 |
| Commit-Queue | +1 |
RongrongWe generally don't backport test-only things like this.
Is there a reason why this fix needs to be in 1.26?
Keith RandallWe (#67304) and AaronGrand (#77417) are adding builders for linux-mipsle. This bug generates failing CI on 1.26. This bug wouldn't have been introduced if we had a working builder (#75979) at that time when convert5 was added.
If having a failing CI in the release branch isn't a blocker of continuing the process of adding a builder, I am OK to abandon this CL.
(I said CL 748780 was the only one needed to fix CI, but it turned out I forgot this. Sorry for that.)
Let's put this on ice for now. Getting the builder passing on tip is the main thing. Once we have that, we can discuss with the release team whether they think it is worth backporting this CL to get the 1.26 builder to pass.
By now the builder is passing at tip, 1.25 release branch, x/ repos (all but x/tools), leaving 1.26 with only this test failure: https://ci.chromium.org/ui/p/golang/g/port-linux-mipsle/builders. Backport issue #77836 was approved, so let's proceed with this CL.
Related details
- Rongrong
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Dmitri Shuralyov voted Code-Review+1![]( "Open in Gerrit")
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Keith Randall voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Rongrong
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Related details
- Rongrong
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |