[mobile] [golang/go#59803] update minimal javac version to 1.8
Gerrit Bot (Gerrit)
Gerrit Bot has uploaded this change for review.
[golang/go#59803] update minimal javac version to 1.8
This might fix the issue.
Change-Id: I248ab312eedf091bbfd6ebf35c8990fbdf611fbc
GitHub-Last-Rev: 16824065cc67baaf81f7ba014101dbb651376516
GitHub-Pull-Request: golang/mobile#91
---
M cmd/gomobile/bind_androidapp.go
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/gomobile/bind_androidapp.go b/cmd/gomobile/bind_androidapp.go
index 3fa9cfa..f8fcabe 100644
--- a/cmd/gomobile/bind_androidapp.go
+++ b/cmd/gomobile/bind_androidapp.go
@@ -245,7 +245,7 @@
}
const (
- javacTargetVer = "1.7"
+ javacTargetVer = "1.8"
minAndroidAPI = 16
)
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Gopher Robot (Gerrit)
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
Hajime Hoshi (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hyang-Ah Hana Kim.
Patch set 1:Run-TryBot +1Code-Review +2
1 comment:
Patchset:
LGTM
Hana, Dmitri, please take a look. Thanks,
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Hajime Hoshi (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hyang-Ah Hana Kim.
2 comments:
Commit Message:
Patch Set #1, Line 7:
[golang/go#59803] update minimal javac version to 1.8```
cmd/gomobile: update minimal javac version to 1.8
```Add this line
```
Fixes golang/go#50803
```
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Hajime Hoshi (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hyang-Ah Hana Kim.
1 comment:
Patchset:
Please check the test failures.
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Hajime Hoshi (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hyang-Ah Hana Kim.
Patch set 1:Code-Review +1
Hajime Hoshi (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hyang-Ah Hana Kim.
Patch set 1:-Code-Review
Gerrit Bot (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hajime Hoshi, Hyang-Ah Hana Kim.
Gerrit Bot uploaded patch set #2 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Hajime Hoshi, TryBot-Result-1 by Gopher Robot
[golang/go#59803] update minimal javac version to 1.8
This might fix the issue.
Change-Id: I248ab312eedf091bbfd6ebf35c8990fbdf611fbc
GitHub-Last-Rev: 4bd774d66b4549d7cdccb7c3b9ad483893bbd6e7
GitHub-Pull-Request: golang/mobile#91
---
M cmd/gomobile/bind.go
M cmd/gomobile/bind_androidapp.go
M cmd/gomobile/bind_test.go
M cmd/gomobile/gendex.go
4 files changed, 5 insertions(+), 5 deletions(-)
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hajime Hoshi, Hyang-Ah Hana Kim.
Gerrit Bot uploaded patch set #3 to this change.
[golang/go#59803] update minimal javac version to 1.8
This might fix the issue.
Change-Id: I248ab312eedf091bbfd6ebf35c8990fbdf611fbc
GitHub-Last-Rev: 35c69fe9ceb69b8b5d2144bee234011e3116b992
GitHub-Pull-Request: golang/mobile#91
---
M cmd/gomobile/bind.go
M cmd/gomobile/bind_androidapp.go
M cmd/gomobile/bind_test.go
M cmd/gomobile/gendex.go
4 files changed, 5 insertions(+), 5 deletions(-)
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hajime Hoshi, Hyang-Ah Hana Kim.
Gerrit Bot uploaded patch set #4 to this change.
cmd/gomobile: update minimal javac version to 1.8
Fixes golang/go#59803
Change-Id: I248ab312eedf091bbfd6ebf35c8990fbdf611fbc
GitHub-Last-Rev: c61def7df008265555efa24ef27d262d7fd9b644
GitHub-Pull-Request: golang/mobile#91
---
M cmd/gomobile/bind.go
M cmd/gomobile/bind_androidapp.go
M cmd/gomobile/bind_test.go
M cmd/gomobile/gendex.go
4 files changed, 5 insertions(+), 5 deletions(-)
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Hajime Hoshi, Hyang-Ah Hana Kim.
Gerrit Bot uploaded patch set #5 to this change.
cmd/gomobile: upgrade minimal javac version to 1.8
Fixes golang/go#59803
Change-Id: I248ab312eedf091bbfd6ebf35c8990fbdf611fbc
GitHub-Last-Rev: c61def7df008265555efa24ef27d262d7fd9b644
GitHub-Pull-Request: golang/mobile#91
---
M cmd/gomobile/bind.go
M cmd/gomobile/bind_androidapp.go
M cmd/gomobile/bind_test.go
M cmd/gomobile/gendex.go
4 files changed, 5 insertions(+), 5 deletions(-)
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Hajime Hoshi, Hyang-Ah Hana Kim.
Patch set 5:Run-TryBot +1
Hajime Hoshi (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
Patch set 5:Code-Review +2
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
Patch set 5:Code-Review +1
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
2 comments:
Commit Message:
Patch Set #1, Line 7:
[golang/go#59803] update minimal javac version to 1.8``` […]
Done.
Add this line […]
Done. (#59803 seems like the right one.)
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.
Hyang-Ah Hana Kim (Gerrit)
Gopher Robot (Gerrit)
Gopher Robot submitted this change.
cmd/gomobile: upgrade minimal javac version to 1.8
Fixes golang/go#59803
Change-Id: I248ab312eedf091bbfd6ebf35c8990fbdf611fbc
GitHub-Last-Rev: c61def7df008265555efa24ef27d262d7fd9b644
GitHub-Pull-Request: golang/mobile#91
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/488555
TryBot-Result: Gopher Robot <go...@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Hajime Hoshi <hajim...@gmail.com>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Run-TryBot: Dmitri Shuralyov <dmit...@golang.org>
---
M cmd/gomobile/bind.go
M cmd/gomobile/bind_androidapp.go
M cmd/gomobile/bind_test.go
M cmd/gomobile/gendex.go
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cmd/gomobile/bind.go b/cmd/gomobile/bind.go
index 54eaa4b..11b4062 100644
--- a/cmd/gomobile/bind.go
+++ b/cmd/gomobile/bind.go
@@ -44,7 +44,7 @@
the module import wizard (File > New > New Module > Import .JAR or
.AAR package), and setting it as a new dependency
(File > Project Structure > Dependencies). This requires 'javac'
-(version 1.7+) and Android SDK (API level 16 or newer) to build the
+(version 1.8+) and Android SDK (API level 16 or newer) to build the
library for Android. The ANDROID_HOME and ANDROID_NDK_HOME environment
variables can be used to specify the Android SDK and NDK if they are
not in the default locations. Use the -javapkg flag to specify the Java
diff --git a/cmd/gomobile/bind_androidapp.go b/cmd/gomobile/bind_androidapp.go
index 3fa9cfa..f8fcabe 100644
--- a/cmd/gomobile/bind_androidapp.go
+++ b/cmd/gomobile/bind_androidapp.go
@@ -245,7 +245,7 @@
}
const (
- javacTargetVer = "1.7"
+ javacTargetVer = "1.8"
minAndroidAPI = 16
)
diff --git a/cmd/gomobile/bind_test.go b/cmd/gomobile/bind_test.go
index fa6b0ef..22a88d5 100644
--- a/cmd/gomobile/bind_test.go
+++ b/cmd/gomobile/bind_test.go
@@ -190,7 +190,7 @@
mkdir -p $WORK/src-android-arm
PWD=$WORK/src-android-arm GOMODCACHE=$GOPATH/pkg/mod GOOS=android GOARCH=arm CC=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang CXX=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang++ CGO_ENABLED=1 GOARM=7 GOPATH=$WORK:$GOPATH go mod tidy
PWD=$WORK/src-android-arm GOMODCACHE=$GOPATH/pkg/mod GOOS=android GOARCH=arm CC=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang CXX=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang++ CGO_ENABLED=1 GOARM=7 GOPATH=$WORK:$GOPATH go build -x -buildmode=c-shared -o=$WORK/android/src/main/jniLibs/armeabi-v7a/libgojni.so ./gobind
-PWD=$WORK/java javac -d $WORK/javac-output -source 1.7 -target 1.7 -bootclasspath {{.AndroidPlatform}}/android.jar *.java
+PWD=$WORK/java javac -d $WORK/javac-output -source 1.8 -target 1.8 -bootclasspath {{.AndroidPlatform}}/android.jar *.java
jar c -C $WORK/javac-output .
`))
diff --git a/cmd/gomobile/gendex.go b/cmd/gomobile/gendex.go
index 88cf554..bfc2ad7 100644
--- a/cmd/gomobile/gendex.go
+++ b/cmd/gomobile/gendex.go
@@ -74,8 +74,8 @@
}
cmd := exec.Command(
"javac",
- "-source", "1.7",
- "-target", "1.7",
+ "-source", "1.8",
+ "-target", "1.8",
"-bootclasspath", platform+"/android.jar",
"-d", tmpdir+"/work",
)
To view, visit change 488555. To unsubscribe, or for help writing mail filters, visit settings.