[pkgsite] internal/frontend/fetchserver: add test for "synctest" shortcut
3 views
Skip to first unread message
Felix Stein (Gerrit)
Nov 5, 2025, 4:33:35 PM (5 days ago) Nov 5
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Felix Stein has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/frontend/fetchserver: add test for "synctest" shortcut
The previous commit 5cd44362491235c04771c4d8dfcacdd265ada373 added tests
that internal packages are not found by a shortcut. This change adds a
test that a package (like synctest) which has an internal and public
package is found.
Updates golang/go#76136
Change-Id: I80297ee6fff7fbb1c2d5bd2188a387a39f24ac35
Change diff
diff --git a/internal/frontend/fetchserver/server_test.go b/internal/frontend/fetchserver/server_test.go
index 23d31bc..b62c02a 100644
--- a/internal/frontend/fetchserver/server_test.go
+++ b/internal/frontend/fetchserver/server_test.go
@@ -169,6 +169,14 @@
name: "asan",
suffix: "internal/asan",
},
+ {
+ name: "synctest",
+ suffix: "internal/synctest",
+ },
+ {
+ name: "synctest",
+ suffix: "testing/synctest",
+ },
},
},
{
@@ -683,6 +691,12 @@
wantLocation: "/net/http",
},
{
+ name: "stdlib shortcut (testing/synctest) with internal package (internal/synctest)",
+ urlPath: "/synctest",
+ wantStatusCode: http.StatusFound,
+ wantLocation: "/testing/synctest",
+ },
+ {
name: "stdlib shortcut with trailing slash",
urlPath: "/http/",
wantStatusCode: http.StatusMovedPermanently,
Change information
Files:
- M internal/frontend/fetchserver/server_test.go
Change size: S
Delta: 1 file changed, 14 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Nov 5, 2025, 4:35:53 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Message from Gopher Robot![]( "Open in Gerrit")
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felix Stein (Gerrit)
Nov 5, 2025, 4:40:53 PM (5 days ago) Nov 5
to goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com
Felix Stein added 1 comment![]( "Open in Gerrit")
File internal/frontend/fetchserver/server_test.go
Line 154, Patchset 1 (Latest):
versions: []string{"v1.13.0"},Felix Stein . resolved
The synctest package did not exist at this point but I don't think this test data has to match the actual stdlib?
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Nov 5, 2025, 4:46:18 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Felix Stein
Nicholas Husin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Commit-Queue | +1 |
2 comments
File internal/frontend/fetchserver/server_test.go
Line 154, Patchset 1 (Latest):
versions: []string{"v1.13.0"},Felix Stein . resolved
The synctest package did not exist at this point but I don't think this test data has to match the actual stdlib?
Nicholas Husin
Indeed, this is just fake data used solely in tests.
I'll trigger our tests, and it should show that everything works fine.
Line 694, Patchset 1 (Latest):
name: "stdlib shortcut (testing/synctest) with internal package (internal/synctest)",Nicholas Husin . unresolved
Thanks for the change!
LGTM. If you'd allow me to be a bit nitpicky here though, I think putting this particular test case just below the other internal ones would be nice :-)
Related details
Attention is currently required from:
- Felix Stein
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felix Stein (Gerrit)
Nov 5, 2025, 4:51:08 PM (5 days ago) Nov 5
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Felix Stein and Nicholas Husin
Felix Stein uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Felix Stein
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felix Stein (Gerrit)
Nov 5, 2025, 4:52:29 PM (5 days ago) Nov 5
to goph...@pubsubhelper.golang.org, Go LUCI, kokoro, Nicholas Husin, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Felix Stein added 1 comment![]( "Open in Gerrit")
File internal/frontend/fetchserver/server_test.go
Line 694, Patchset 1:
name: "stdlib shortcut (testing/synctest) with internal package (internal/synctest)",Nicholas Husin . resolved
Thanks for the change!
LGTM. If you'd allow me to be a bit nitpicky here though, I think putting this particular test case just below the other internal ones would be nice :-)
Felix Stein
Moved the test. The two test above the old location were doing shortcut tests so I thought that would be a fine place.
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Nov 5, 2025, 4:56:37 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, Go LUCI, kokoro, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Felix Stein
Nicholas Husin voted![]( "Open in Gerrit")
Attention is currently required from:
- Felix Stein
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Nov 5, 2025, 4:56:43 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, Nicholas Husin, Go LUCI, kokoro, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Felix Stein
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Felix Stein
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junyang Shao (Gerrit)
Nov 5, 2025, 4:57:16 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, Go LUCI, kokoro, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Felix Stein
Junyang Shao voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Felix Stein
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Nov 5, 2025, 5:11:50 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, Go LUCI, Junyang Shao, Nicholas Husin, Nicholas Husin, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Felix Stein
kokoro voted kokoro-CI+1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/2dbcdb2c-2abc-4fa6-9c2a-d774d55d13ea
| kokoro-CI | +1 |
Related details
Attention is currently required from:
- Felix Stein
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Nov 5, 2025, 5:12:56 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, Go LUCI, Junyang Shao, Nicholas Husin, Nicholas Husin, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Felix Stein
kokoro voted kokoro-CI-1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/f6593093-f7c4-45db-ba04-896651e249cf
| kokoro-CI | -1 |
Related details
Attention is currently required from:
- Felix Stein
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Nov 5, 2025, 5:23:43 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, kokoro, Go LUCI, Junyang Shao, Nicholas Husin, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Felix Stein
Nicholas Husin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Nicholas Husin . resolved
Hmm, Kokoro is unexpectedly failing.
Seems to be an unrelated error and likely to be a flake from a quick read though.
Revoting to retrigger Kokoro.
Nicholas Husin (Gerrit)
Nov 5, 2025, 9:09:43 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, kokoro, Go LUCI, Junyang Shao, Nicholas Husin, Gopher Robot, golang-co...@googlegroups.com
Nicholas Husin removed a vote from this change![]( "Open in Gerrit")
Removed kokoro-CI-1 by kokoro <noreply...@google.com>
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Nov 5, 2025, 9:11:51 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, Junyang Shao, Nicholas Husin, Gopher Robot, golang-co...@googlegroups.com
Nicholas Husin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Nicholas Husin . resolved
Hmm, Kokoro is unexpectedly failing.
Seems to be an unrelated error and likely to be a flake from a quick read though.Revoting to retrigger Kokoro.
Nicholas Husin
Still didn't trigger :-(
Let's try again after removing the `kokoro-CI-1` vote and the Kokoro reviewer.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Nov 5, 2025, 9:26:45 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, Go LUCI, Junyang Shao, Nicholas Husin, Gopher Robot, golang-co...@googlegroups.com
Nicholas Husin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Husin
| TryBot-Bypass | +1 |
1 comment
Patchset-level comments
Nicholas Husin . resolved
Nicholas HusinHmm, Kokoro is unexpectedly failing.
Seems to be an unrelated error and likely to be a flake from a quick read though.Revoting to retrigger Kokoro.
Still didn't trigger :-(
Let's try again after removing the `kokoro-CI-1` vote and the Kokoro reviewer.
Nicholas Husin
Ouch, I guess triggering a new Kokoro run requires uploading a new Patchset (i.e. the uploader can run `git commit --amend --date=now --no-edit` and re-upload the CL).
Given that Kokoro had a passing build with the same content from earlier though (http://sponge2.corp.google.com/2dbcdb2c-2abc-4fa6-9c2a-d774d55d13ea), it seems fair to bypass this rather than unduly burdening the uploader.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Nov 5, 2025, 9:26:53 PM (5 days ago) Nov 5
to Felix Stein, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Junyang Shao, Nicholas Husin, Gopher Robot, golang-co...@googlegroups.com
Nicholas Husin submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/frontend/fetchserver: add test for "synctest" shortcut
The previous commit 5cd44362491235c04771c4d8dfcacdd265ada373 added tests
that internal packages are not found by a shortcut. This change adds a
test that a package (like synctest) which has an internal and public
package is found.
Updates golang/go#76136
Change-Id: I80297ee6fff7fbb1c2d5bd2188a387a39f24ac35
TryBot-Bypass: Nicholas Husin <n...@golang.org>
Reviewed-by: Nicholas Husin <n...@golang.org>
Reviewed-by: Junyang Shao <shaoj...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Auto-Submit: Nicholas Husin <n...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M internal/frontend/fetchserver/server_test.go
Change size: S
Delta: 1 file changed, 14 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +1 by Junyang Shao, +2 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI, TryBot-Bypass+1 by Nicholas Husin
kokoro-CI-Passes: TryBot-Bypass+1 by Nicholas Husin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages