[tools] gopls/internal/test/integration/workspace: fix broken test

0 views
Skip to first unread message

Alan Donovan (Gerrit)

unread,
3:26 PM (8 hours ago) 3:26 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Alan Donovan has uploaded the change for review

Commit message

gopls/internal/test/integration/workspace: fix broken test

(Semantic conflict between two CL 711340 and CL 711320.)

Fixes golang/go#75911
Change-Id: I98960730147c0c548da2660b72b36d80cb010671

Change diff

diff --git a/gopls/internal/test/integration/workspace/standalone_test.go b/gopls/internal/test/integration/workspace/standalone_test.go
index 6cd8e7f..9a4f3b7 100644
--- a/gopls/internal/test/integration/workspace/standalone_test.go
+++ b/gopls/internal/test/integration/workspace/standalone_test.go
@@ -29,7 +29,6 @@
 }
 -- lib/ignore.go --
 //go:build ignore
-// +build ignore
 
 package main
 
@@ -164,7 +163,6 @@
 package lib // without this package, files are loaded as command-line-arguments
 -- ignore.go --
 //go:build ignore
-// +build ignore
 
 package main
 
@@ -173,7 +171,6 @@
 func main() {}
 -- standalone.go --
 //go:build standalone
-// +build standalone
 
 package main

Change information

Files:
  • M gopls/internal/test/integration/workspace/standalone_test.go
Change size: XS
Delta: 1 file changed, 0 insertions(+), 3 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I98960730147c0c548da2660b72b36d80cb010671
Gerrit-Change-Number: 712182
Gerrit-PatchSet: 1
Gerrit-Owner: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
3:27 PM (8 hours ago) 3:27 PM
to goph...@pubsubhelper.golang.org, Ian Alexander, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ian Alexander

Alan Donovan voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Alexander
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I98960730147c0c548da2660b72b36d80cb010671
Gerrit-Change-Number: 712182
Gerrit-PatchSet: 1
Gerrit-Owner: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Ian Alexander <ji...@google.com>
Gerrit-Attention: Ian Alexander <ji...@google.com>
Gerrit-Comment-Date: Wed, 15 Oct 2025 19:27:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
3:27 PM (8 hours ago) 3:27 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Ian Alexander

Alan Donovan uploaded new patchset

Alan Donovan uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Ian Alexander
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I98960730147c0c548da2660b72b36d80cb010671
Gerrit-Change-Number: 712182
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Ian Alexander <ji...@google.com>
Gerrit-Attention: Ian Alexander <ji...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
3:27 PM (8 hours ago) 3:27 PM
to goph...@pubsubhelper.golang.org, Go LUCI, Ian Alexander, golang-co...@googlegroups.com
Attention needed from Ian Alexander

Alan Donovan voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Alexander
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I98960730147c0c548da2660b72b36d80cb010671
Gerrit-Change-Number: 712182
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Ian Alexander <ji...@google.com>
Gerrit-Attention: Ian Alexander <ji...@google.com>
Gerrit-Comment-Date: Wed, 15 Oct 2025 19:27:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
5:10 PM (7 hours ago) 5:10 PM
to Alan Donovan, goph...@pubsubhelper.golang.org, Michael Matloob, Go LUCI, Ian Alexander, golang-co...@googlegroups.com
Attention needed from Alan Donovan, Ian Alexander and Michael Matloob

David Chase voted and added 1 comment

Votes added by David Chase

Code-Review+2

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Ian Alexander
  • Michael Matloob
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I98960730147c0c548da2660b72b36d80cb010671
Gerrit-Change-Number: 712182
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Ian Alexander <ji...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Ian Alexander <ji...@google.com>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Wed, 15 Oct 2025 21:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Gopher Robot (Gerrit)

unread,
5:11 PM (7 hours ago) 5:11 PM
to Alan Donovan, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Michael Matloob, Go LUCI, Ian Alexander, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
gopls/internal/test/integration/workspace: fix broken test

(Semantic conflict between CL 711340 and CL 711320.)

Fixes golang/go#75911
Change-Id: I98960730147c0c548da2660b72b36d80cb010671
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: David Chase <drc...@google.com>
Files:
  • M gopls/internal/test/integration/workspace/standalone_test.go
Change size: XS
Delta: 1 file changed, 0 insertions(+), 3 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I98960730147c0c548da2660b72b36d80cb010671
Gerrit-Change-Number: 712182
Gerrit-PatchSet: 3
Gerrit-Owner: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages