[vscode-go] .github/workflows: use delve at master

3 views
Skip to first unread message

Suzy Mueller (Gerrit)

unread,
Feb 23, 2021, 9:34:19 PM2/23/21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Suzy Mueller has uploaded this change for review.

View Change

.github/workflows: use delve at master

In order to test the latest changes to delve dap, we have to
pull in the latest code. This change does this for the workflows.

go get package@version is supported in both go1.15 and in go1.16,
with go1.15 requiring GO111MODULE=on, which we already set to
download the Go tools.

Change-Id: I6d89b77edc6b028dd8e8ed9bfe4e82ccdfdaba73
---
M .github/workflows/release-nightly.yml
M .github/workflows/test-long-all.yml
M .github/workflows/test-long.yml
M .github/workflows/test-smoke.yml
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/release-nightly.yml b/.github/workflows/release-nightly.yml
index 19bb203..0fd28c3 100644
--- a/.github/workflows/release-nightly.yml
+++ b/.github/workflows/release-nightly.yml
@@ -63,7 +63,7 @@
go get github.com/cweill/gotests/...
go get github.com/rogpeppe/godef
go get github.com/ramya-rao-a/go-outline
- go get github.com/go-delve/delve/cmd/dlv
+ go get github.com/go-delve/delve/cmd/dlv@master
env:
GO111MODULE: on
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
diff --git a/.github/workflows/test-long-all.yml b/.github/workflows/test-long-all.yml
index 22c5bd0..a999273 100644
--- a/.github/workflows/test-long-all.yml
+++ b/.github/workflows/test-long-all.yml
@@ -59,7 +59,7 @@
go get github.com/cweill/gotests/...
go get github.com/rogpeppe/godef
go get github.com/ramya-rao-a/go-outline
- go get github.com/go-delve/delve/cmd/dlv
+ go get github.com/go-delve/delve/cmd/dlv@master
env:
GO111MODULE: on
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
diff --git a/.github/workflows/test-long.yml b/.github/workflows/test-long.yml
index cf5d4c6..4d6119b 100644
--- a/.github/workflows/test-long.yml
+++ b/.github/workflows/test-long.yml
@@ -58,7 +58,7 @@
go get github.com/cweill/gotests/...
go get github.com/rogpeppe/godef
go get github.com/ramya-rao-a/go-outline
- go get github.com/go-delve/delve/cmd/dlv
+ go get github.com/go-delve/delve/cmd/dlv@master
env:
GO111MODULE: on
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
diff --git a/.github/workflows/test-smoke.yml b/.github/workflows/test-smoke.yml
index 2dfcda2..9dcb91c 100644
--- a/.github/workflows/test-smoke.yml
+++ b/.github/workflows/test-smoke.yml
@@ -56,7 +56,7 @@
go get github.com/cweill/gotests/...
go get github.com/rogpeppe/godef
go get github.com/ramya-rao-a/go-outline
- go get github.com/go-delve/delve/cmd/dlv
+ go get github.com/go-delve/delve/cmd/dlv@master
env:
GO111MODULE: on
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"

To view, visit change 295416. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: vscode-go
Gerrit-Branch: master
Gerrit-Change-Id: I6d89b77edc6b028dd8e8ed9bfe4e82ccdfdaba73
Gerrit-Change-Number: 295416
Gerrit-PatchSet: 1
Gerrit-Owner: Suzy Mueller <suz...@golang.org>
Gerrit-Reviewer: Suzy Mueller <suz...@golang.org>
Gerrit-MessageType: newchange

kokoro (Gerrit)

unread,
Feb 23, 2021, 9:46:08 PM2/23/21
to Suzy Mueller, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/c35be14c-1578-4b7e-84ac-9bf1b6910f80

Patch set 1:TryBot-Result +1

View Change

    To view, visit change 295416. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: vscode-go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6d89b77edc6b028dd8e8ed9bfe4e82ccdfdaba73
    Gerrit-Change-Number: 295416
    Gerrit-PatchSet: 1
    Gerrit-Owner: Suzy Mueller <suz...@golang.org>
    Gerrit-Reviewer: Suzy Mueller <suz...@golang.org>
    Gerrit-Reviewer: kokoro <noreply...@google.com>
    Gerrit-Comment-Date: Wed, 24 Feb 2021 02:46:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Hyang-Ah Hana Kim (Gerrit)

    unread,
    Feb 24, 2021, 12:13:23 AM2/24/21
    to Suzy Mueller, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, kokoro, golang-co...@googlegroups.com

    Attention is currently required from: Suzy Mueller.

    Patch set 1:Code-Review +2

    View Change

      To view, visit change 295416. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: vscode-go
      Gerrit-Branch: master
      Gerrit-Change-Id: I6d89b77edc6b028dd8e8ed9bfe4e82ccdfdaba73
      Gerrit-Change-Number: 295416
      Gerrit-PatchSet: 1
      Gerrit-Owner: Suzy Mueller <suz...@golang.org>
      Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Reviewer: Suzy Mueller <suz...@golang.org>
      Gerrit-Reviewer: kokoro <noreply...@google.com>
      Gerrit-Attention: Suzy Mueller <suz...@golang.org>
      Gerrit-Comment-Date: Wed, 24 Feb 2021 05:13:20 +0000

      Suzy Mueller (Gerrit)

      unread,
      Feb 24, 2021, 10:56:03 AM2/24/21
      to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hyang-Ah Hana Kim, kokoro, golang-co...@googlegroups.com

      Suzy Mueller submitted this change.

      View Change

      Approvals: Hyang-Ah Hana Kim: Looks good to me, approved Suzy Mueller: Trusted; Run TryBots kokoro: TryBots succeeded
      .github/workflows: use delve at master

      In order to test the latest changes to delve dap, we have to
      pull in the latest code. This change does this for the workflows.

      go get package@version is supported in both go1.15 and in go1.16,
      with go1.15 requiring GO111MODULE=on, which we already set to
      download the Go tools.

      Change-Id: I6d89b77edc6b028dd8e8ed9bfe4e82ccdfdaba73
      Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/295416
      Trust: Suzy Mueller <suz...@golang.org>
      Run-TryBot: Suzy Mueller <suz...@golang.org>
      TryBot-Result: kokoro <noreply...@google.com>
      Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>

      To view, visit change 295416. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: vscode-go
      Gerrit-Branch: master
      Gerrit-Change-Id: I6d89b77edc6b028dd8e8ed9bfe4e82ccdfdaba73
      Gerrit-Change-Number: 295416
      Gerrit-PatchSet: 2
      Gerrit-Owner: Suzy Mueller <suz...@golang.org>
      Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Reviewer: Suzy Mueller <suz...@golang.org>
      Gerrit-Reviewer: kokoro <noreply...@google.com>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages