[pkgsite] internal/index: Format to nanoseconds for index URL.
0 views
Skip to first unread message
Jean Barkhuysen (Gerrit)
2:30 PM (8 hours ago) 2:30 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Jean Barkhuysen has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/index: Format to nanoseconds for index URL.
The golang index supports both:
- https://index.golang.org/index?since=2019-04-10T20:30:42Z&limit=3
- https://index.golang.org/index?since=2019-04-10T20:30:42.400000Z&limit=3
Since this is part of the checkpointing cursor behaviour that the worker relies
on to make progress, a higher precision means less change of missing something.
So, this change makes us use the highest precision available.
Note that since postgres only has microsecond granularity we're actually going
to be querying at microsecond granularity, but anyways, that's just a semantic
detail as far as this change is concerned. We still get higher precision.
(This change was inspired by our debugging cursor progress issues against our
internal golang-index https://github.com/netflix-skunkworks/golang-index).
Change-Id: I32d410214a104a8d694ec6edf9cba4a94c579f41
Change diff
diff --git a/internal/index/index.go b/internal/index/index.go
index f331d75..33a408c 100644
--- a/internal/index/index.go
+++ b/internal/index/index.go
@@ -43,7 +43,7 @@
func (c *Client) pollURL(since time.Time, limit int) string {
values := url.Values{}
- values.Set("since", since.Format(time.RFC3339))
+ values.Set("since", since.Format(time.RFC3339Nano))
if limit > 0 {
values.Set("limit", strconv.Itoa(limit))
}
Change information
Files:
- M internal/index/index.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jean Barkhuysen (Gerrit)
2:31 PM (8 hours ago) 2:31 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Jean Barkhuysen uploaded new patchset![]( "Open in Gerrit")
Jean Barkhuysen uploaded patch set #2 to this change.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jean Barkhuysen (Gerrit)
2:35 PM (8 hours ago) 2:35 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Jean Barkhuysen uploaded new patchset![]( "Open in Gerrit")
Jean Barkhuysen uploaded patch set #4 to this change.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jean Barkhuysen (Gerrit)
2:36 PM (8 hours ago) 2:36 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Jean Barkhuysen uploaded new patchset![]( "Open in Gerrit")
Jean Barkhuysen uploaded patch set #5 to this change.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
4:15 PM (6 hours ago) 4:15 PM
to Jean Barkhuysen, goph...@pubsubhelper.golang.org, Jonathan Amsterdam, golang-co...@googlegroups.com
Attention needed from Jean Barkhuysen and Jonathan Amsterdam
Ethan Lee voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Jean Barkhuysen
- Jonathan Amsterdam
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jean Barkhuysen (Gerrit)
4:54 PM (6 hours ago) 4:54 PM
to goph...@pubsubhelper.golang.org, Ethan Lee, Jonathan Amsterdam, golang-co...@googlegroups.com
Attention needed from Jonathan Amsterdam
Jean Barkhuysen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Jean Barkhuysen . resolved
JFYI that i don't have trybots permission, so if somebody could help me kick those off I'd be appreciative! =)
Related details
Attention is currently required from:
- Jonathan Amsterdam
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
4:58 PM (6 hours ago) 4:58 PM
to Jean Barkhuysen, goph...@pubsubhelper.golang.org, Jonathan Amsterdam, golang-co...@googlegroups.com
Attention needed from Jean Barkhuysen and Jonathan Amsterdam
Ethan Lee voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ethan Lee
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jean Barkhuysen
- Jonathan Amsterdam
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
5:30 PM (5 hours ago) 5:30 PM
to Jean Barkhuysen, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Ethan Lee, Jonathan Amsterdam, golang-co...@googlegroups.com
Attention needed from Jean Barkhuysen and Jonathan Amsterdam
kokoro voted kokoro-CI+1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/09b1ef4a-3374-4fc9-ad95-3718f921704d
| kokoro-CI | +1 |
Related details
Attention is currently required from:
- Jean Barkhuysen
- Jonathan Amsterdam
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
6:06 PM (5 hours ago) 6:06 PM
to Jean Barkhuysen, goph...@pubsubhelper.golang.org, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, Ethan Lee, Jonathan Amsterdam, golang-co...@googlegroups.com
Attention needed from Jean Barkhuysen and Jonathan Amsterdam
Sean Liao added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 6 (Latest):
internal/index: Format to nanoseconds for index URL.Sean Liao . unresolved
```suggestion
internal/index: format to nanoseconds for index URL.
```
Related details
Attention is currently required from:
- Jean Barkhuysen
- Jonathan Amsterdam
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jean Barkhuysen (Gerrit)
9:34 PM (1 hour ago) 9:34 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee, Jean Barkhuysen and Jonathan Amsterdam
Jean Barkhuysen uploaded new patchset![]( "Open in Gerrit")
Jean Barkhuysen uploaded patch set #7 to this change.
Following approvals got outdated and were removed:
- kokoro-CI-Passes: kokoro-CI+1 by kokoro
Related details
Attention is currently required from:
- Ethan Lee
- Jean Barkhuysen
- Jonathan Amsterdam
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jean Barkhuysen (Gerrit)
9:35 PM (1 hour ago) 9:35 PM
to goph...@pubsubhelper.golang.org, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, Ethan Lee, Jonathan Amsterdam, golang-co...@googlegroups.com
Attention needed from Ethan Lee, Jonathan Amsterdam and Sean Liao
Jean Barkhuysen added 1 comment![]( "Open in Gerrit")
Commit Message
```suggestion
internal/index: format to nanoseconds for index URL.
```
Attention is currently required from:
- Ethan Lee
- Jonathan Amsterdam
- Sean Liao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages