[vscode-go] docs: update docs for pinned command-line tools

3 views
Skip to first unread message

Jamal Carvalho (Gerrit)

unread,
Oct 4, 2022, 3:05:10 PM10/4/22
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Attention is currently required from: Hyang-Ah Hana Kim.

View Change

    To view, visit change 438635. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: vscode-go
    Gerrit-Branch: master
    Gerrit-Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
    Gerrit-Change-Number: 438635
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jamal Carvalho <ja...@golang.org>
    Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>
    Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Comment-Date: Tue, 04 Oct 2022 19:05:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    kokoro (Gerrit)

    unread,
    Oct 4, 2022, 3:15:54 PM10/4/22
    to Jamal Carvalho, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

    Attention is currently required from: Hyang-Ah Hana Kim.

    Kokoro presubmit build finished with status: SUCCESS
    Logs at: https://source.cloud.google.com/results/invocations/4386e68e-214b-499a-8929-65fe2f268a72

    Patch set 1:TryBot-Result +1

    View Change

      To view, visit change 438635. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: vscode-go
      Gerrit-Branch: master
      Gerrit-Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
      Gerrit-Change-Number: 438635
      Gerrit-PatchSet: 1
      Gerrit-Owner: Jamal Carvalho <ja...@golang.org>
      Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>
      Gerrit-Reviewer: kokoro <noreply...@google.com>
      Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Comment-Date: Tue, 04 Oct 2022 19:15:51 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Hyang-Ah Hana Kim (Gerrit)

      unread,
      Oct 4, 2022, 3:31:58 PM10/4/22
      to Jamal Carvalho, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, kokoro, golang-co...@googlegroups.com

      Attention is currently required from: Jamal Carvalho.

      Patch set 1:Code-Review +2

      View Change

      1 comment:

      To view, visit change 438635. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: vscode-go
      Gerrit-Branch: master
      Gerrit-Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
      Gerrit-Change-Number: 438635
      Gerrit-PatchSet: 1
      Gerrit-Owner: Jamal Carvalho <ja...@golang.org>
      Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>
      Gerrit-Reviewer: kokoro <noreply...@google.com>
      Gerrit-Attention: Jamal Carvalho <ja...@golang.org>
      Gerrit-Comment-Date: Tue, 04 Oct 2022 19:31:54 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Jamal Carvalho (Gerrit)

      unread,
      Oct 4, 2022, 3:58:20 PM10/4/22
      to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, kokoro, golang-co...@googlegroups.com

      Attention is currently required from: Hyang-Ah Hana Kim, Jamal Carvalho.

      View Change

      1 comment:

      • File docs/advanced.md:

        • Let's use the full link since this will be copied to wiki […]

          Done

      To view, visit change 438635. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: vscode-go
      Gerrit-Branch: master
      Gerrit-Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
      Gerrit-Change-Number: 438635
      Gerrit-PatchSet: 2
      Gerrit-Owner: Jamal Carvalho <ja...@golang.org>
      Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>
      Gerrit-Reviewer: kokoro <noreply...@google.com>
      Gerrit-Attention: Jamal Carvalho <ja...@golang.org>
      Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Comment-Date: Tue, 04 Oct 2022 19:58:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-MessageType: comment

      Jamal Carvalho (Gerrit)

      unread,
      Oct 4, 2022, 3:58:20 PM10/4/22
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

      Attention is currently required from: Hyang-Ah Hana Kim, Jamal Carvalho.

      Jamal Carvalho uploaded patch set #2 to this change.

      View Change

      The following approvals got outdated and were removed: Run-TryBot+1 by Jamal Carvalho, TryBot-Result+1 by kokoro

      docs: update docs for pinned command-line tools

      Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
      ---
      M docs/advanced.md
      M docs/tools.md
      2 files changed, 15 insertions(+), 1 deletion(-)

      To view, visit change 438635. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: vscode-go
      Gerrit-Branch: master
      Gerrit-Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
      Gerrit-Change-Number: 438635
      Gerrit-PatchSet: 2
      Gerrit-Owner: Jamal Carvalho <ja...@golang.org>
      Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>
      Gerrit-Reviewer: kokoro <noreply...@google.com>
      Gerrit-Attention: Jamal Carvalho <ja...@golang.org>
      Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-MessageType: newpatchset

      kokoro (Gerrit)

      unread,
      Oct 4, 2022, 4:14:19 PM10/4/22
      to Jamal Carvalho, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

      Attention is currently required from: Hyang-Ah Hana Kim, Jamal Carvalho.

      Kokoro presubmit build finished with status: SUCCESS
      Logs at: https://source.cloud.google.com/results/invocations/dafa58d2-0ad9-4bd2-a03e-9b2af2d3a979

      Patch set 2:TryBot-Result +1

      View Change

        To view, visit change 438635. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
        Gerrit-Change-Number: 438635
        Gerrit-PatchSet: 2
        Gerrit-Owner: Jamal Carvalho <ja...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-Attention: Jamal Carvalho <ja...@golang.org>
        Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Comment-Date: Tue, 04 Oct 2022 20:14:14 +0000

        Jamal Carvalho (Gerrit)

        unread,
        Oct 4, 2022, 4:30:09 PM10/4/22
        to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

        Attention is currently required from: Hyang-Ah Hana Kim, Jamal Carvalho.

        Jamal Carvalho uploaded patch set #3 to this change.

        View Change

        The following approvals got outdated and were removed: Run-TryBot+1 by Jamal Carvalho, TryBot-Result+1 by kokoro

        docs: update docs for pinned command-line tools

        Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
        ---
        M docs/advanced.md
        M docs/tools.md
        2 files changed, 15 insertions(+), 1 deletion(-)

        To view, visit change 438635. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
        Gerrit-Change-Number: 438635
        Gerrit-PatchSet: 3
        Gerrit-Owner: Jamal Carvalho <ja...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-Attention: Jamal Carvalho <ja...@golang.org>
        Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-MessageType: newpatchset

        Jamal Carvalho (Gerrit)

        unread,
        Oct 4, 2022, 4:30:22 PM10/4/22
        to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, kokoro, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

        Jamal Carvalho submitted this change.

        View Change



        1 is the latest approved patch-set.
        The change was submitted with unreviewed changes in the following files:

        ```
        The name of the file: docs/advanced.md
        Insertions: 3, Deletions: 2.

        @@ -62,8 +62,9 @@
        name.

        The extension uses pinned versions of command-line tools. See the pinned versions
        -in tools information [here](../src/goToolsInformation.ts). To use an alternate
        -version of a tool install it manually with with go install.
        +in tools information
        +[here](https://github.com/golang/vscode-go/blob/master/src/goToolsInformation.ts).
        +To use an alternate version of a tool install it manually with with go install.

        ## Using a custom linter

        ```
        ```
        The name of the file: docs/tools.md
        Insertions: 1, Deletions: 1.

        @@ -2,7 +2,7 @@

        This document describes the tools that power the VS Code Go extension.

        -Tools will be installed by default when you install the extension. You can also manually install or update all of these tools by running the [`Go: Install/Update Tools`](commands.md#go-installupdate-tools) command. The extension uses pinned versions of command-line tools. See the pinned versions in tools information [here](../src/goToolsInformation.ts). If any tools are missing, you will see an `Analysis Tools Missing` warning in the bottom-right corner of the editor, which will prompt you to install these tools.
        +Tools will be installed by default when you install the extension. You can also manually install or update all of these tools by running the [`Go: Install/Update Tools`](commands.md#go-installupdate-tools) command. The extension uses pinned versions of command-line tools. See the pinned versions in tools information [here](https://github.com/golang/vscode-go/blob/master/src/goToolsInformation.ts). If any tools are missing, you will see an `Analysis Tools Missing` warning in the bottom-right corner of the editor, which will prompt you to install these tools.

        VS Code Go will install the tools to your `$GOPATH/bin` by default.

        ```

        Approvals: Hyang-Ah Hana Kim: Looks good to me, approved Jamal Carvalho: Run TryBots
        docs: update docs for pinned command-line tools

        Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
        Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/438635
        Run-TryBot: Jamal Carvalho <ja...@golang.org>
        Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>

        ---
        M docs/advanced.md
        M docs/tools.md
        2 files changed, 18 insertions(+), 1 deletion(-)

        diff --git a/docs/advanced.md b/docs/advanced.md
        index 99136a3..a2c0ba0 100644
        --- a/docs/advanced.md
        +++ b/docs/advanced.md
        @@ -61,6 +61,11 @@
        extension to use different tool location, for example a wrapper with a different
        name.

        +The extension uses pinned versions of command-line tools. See the pinned versions
        +in tools information
        +[here](https://github.com/golang/vscode-go/blob/master/src/goToolsInformation.ts).
        +To use an alternate version of a tool install it manually with with go install.
        +
        ## Using a custom linter

        A commonly customized feature is the linter, which is the tool used to provide
        diff --git a/docs/tools.md b/docs/tools.md
        index a866e97..4bcc376 100644
        --- a/docs/tools.md
        +++ b/docs/tools.md
        @@ -2,7 +2,7 @@

        This document describes the tools that power the VS Code Go extension.

        -Tools will be installed by default when you install the extension. You can also manually install or update all of these tools by running the [`Go: Install/Update Tools`](commands.md#go-installupdate-tools) command. If any tools are missing, you will see an `Analysis Tools Missing` warning in the bottom-right corner of the editor, which will prompt you to install these tools.
        +Tools will be installed by default when you install the extension. You can also manually install or update all of these tools by running the [`Go: Install/Update Tools`](commands.md#go-installupdate-tools) command. The extension uses pinned versions of command-line tools. See the pinned versions in tools information [here](https://github.com/golang/vscode-go/blob/master/src/goToolsInformation.ts). If any tools are missing, you will see an `Analysis Tools Missing` warning in the bottom-right corner of the editor, which will prompt you to install these tools.

        VS Code Go will install the tools to your `$GOPATH/bin` by default.


        To view, visit change 438635. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: I95e412bc79ca393f09f32edf43955c0fc83ee07e
        Gerrit-Change-Number: 438635
        Gerrit-PatchSet: 4
        Gerrit-Owner: Jamal Carvalho <ja...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Jamal Carvalho <ja...@golang.org>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages