[crypto] chacha20: improve performance for riscv64

5 views
Skip to first unread message

Meng Zhuo (Gerrit)

unread,
Oct 13, 2025, 12:30:17 AM10/13/25
to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Message from Meng Zhuo

Set Ready For Review

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crypto
Gerrit-Branch: master
Gerrit-Change-Id: Ifc58554a77845e2b22cc6f0dbaa62e9f54c746de
Gerrit-Change-Number: 711075
Gerrit-PatchSet: 3
Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Oct 2025 04:30:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Meng Zhuo (Gerrit)

unread,
Oct 13, 2025, 12:31:00 AM10/13/25
to Meng Zhuo, goph...@pubsubhelper.golang.org, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda, Joel Sing, Mark Ryan and Pengcheng Wang

Meng Zhuo voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Filippo Valsorda
  • Joel Sing
  • Mark Ryan
  • Pengcheng Wang
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crypto
Gerrit-Branch: master
Gerrit-Change-Id: Ifc58554a77845e2b22cc6f0dbaa62e9f54c746de
Gerrit-Change-Number: 711075
Gerrit-PatchSet: 3
Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Filippo Valsorda <fil...@golang.org>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
Gerrit-Attention: Filippo Valsorda <fil...@golang.org>
Gerrit-Attention: Joel Sing <jo...@sing.id.au>
Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
Gerrit-Comment-Date: Mon, 13 Oct 2025 04:30:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Meng Zhuo (Gerrit)

unread,
Oct 30, 2025, 9:21:35 AM10/30/25
to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

Meng Zhuo voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
  • Mark Ryan
  • Pengcheng Wang
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crypto
Gerrit-Branch: master
Gerrit-Change-Id: Ifc58554a77845e2b22cc6f0dbaa62e9f54c746de
Gerrit-Change-Number: 711075
Gerrit-PatchSet: 4
Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
Gerrit-Attention: Joel Sing <jo...@sing.id.au>
Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 13:21:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Julian Zhu (Gerrit)

unread,
1:55 AM (3 hours ago) 1:55 AM
to Meng Zhuo, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
Attention needed from Joel Sing, Mark Ryan, Meng Zhuo and Pengcheng Wang

Julian Zhu voted and added 1 comment

Votes added by Julian Zhu

Code-Review+2

1 comment

File chacha20/chacha_noasm.go
Line 5, Patchset 4 (Latest)://go:build (!arm64 && !s390x && !ppc64 && !ppc64le && !(riscv64 && go1.26)) || !gc || purego
Julian Zhu . resolved

I think we should wait for go/x/crypto minimum require update to go 1.26

Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
  • Mark Ryan
  • Meng Zhuo
  • Pengcheng Wang
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crypto
Gerrit-Branch: master
Gerrit-Change-Id: Ifc58554a77845e2b22cc6f0dbaa62e9f54c746de
Gerrit-Change-Number: 711075
Gerrit-PatchSet: 4
Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
Gerrit-Attention: Joel Sing <jo...@sing.id.au>
Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Attention: Mark Ryan <mark...@meta.com>
Gerrit-Comment-Date: Wed, 10 Jun 2026 05:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages