[oscar] internal/sandbox: go fix -slicescontains ./...
1 view
Skip to first unread message
Hyang-Ah Hana Kim (Gerrit)
Feb 26, 2026, 10:07:57 PM (20 hours ago) Feb 26
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Hyang-Ah Hana Kim has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/sandbox: go fix -slicescontains ./...
Change-Id: Id556473f997e1c0b294a561ac2ed7d9186fcbd7f
Change diff
diff --git a/internal/sandbox/sandbox.go b/internal/sandbox/sandbox.go
index c9704a2..6acd362 100644
--- a/internal/sandbox/sandbox.go
+++ b/internal/sandbox/sandbox.go
@@ -15,6 +15,7 @@
"os"
"os/exec"
"path/filepath"
+ "slices"
"time"
)
@@ -185,10 +186,5 @@
}
func isBindMount(m mount) bool {
- for _, opt := range m.Options {
- if opt == "bind" {
- return true
- }
- }
- return false
+ return slices.Contains(m.Options, "bind")
}
Change information
Files:
- M internal/sandbox/sandbox.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 6 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
Feb 26, 2026, 11:43:59 PM (19 hours ago) Feb 26
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Ian Lance Taylor voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
4:39 PM (2 hours ago) 4:39 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
4:44 PM (2 hours ago) 4:44 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Hyang-Ah Hana Kim submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/sandbox: go fix -slicescontains ./...
Change-Id: Id556473f997e1c0b294a561ac2ed7d9186fcbd7f
Reviewed-on: https://go-review.googlesource.com/c/oscar/+/749647
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Files:
- M internal/sandbox/sandbox.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 6 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Ian Lance Taylor
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages