[go] archive/tar: use explicit verb for headerError's Error

Gerrit Bot (Gerrit)

unread,

Jun 6, 2023, 10:17:00 AM6/6/23

to goph...@pubsubhelper.golang.org, Sense As, golang-co...@googlegroups.com

Gerrit Bot has uploaded this change for review.

archive/tar: use explicit verb for headerError's Error

Since strings.Join returns a string, use the explicit verb "%s" instead of
"%v" to keep the same style as the previous "prefix".

Change-Id: Ieb27a890d5f91e12749190dac250c7a793fffcea
GitHub-Last-Rev: 3c1d7189814a756286b1b24f462670a8fbd8b041
GitHub-Pull-Request: golang/go#60629
---
M src/archive/tar/common.go
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/archive/tar/common.go b/src/archive/tar/common.go
index dc9d350..7c32a22 100644
--- a/src/archive/tar/common.go
+++ b/src/archive/tar/common.go
@@ -53,7 +53,7 @@
 	if len(ss) == 0 {
 		return prefix
 	}
-	return fmt.Sprintf("%s: %v", prefix, strings.Join(ss, "; and "))
+	return fmt.Sprintf("%s: %s", prefix, strings.Join(ss, "; and "))
 }
 
 // Type flags for Header.Typeflag.

To view, visit change 501175. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit Bot (Gerrit)

unread,

Jun 6, 2023, 10:30:10 AM6/6/23

to Sense As, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Joseph Tsai.

Gerrit Bot uploaded patch set #2 to this change.

View Change

archive/tar: use explicit verb for headerError's Error

Since strings.Join returns a string, use the explicit verb "%s"
instead of "%v" to keep the same style as the previous "prefix".

Change-Id: Ieb27a890d5f91e12749190dac250c7a793fffcea
GitHub-Last-Rev: 3c1d7189814a756286b1b24f462670a8fbd8b041
GitHub-Pull-Request: golang/go#60629
---
M src/archive/tar/common.go
1 file changed, 1 insertion(+), 1 deletion(-)

To view, visit change 501175. To unsubscribe, or for help writing mail filters, visit settings.

Ian Lance Taylor (Gerrit)

unread,

Jun 6, 2023, 5:39:14 PM6/6/23

to Gerrit Bot, Sense As, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Joseph Tsai, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Joseph Tsai.

Patch set 2:Run-TryBot +1

View Change

To view, visit change 501175. To unsubscribe, or for help writing mail filters, visit settings.

Gopher Robot (Gerrit)

unread,

Jun 23, 2023, 11:50:16 AM6/23/23

to Gerrit Bot, Sense As, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Joseph Tsai, golang-co...@googlegroups.com

Gopher Robot abandoned this change.

View Change

Abandoned

GitHub PR golang/go#60629 has been closed.

To view, visit change 501175. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward